Re: [Buildroot] [PATCH] package/libfuse3: fix build failure with no NPTL

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Giulio,

On Sat, 26 Apr 2025 00:31:40 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:

> Add local patches, one upstreamed and one pending upstream to fix the
> presence of function pthread_setname_np in runtime.
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
>  .../0001-Fix-meson-function-tests.patch       | 121 ++++++++++++++++++
>  ...ke-special_funcs-check-more-reliable.patch |  41 ++++++
>  2 files changed, 162 insertions(+)
>  create mode 100644 package/libfuse3/0001-Fix-meson-function-tests.patch
>  create mode 100644 package/libfuse3/0002-meson.build-make-special_funcs-check-more-reliable.patch

Applied to master, thanks. However, I had to improve the commit log
quite a bit, because it was missing two critical information:

- Since when the problem started happening, so that we know if the fix
  needs to be backported or not

- Reference to an autobuilder failure

So I ended up with:

    package/libfuse3: fix build failure with no NPTL
    
    Since the bump of libfuse3 from 3.16.2 to 3.17.1 in Buildroot commit
    a4430578aeb6ca460813f4ff7d833cdd839a3249, libfuse3 uses
    pthread_setname_np() which is only available with NPTL.
    
    Some initial fixes were made upstream, but are insufficient to fully
    fix the problem, so this commit brings additional upstream patches
    fixing the issue completely.
    
    Fixes:
    
      https://autobuild.buildroot.net/results/f3cfaa8ed63483858ffa32b719ea4be68ba6c4f3/
    
    Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
    Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Also, since your patch has been accepted upstream, I replaced the
Upstream: link to point to the final upstream commit.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot