Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Lang Daniel via buildroot <buildroot@buildroot.org>
Cc: Lang Daniel <d.lang@abatec.at>,
	"tuzakli.refik@gmail.com" <tuzakli.refik@gmail.com>,
	Gary Bisson <bisson.gary@gmail.com>
Subject: Re: [Buildroot] [PATCH v3] package/freescale-imx/imx-gpu-viv: fix aarch64 framebuffer support
Date: Sun, 18 May 2025 22:43:48 +0200	[thread overview]
Message-ID: <20250518224348.1f1ad6da@windsurf> (raw)
In-Reply-To: <VI1P190MB04933DDA75BE1BC9A23B06929FB99@VI1P190MB0493.EURP190.PROD.OUTLOOK.COM>

Hello Daniel,

On Mon, 13 Mar 2023 09:16:31 +0000
Lang Daniel via buildroot <buildroot@buildroot.org> wrote:

> Since e8df0f7 (package/freescale-imx/imx-gpu-viv: bump to version 6.4.3.p4.4)
> the fb folder for aarch64 is no longer included in the archive.
> 
> According to meta-freescale [0] the framebuffer output can be enabled on
> IMX8 by using the wayland libraries together with egl.pc.
> 
> Tested on an imx8mn by running kmscube. EGL and GLES support detected.
> 
> [0]: https://git.yoctoproject.org/meta-freescale/tree/recipes-graphics/imx-gpu-viv/imx-gpu-viv-6.inc
> 
> Fixes:
> cp: cannot stat '/home/d.lang/buildroot/output/build/imx-gpu-viv-6.4.3.p4.4-aarch64/gpu-core/usr/lib/fb/*': No such file or directory
> 
> Signed-off-by: Daniel Lang <d.lang@abatec.at>
> ---
> v1 -> v2:
>  - Mention current build failure
>  - Add information for egl.pc selection
> v2 -> v3:
> - Introduce BR2_PACKAGE_IMX_GPU_VIV_USES_WAYLAND
> ---
>  package/freescale-imx/imx-gpu-viv/Config.in   | 16 +++++++++-----
>  .../freescale-imx/imx-gpu-viv/imx-gpu-viv.mk  | 22 +++++++++++--------
>  2 files changed, 23 insertions(+), 15 deletions(-)

Believe it or not, but we finally reviewed and applied your patch. I
did rework the Config.in logic though, which I found quite convoluted
in your proposal. You can check the final result at:

  https://gitlab.com/buildroot.org/buildroot/-/commit/faf2b8a6277c1a10ca08e5ad8ecb488d70a03de4

Also, the commit message was reworked to better reflect what is
happening: your commit was no longer "fixing" fb support on aarch64,
since it had since then been disabled.

Don't hesitate to give it a test and let me know the result.

Thanks a lot, and again sorry for the delay :/

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2025-05-18 20:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-13  9:16 [Buildroot] [PATCH v3] package/freescale-imx/imx-gpu-viv: fix aarch64 framebuffer support Lang Daniel via buildroot
2023-05-12 16:07 ` Gary Bisson
2025-05-18 20:43 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250518224348.1f1ad6da@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bisson.gary@gmail.com \
    --cc=d.lang@abatec.at \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tuzakli.refik@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox