From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: ibai.erkiaga-elorza@amd.com, arnout@mind.be,
brandon.maier@collins.com, ju.o@free.fr,
thomas.petazzoni@bootlin.com, buildroot@buildroot.org,
fabio.caccamo@amd.com, romain.naour@smile.fr,
michal.simek@amd.com
Subject: Re: [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions
Date: Mon, 19 May 2025 17:41:36 +0200 [thread overview]
Message-ID: <20250519174136.676b936f@booty> (raw)
In-Reply-To: <20250519083632.1930804-1-neal.frager@amd.com>
On Mon, 19 May 2025 09:36:28 +0100
Neal Frager <neal.frager@amd.com> wrote:
> The versal vpl_gen_fixed.pdi file is not a target executable, so the file
> permissions should be 644 instead of 755.
>
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
^^^^^^^^^^^^^^^^^^^^^^^^^^
False, I haven't reviewed this patch because this is the first time you
send it.
However I did so now, I'm OK with the content, and you can keep my
R-by line.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-05-19 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 8:36 [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Neal Frager via buildroot
2025-05-19 8:36 ` [Buildroot] [PATCH v4 2/4] boot/xilinx-prebuilt: add segmented config support Neal Frager via buildroot
2025-05-19 8:36 ` [Buildroot] [PATCH v4 3/4] board/versal: change pdi filename to boot.pdi Neal Frager via buildroot
2025-05-19 8:36 ` [Buildroot] [PATCH v4 4/4] boot/xilinx-prebuilt: install pld.pdi to target Neal Frager via buildroot
2025-05-19 15:39 ` Luca Ceresoli via buildroot
2025-05-19 15:41 ` Luca Ceresoli via buildroot [this message]
2025-05-19 15:51 ` [Buildroot] [PATCH v4 1/4] boot/xilinx-prebuilt: change versal pdi file permissions Frager, Neal via buildroot
2025-06-09 19:51 ` Julien Olivain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250519174136.676b936f@booty \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=brandon.maier@collins.com \
--cc=fabio.caccamo@amd.com \
--cc=ibai.erkiaga-elorza@amd.com \
--cc=ju.o@free.fr \
--cc=luca.ceresoli@bootlin.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox