[Buildroot] [PATCH v2 0/6] package/qt6/qt6tools: fix build failures

[Buildroot] [PATCH v2 0/6] package/qt6/qt6tools: fix build failures

[Roy Kollen Svendsen]

These patches were originally part of the series bumping Qt6 to 6.9.0.

The fixes were rebased on the old 6.8.1 version, and reordered to match
the order in which they actually appeared.

The commit messages and comments were updated.

Backport to: 2025.02.x, 2025.05.x

Changes v1 -> v2:
  - add missing patch "package/qt6/qt6tools: build without clang support"

Roy Kollen Svendsen (6):
  package/qt6/qt6base: add hidden options needed by qt6tools
  package/qt6/qt6tools: fix linguist build failure
  package/qt6/qt6tools: fix designer build failure
  package/qt6/qt6tools: fix assistant build failure
  package/qt6/qt6tools: fix assistant build failure
  package/qt6/qt6tools: build without clang support

 package/qt6/qt6base/Config.in.host  | 14 ++++++++++
 package/qt6/qt6base/qt6base.mk      | 40 +++++++++++++++++++++++++++--
 package/qt6/qt6tools/Config.in      | 40 +++++++++++++++++++++++++++++
 package/qt6/qt6tools/Config.in.host | 17 +++++++++---
 package/qt6/qt6tools/qt6tools.mk    | 34 ++++++++++++++++++++++++
 5 files changed, 140 insertions(+), 5 deletions(-)

-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 1/6] package/qt6/qt6base: add hidden options needed by qt6tools

[Roy Kollen Svendsen]

Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
 package/qt6/qt6base/Config.in.host | 14 +++++++++++
 package/qt6/qt6base/qt6base.mk     | 40 ++++++++++++++++++++++++++++--
 2 files changed, 52 insertions(+), 2 deletions(-)

diff --git a/package/qt6/qt6base/Config.in.host b/package/qt6/qt6base/Config.in.host
index e38e99fbaf..89e78127ef 100644
--- a/package/qt6/qt6base/Config.in.host
+++ b/package/qt6/qt6base/Config.in.host
@@ -11,6 +11,16 @@ config BR2_PACKAGE_HOST_QT6BASE_GUI
 config BR2_PACKAGE_HOST_QT6BASE_NETWORK
 	bool
 
+# https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+config BR2_PACKAGE_HOST_QT6BASE_PNG
+	bool
+
+# https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
+config BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT
+	bool
+	# yes, print support needs widgets
+	depends on BR2_PACKAGE_HOST_QT6BASE_WIDGETS
+
 # Select this if you need host qt6 tools that require the Qt::Test module
 # (e.g. qmltestrunner).
 config BR2_PACKAGE_HOST_QT6BASE_TEST
@@ -21,5 +31,9 @@ config BR2_PACKAGE_HOST_QT6BASE_TEST
 config BR2_PACKAGE_HOST_QT6BASE_SQL
 	bool
 
+# https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+config BR2_PACKAGE_HOST_QT6BASE_SQLITE
+	bool
+
 config BR2_PACKAGE_HOST_QT6BASE_WIDGETS
 	bool
diff --git a/package/qt6/qt6base/qt6base.mk b/package/qt6/qt6base/qt6base.mk
index 39fb440be7..b0d480e360 100644
--- a/package/qt6/qt6base/qt6base.mk
+++ b/package/qt6/qt6base/qt6base.mk
@@ -112,16 +112,35 @@ HOST_QT6BASE_CONF_OPTS += \
 	-DFEATURE_xcb=OFF \
 	-DFEATURE_opengl=OFF -DINPUT_opengl=no \
 	-DFEATURE_harfbuzz=OFF \
-	-DFEATURE_png=OFF \
 	-DFEATURE_gif=OFF \
 	-DFEATURE_jpeg=OFF \
-	-DFEATURE_printsupport=OFF \
 	-DFEATURE_kms=OFF \
 	-DFEATURE_fontconfig=OFF \
 	-DFEATURE_libinput=OFF \
 	-DFEATURE_tslib=OFF \
 	-DFEATURE_eglfs=OFF
 
+# The PNG feature is required by qt6tools (qhelpgenerator and assistant):
+# https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+ifeq ($(BR2_PACKAGE_HOST_QT6BASE_PNG),y)
+HOST_QT6BASE_CONF_OPTS += \
+	-DFEATURE_png=ON \
+	-DFEATURE_system_png=ON
+HOST_QT6BASE_DEPENDENCIES += libpng
+else
+HOST_QT6BASE_CONF_OPTS += -DFEATURE_png=OFF
+endif
+
+# The print support feature is required by qt6tools (qhelpgenerator and assistant):
+# https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
+ifeq ($(BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT),y)
+HOST_QT6BASE_CONF_OPTS += \
+	-DFEATURE_printsupport=ON \
+	-DFEATURE_cups=OFF
+else
+HOST_QT6BASE_CONF_OPTS += -DFEATURE_printsupport=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_HOST_QT6BASE_WIDGETS),y)
 HOST_QT6BASE_CONF_OPTS += -DFEATURE_widgets=ON
 else
@@ -144,6 +163,23 @@ endif
 # available.
 ifeq ($(BR2_PACKAGE_HOST_QT6BASE_SQL),y)
 HOST_QT6BASE_CONF_OPTS += -DFEATURE_sql=ON
+HOST_QT6BASE_CONF_OPTS += \
+	-DFEATURE_sql_db2=OFF \
+	-DFEATURE_sql_ibase=OFF \
+	-DFEATURE_sql_oci=OFF \
+	-DFEATURE_sql_odbc=OFF
+
+# The SQLite plugin is required by qt6tools (qhelpgenerator and assistant):
+# https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+ifeq ($(BR2_PACKAGE_HOST_QT6BASE_SQLITE),y)
+HOST_QT6BASE_CONF_OPTS += \
+	-DFEATURE_sql_sqlite=ON \
+	-DFEATURE_system_sqlite=ON
+HOST_QT6BASE_DEPENDENCIES += sqlite
+else
+HOST_QT6BASE_CONF_OPTS += -DFEATURE_sql_sqlite=OFF
+endif
+
 else
 HOST_QT6BASE_CONF_OPTS += -DFEATURE_sql=OFF
 endif
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 2/6] package/qt6/qt6tools: fix linguist build failure

[Roy Kollen Svendsen]

Fixes:
-- Could NOT find Qt6LinguistTools (missing: Qt6LinguistTools_DIR)
CMake Error at <...>/output/build/qt6base-6.8.1/cmake/QtToolHelpers.cmake:768 (message):
  Failed to find the host tool "Qt6::lconvert".  It is part of the
  Qt6LinguistTools package, but the package could not be found.  Make sure
  you have built and installed the host Linguist module, which will ensure
  the creation of the Qt6LinguistTools package.
Call Stack (most recent call first):
  <...>/output/build/qt6base-6.8.1/cmake/QtToolHelpers.cmake:83 (qt_internal_find_tool)
  src/linguist/lconvert/CMakeLists.txt:9 (qt_internal_add_tool)

The above error can be triggered by the following defconfig:
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_MUSL_STABLE=y
BR2_PACKAGE_QT6=y
BR2_PACKAGE_QT6BASE_GUI=y
BR2_PACKAGE_QT6BASE_PNG=y
BR2_PACKAGE_QT6BASE_WIDGETS=y
BR2_PACKAGE_QT6TOOLS=y

Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
 package/qt6/qt6tools/Config.in   | 14 ++++++++++++++
 package/qt6/qt6tools/qt6tools.mk |  6 ++++++
 2 files changed, 20 insertions(+)

diff --git a/package/qt6/qt6tools/Config.in b/package/qt6/qt6tools/Config.in
index 1828e5f043..8fff08b3e6 100644
--- a/package/qt6/qt6tools/Config.in
+++ b/package/qt6/qt6tools/Config.in
@@ -11,3 +11,17 @@ config BR2_PACKAGE_QT6TOOLS
 	  and design of applications.
 
 	  https://github.com/qt/qttools
+
+if BR2_PACKAGE_QT6TOOLS
+
+config BR2_PACKAGE_QT6TOOLS_LINGUIST
+	bool "linguist"
+	select BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS # lconvert is needed for linguist to build
+	select BR2_PACKAGE_QT6BASE_GUI
+	select BR2_PACKAGE_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/src/linguist/CMakeLists.txt?h=6.8.1#n17
+	select BR2_PACKAGE_QT6BASE_WIDGETS # https://code.qt.io/cgit/qt/qttools.git/tree/src/linguist/CMakeLists.txt?h=6.8.1#n17
+	help
+	  Tool for translating Qt applications, including editors and
+	  utilities for managing translation files.
+
+endif
diff --git a/package/qt6/qt6tools/qt6tools.mk b/package/qt6/qt6tools/qt6tools.mk
index b063f08887..25cbb82c84 100644
--- a/package/qt6/qt6tools/qt6tools.mk
+++ b/package/qt6/qt6tools/qt6tools.mk
@@ -41,6 +41,12 @@ ifeq ($(BR2_PACKAGE_QT6DECLARATIVE),y)
 QT6TOOLS_DEPENDENCIES += qt6declarative
 endif
 
+ifeq ($(BR2_PACKAGE_QT6TOOLS_LINGUIST),y)
+QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=ON
+else
+QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=OFF
+endif
+
 HOST_QT6TOOLS_CONF_OPTS = \
 	-DQT_BUILD_EXAMPLES=OFF \
 	-DQT_BUILD_TESTS=OFF
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 3/6] package/qt6/qt6tools: fix designer build failure

[Roy Kollen Svendsen]

Fixes:
CMake Error at <...>/output/build/qt6base-6.8.1/cmake/QtPublicWalkLibsHelpers.cmake:267 (message):
  The Xml target is mentioned as a dependency for Designer, but not declared.
Call Stack (most recent call first):
  <...>/output/build/qt6base-6.8.1/cmake/QtPrlHelpers.cmake:8 (__qt_internal_walk_libs)
  <...>/output/build/qt6base-6.8.1/cmake/QtPrlHelpers.cmake:47 (qt_collect_libs)
  <...>/buildroot/output/build/qt6base-6.8.1/cmake/QtModuleHelpers.cmake:1027 (qt_generate_prl_file)
  <...>/buildroot/output/build/qt6base-6.8.1/cmake/QtScopeFinalizerHelpers.cmake:24:EVAL:1 (qt_finalize_module)
  src/designer/src/lib/CMakeLists.txt:DEFERRED

The above error can be triggered by the following defconfig:
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_MUSL_STABLE=y
BR2_PACKAGE_QT6=y
BR2_PACKAGE_QT6BASE_GUI=y
BR2_PACKAGE_QT6BASE_PNG=y
BR2_PACKAGE_QT6BASE_WIDGETS=y
BR2_PACKAGE_QT6TOOLS=y
BR2_PACKAGE_QT6TOOLS_LINGUIST=y

Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
 package/qt6/qt6tools/Config.in   | 11 +++++++++++
 package/qt6/qt6tools/qt6tools.mk |  6 ++++++
 2 files changed, 17 insertions(+)

diff --git a/package/qt6/qt6tools/Config.in b/package/qt6/qt6tools/Config.in
index 8fff08b3e6..5828715aa6 100644
--- a/package/qt6/qt6tools/Config.in
+++ b/package/qt6/qt6tools/Config.in
@@ -14,6 +14,17 @@ config BR2_PACKAGE_QT6TOOLS
 
 if BR2_PACKAGE_QT6TOOLS
 
+config BR2_PACKAGE_QT6TOOLS_DESIGNER
+	bool "designer"
+	select BR2_PACKAGE_QT6BASE_GUI # https://code.qt.io/cgit/qt/qttools.git/tree/src/designer/src/designer/CMakeLists.txt?h=6.8.1#n41
+	select BR2_PACKAGE_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n64
+	select BR2_PACKAGE_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n64
+	select BR2_PACKAGE_QT6BASE_WIDGETS # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n64
+	select BR2_PACKAGE_QT6BASE_XML # https://code.qt.io/cgit/qt/qttools.git/tree/src/designer/src/lib/CMakeLists.txt?h=6.8.1#n182
+	help
+	  Graphical tool for designing and building Qt user interfaces
+	  with a drag-and-drop editor.
+
 config BR2_PACKAGE_QT6TOOLS_LINGUIST
 	bool "linguist"
 	select BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS # lconvert is needed for linguist to build
diff --git a/package/qt6/qt6tools/qt6tools.mk b/package/qt6/qt6tools/qt6tools.mk
index 25cbb82c84..f5f2dc64b0 100644
--- a/package/qt6/qt6tools/qt6tools.mk
+++ b/package/qt6/qt6tools/qt6tools.mk
@@ -41,6 +41,12 @@ ifeq ($(BR2_PACKAGE_QT6DECLARATIVE),y)
 QT6TOOLS_DEPENDENCIES += qt6declarative
 endif
 
+ifeq ($(BR2_PACKAGE_QT6TOOLS_DESIGNER),y)
+QT6TOOLS_CONF_OPTS += -DFEATURE_designer=ON
+else
+QT6TOOLS_CONF_OPTS += -DFEATURE_designer=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_QT6TOOLS_LINGUIST),y)
 QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=ON
 else
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 4/6] package/qt6/qt6tools: fix assistant build failure

[Roy Kollen Svendsen]

Fixes:
CMake Error at <...>/output/build/qt6base-6.8.1/cmake/QtToolHelpers.cmake:768 (message):
  Failed to find the host tool "Qt6::qhelpgenerator".  It is part of the
  Qt6ToolsTools package, but the package did not contain the tool.  Make sure
  that the host module Tools was built with all features enabled (no
  explicitly disabled tools).
Call Stack (most recent call first):
  <...>/buildroot/output/build/qt6base-6.8.1/cmake/QtToolHelpers.cmake:83 (qt_internal_find_tool)
  src/assistant/qhelpgenerator/CMakeLists.txt:9 (qt_internal_add_tool)

The above error can be triggered by the following defconfig:
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_MUSL_STABLE=y
BR2_PACKAGE_QT6=y
BR2_PACKAGE_QT6BASE_GUI=y
BR2_PACKAGE_QT6BASE_PNG=y
BR2_PACKAGE_QT6BASE_PRINTSUPPORT=y
BR2_PACKAGE_QT6BASE_SQL=y
BR2_PACKAGE_QT6BASE_SQLITE=y
BR2_PACKAGE_QT6BASE_WIDGETS=y
BR2_PACKAGE_QT6TOOLS=y

Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
 package/qt6/qt6tools/Config.in      | 14 ++++++++++++++
 package/qt6/qt6tools/Config.in.host | 16 +++++++++++++---
 package/qt6/qt6tools/qt6tools.mk    | 12 ++++++++++++
 3 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/package/qt6/qt6tools/Config.in b/package/qt6/qt6tools/Config.in
index 5828715aa6..f03ddf29a5 100644
--- a/package/qt6/qt6tools/Config.in
+++ b/package/qt6/qt6tools/Config.in
@@ -14,6 +14,20 @@ config BR2_PACKAGE_QT6TOOLS
 
 if BR2_PACKAGE_QT6TOOLS
 
+config BR2_PACKAGE_QT6TOOLS_ASSISTANT
+	bool "assistant"
+	select BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT # qhelpgenerator
+	select BR2_PACKAGE_QT6BASE_GUI
+	select BR2_PACKAGE_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+	select BR2_PACKAGE_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+	select BR2_PACKAGE_QT6BASE_PRINTSUPPORT # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
+	select BR2_PACKAGE_QT6BASE_SQL # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
+	select BR2_PACKAGE_QT6BASE_SQLITE # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+	select BR2_PACKAGE_QT6BASE_WIDGETS # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+	help
+	  Viewer for Qt help files (.qch), providing searchable and
+	  navigable documentation for Qt and custom projects.
+
 config BR2_PACKAGE_QT6TOOLS_DESIGNER
 	bool "designer"
 	select BR2_PACKAGE_QT6BASE_GUI # https://code.qt.io/cgit/qt/qttools.git/tree/src/designer/src/designer/CMakeLists.txt?h=6.8.1#n41
diff --git a/package/qt6/qt6tools/Config.in.host b/package/qt6/qt6tools/Config.in.host
index 7a6f8a5176..0ea214168d 100644
--- a/package/qt6/qt6tools/Config.in.host
+++ b/package/qt6/qt6tools/Config.in.host
@@ -2,9 +2,6 @@ config BR2_PACKAGE_HOST_QT6TOOLS
 	bool "host qt6tools"
 	# The Qt Qt Network module is required
 	select BR2_PACKAGE_HOST_QT6BASE_NETWORK
-	# Requires the Qt Sql module to build the qhelpgenerator
-	# tool, if target support for Sql is present
-	select BR2_PACKAGE_HOST_QT6BASE_SQL if BR2_PACKAGE_QT6BASE_SQL
 	help
 	  Qt is a cross-platform application and UI framework for
 	  developers using C++.
@@ -16,6 +13,19 @@ config BR2_PACKAGE_HOST_QT6TOOLS
 
 if BR2_PACKAGE_HOST_QT6TOOLS
 
+config BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT
+	bool "host assistant"
+	select BR2_PACKAGE_HOST_QT6BASE_GUI
+	select BR2_PACKAGE_HOST_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+	select BR2_PACKAGE_HOST_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+	select BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
+	select BR2_PACKAGE_HOST_QT6BASE_SQL # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
+	select BR2_PACKAGE_HOST_QT6BASE_SQLITE # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+	select BR2_PACKAGE_HOST_QT6BASE_WIDGETS # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
+	help
+	  Viewer for Qt help files (.qch), providing searchable and
+	  navigable documentation for Qt and custom projects.
+
 config BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS
 	bool "host linguist tools"
 	help
diff --git a/package/qt6/qt6tools/qt6tools.mk b/package/qt6/qt6tools/qt6tools.mk
index f5f2dc64b0..2e3268558e 100644
--- a/package/qt6/qt6tools/qt6tools.mk
+++ b/package/qt6/qt6tools/qt6tools.mk
@@ -41,6 +41,12 @@ ifeq ($(BR2_PACKAGE_QT6DECLARATIVE),y)
 QT6TOOLS_DEPENDENCIES += qt6declarative
 endif
 
+ifeq ($(BR2_PACKAGE_QT6TOOLS_ASSISTANT),y)
+QT6TOOLS_CONF_OPTS += -DFEATURE_assistant=ON
+else
+QT6TOOLS_CONF_OPTS += -DFEATURE_assistant=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_QT6TOOLS_DESIGNER),y)
 QT6TOOLS_CONF_OPTS += -DFEATURE_designer=ON
 else
@@ -59,6 +65,12 @@ HOST_QT6TOOLS_CONF_OPTS = \
 
 HOST_QT6TOOLS_DEPENDENCIES = host-qt6base
 
+ifeq ($(BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT),y)
+HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_assistant=ON
+else
+HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_assistant=OFF
+endif
+
 ifeq ($(BR2_PACKAGE_HOST_QT6TOOLS_LINGUIST_TOOLS),y)
 HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_linguist=ON
 # When we have qt6declarative for the target, we need to build the
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 5/6] package/qt6/qt6tools: fix assistant build failure

[Roy Kollen Svendsen]

Fixes:
<...>/output/build/host-qt6tools-6.8.1/src/assistant/help/qhelpenginecore.cpp:11:10:
fatal error: QtConcurrent/qtconcurrentrun.h: Ingen slik fil eller filkatalog
   11 | #include <QtConcurrent/qtconcurrentrun.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

The above error can be triggered by the following defconfig:
BR2_arm=y
BR2_cortex_a9=y
BR2_ARM_ENABLE_VFP=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_MUSL_STABLE=y
BR2_PACKAGE_QT6=y
BR2_PACKAGE_QT6TOOLS=y
BR2_PACKAGE_QT6TOOLS_ASSISTANT=y

Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
 package/qt6/qt6tools/Config.in      | 1 +
 package/qt6/qt6tools/Config.in.host | 1 +
 2 files changed, 2 insertions(+)

diff --git a/package/qt6/qt6tools/Config.in b/package/qt6/qt6tools/Config.in
index f03ddf29a5..f33ee13cee 100644
--- a/package/qt6/qt6tools/Config.in
+++ b/package/qt6/qt6tools/Config.in
@@ -17,6 +17,7 @@ if BR2_PACKAGE_QT6TOOLS
 config BR2_PACKAGE_QT6TOOLS_ASSISTANT
 	bool "assistant"
 	select BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT # qhelpgenerator
+	select BR2_PACKAGE_QT6BASE_CONCURRENT
 	select BR2_PACKAGE_QT6BASE_GUI
 	select BR2_PACKAGE_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
 	select BR2_PACKAGE_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
diff --git a/package/qt6/qt6tools/Config.in.host b/package/qt6/qt6tools/Config.in.host
index 0ea214168d..0e2a13d457 100644
--- a/package/qt6/qt6tools/Config.in.host
+++ b/package/qt6/qt6tools/Config.in.host
@@ -15,6 +15,7 @@ if BR2_PACKAGE_HOST_QT6TOOLS
 
 config BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT
 	bool "host assistant"
+	select BR2_PACKAGE_HOST_QT6BASE_CONCURRENT
 	select BR2_PACKAGE_HOST_QT6BASE_GUI
 	select BR2_PACKAGE_HOST_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
 	select BR2_PACKAGE_HOST_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH v2 6/6] package/qt6/qt6tools: build without clang support

[Roy Kollen Svendsen]

Fixes:
If external clang is available on the host system, the buildsystem tries
to use it. The result will be unpredictable. We can't use the version of
clang that is shipped with buildroot either, because it is too old. See:
https://code.qt.io/cgit/qt/qttools.git/tree/.cmake.conf?h=6.8.1. So we
disable clang support in qt6tools for now.

Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
---
 package/qt6/qt6tools/qt6tools.mk | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/package/qt6/qt6tools/qt6tools.mk b/package/qt6/qt6tools/qt6tools.mk
index 2e3268558e..fb248d3971 100644
--- a/package/qt6/qt6tools/qt6tools.mk
+++ b/package/qt6/qt6tools/qt6tools.mk
@@ -33,6 +33,12 @@ QT6TOOLS_CONF_OPTS = \
 	-DQT_BUILD_EXAMPLES=OFF \
 	-DQT_BUILD_TESTS=OFF
 
+# Disable clang support in qt6tools for now, as version 17 is needed:
+# https://code.qt.io/cgit/qt/qttools.git/tree/.cmake.conf?h=6.8.1
+# This also prevents qt6tools from using a random external clang if i
+# finds one on the host system.
+QT6TOOLS_CONF_OPTS += -DFEATURE_clang=OFF
+
 QT6TOOLS_DEPENDENCIES = \
 	qt6base \
 	host-qt6tools
@@ -63,6 +69,10 @@ HOST_QT6TOOLS_CONF_OPTS = \
 	-DQT_BUILD_EXAMPLES=OFF \
 	-DQT_BUILD_TESTS=OFF
 
+# Disable clang support in qt6tools for now, as version 17 is needed:
+# https://code.qt.io/cgit/qt/qttools.git/tree/.cmake.conf?h=6.8.1
+HOST_QT6TOOLS_CONF_OPTS += -DFEATURE_clang=OFF
+
 HOST_QT6TOOLS_DEPENDENCIES = host-qt6base
 
 ifeq ($(BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT),y)
-- 
2.49.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/6] package/qt6/qt6tools: fix linguist build failure

[Thomas Petazzoni via buildroot]

Hello Roy,

On Sun,  1 Jun 2025 12:12:56 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:

> Fixes:
> -- Could NOT find Qt6LinguistTools (missing: Qt6LinguistTools_DIR)
> CMake Error at <...>/output/build/qt6base-6.8.1/cmake/QtToolHelpers.cmake:768 (message):
>   Failed to find the host tool "Qt6::lconvert".  It is part of the
>   Qt6LinguistTools package, but the package could not be found.  Make sure
>   you have built and installed the host Linguist module, which will ensure
>   the creation of the Qt6LinguistTools package.
> Call Stack (most recent call first):
>   <...>/output/build/qt6base-6.8.1/cmake/QtToolHelpers.cmake:83 (qt_internal_find_tool)
>   src/linguist/lconvert/CMakeLists.txt:9 (qt_internal_add_tool)
> 
> The above error can be triggered by the following defconfig:
> BR2_arm=y
> BR2_cortex_a9=y
> BR2_ARM_ENABLE_VFP=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
> BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_MUSL_STABLE=y
> BR2_PACKAGE_QT6=y
> BR2_PACKAGE_QT6BASE_GUI=y
> BR2_PACKAGE_QT6BASE_PNG=y
> BR2_PACKAGE_QT6BASE_WIDGETS=y
> BR2_PACKAGE_QT6TOOLS=y
> 
> Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>

Thanks for the new iteration. However is Qt Linguist really a tool that
would be useful on the target? Isn't this a GUI tool used during
development, so something totally useless on the target, and that we
could disable unconditionally?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 3/6] package/qt6/qt6tools: fix designer build failure

[Thomas Petazzoni via buildroot]

Hello Roy,

On Sun,  1 Jun 2025 12:12:57 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:

> diff --git a/package/qt6/qt6tools/Config.in b/package/qt6/qt6tools/Config.in
> index 8fff08b3e6..5828715aa6 100644
> --- a/package/qt6/qt6tools/Config.in
> +++ b/package/qt6/qt6tools/Config.in
> @@ -14,6 +14,17 @@ config BR2_PACKAGE_QT6TOOLS
>  
>  if BR2_PACKAGE_QT6TOOLS
>  
> +config BR2_PACKAGE_QT6TOOLS_DESIGNER
> +	bool "designer"
> +	select BR2_PACKAGE_QT6BASE_GUI # https://code.qt.io/cgit/qt/qttools.git/tree/src/designer/src/designer/CMakeLists.txt?h=6.8.1#n41
> +	select BR2_PACKAGE_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n64
> +	select BR2_PACKAGE_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n64
> +	select BR2_PACKAGE_QT6BASE_WIDGETS # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n64
> +	select BR2_PACKAGE_QT6BASE_XML # https://code.qt.io/cgit/qt/qttools.git/tree/src/designer/src/lib/CMakeLists.txt?h=6.8.1#n182
> +	help
> +	  Graphical tool for designing and building Qt user interfaces
> +	  with a drag-and-drop editor.

Same question about the designer. What would you want to have Qt
Designer on the target, in the context of Buildroot? That you might
want it on the host, why not, but on the target? Or does this option
actually builds it for the host, despite qt6tools being a target
package?

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 4/6] package/qt6/qt6tools: fix assistant build failure

[Thomas Petazzoni via buildroot]

Hello Roy,

On Sun,  1 Jun 2025 12:12:58 +0200
Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:

> +config BR2_PACKAGE_QT6TOOLS_ASSISTANT
> +	bool "assistant"
> +	select BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT # qhelpgenerator
> +	select BR2_PACKAGE_QT6BASE_GUI
> +	select BR2_PACKAGE_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_QT6BASE_PRINTSUPPORT # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
> +	select BR2_PACKAGE_QT6BASE_SQL # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
> +	select BR2_PACKAGE_QT6BASE_SQLITE # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_QT6BASE_WIDGETS # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	help
> +	  Viewer for Qt help files (.qch), providing searchable and
> +	  navigable documentation for Qt and custom projects.

Same question: why would we want this on the target at all?


>  if BR2_PACKAGE_HOST_QT6TOOLS
>  
> +config BR2_PACKAGE_HOST_QT6TOOLS_ASSISTANT
> +	bool "host assistant"
> +	select BR2_PACKAGE_HOST_QT6BASE_GUI
> +	select BR2_PACKAGE_HOST_QT6BASE_NETWORK # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_HOST_QT6BASE_PNG # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_HOST_QT6BASE_PRINTSUPPORT # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
> +	select BR2_PACKAGE_HOST_QT6BASE_SQL # https://code.qt.io/cgit/qt/qttools.git/tree/src/assistant/CMakeLists.txt?h=6.8.1#n4
> +	select BR2_PACKAGE_HOST_QT6BASE_SQLITE # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	select BR2_PACKAGE_HOST_QT6BASE_WIDGETS # https://code.qt.io/cgit/qt/qttools.git/tree/configure.cmake?h=6.8.1#n45
> +	help
> +	  Viewer for Qt help files (.qch), providing searchable and
> +	  navigable documentation for Qt and custom projects.

And even on the host. What is the use-case for this in the context of
Buildroot?

If there's no use-case and you don't need it, better keep it
unconditionally disabled and save some complexity.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH v2 2/6] package/qt6/qt6tools: fix linguist build failure

[Roy Kollen Svendsen]

[-- Attachment #1.1: Type: text/plain, Size: 2206 bytes --]

You are right. There is probably little use for some of the qt6tools stuff
on both target and host.

That was the reason i rebooted the qt6tools in the original version of the
patchset.

At a point I decided to fix the existing problems, rather than removing
unneeded functionality.

But now that I'ts clear what the problems were, I agree that we can
unconditionally disable some of these options.

I'll do that now.


søn. 1. juni 2025 kl. 12:38 skrev Thomas Petazzoni <
thomas.petazzoni@bootlin.com>:

> Hello Roy,
>
> On Sun,  1 Jun 2025 12:12:56 +0200
> Roy Kollen Svendsen <roykollensvendsen@gmail.com> wrote:
>
> > Fixes:
> > -- Could NOT find Qt6LinguistTools (missing: Qt6LinguistTools_DIR)
> > CMake Error at
> <...>/output/build/qt6base-6.8.1/cmake/QtToolHelpers.cmake:768 (message):
> >   Failed to find the host tool "Qt6::lconvert".  It is part of the
> >   Qt6LinguistTools package, but the package could not be found.  Make
> sure
> >   you have built and installed the host Linguist module, which will
> ensure
> >   the creation of the Qt6LinguistTools package.
> > Call Stack (most recent call first):
> >   <...>/output/build/qt6base-6.8.1/cmake/QtToolHelpers.cmake:83
> (qt_internal_find_tool)
> >   src/linguist/lconvert/CMakeLists.txt:9 (qt_internal_add_tool)
> >
> > The above error can be triggered by the following defconfig:
> > BR2_arm=y
> > BR2_cortex_a9=y
> > BR2_ARM_ENABLE_VFP=y
> > BR2_TOOLCHAIN_EXTERNAL=y
> > BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
> > BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_MUSL_STABLE=y
> > BR2_PACKAGE_QT6=y
> > BR2_PACKAGE_QT6BASE_GUI=y
> > BR2_PACKAGE_QT6BASE_PNG=y
> > BR2_PACKAGE_QT6BASE_WIDGETS=y
> > BR2_PACKAGE_QT6TOOLS=y
> >
> > Signed-off-by: Roy Kollen Svendsen <roykollensvendsen@gmail.com>
>
> Thanks for the new iteration. However is Qt Linguist really a tool that
> would be useful on the target? Isn't this a GUI tool used during
> development, so something totally useless on the target, and that we
> could disable unconditionally?
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
>

[-- Attachment #1.2: Type: text/html, Size: 3025 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot