Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: ibai.erkiaga-elorza@amd.com, buildroot@buildroot.org,
	brandon.maier@collins.com, ju.o@free.fr,
	thomas.petazzoni@bootlin.com, romain.naour@smile.fr,
	michal.simek@amd.com
Subject: Re: [Buildroot] [PATCH v2 1/1] package/bootgen: Re-apply fix build on machines with modern flex
Date: Wed, 4 Jun 2025 09:36:17 +0200	[thread overview]
Message-ID: <20250604093617.3ceede2f@booty> (raw)
In-Reply-To: <20250603134812.2883296-1-neal.frager@amd.com>

On Tue, 3 Jun 2025 14:48:12 +0100
Neal Frager <neal.frager@amd.com> wrote:

> With bootgen 2025.1, the directory structure was re-done.  In the process of
> doing this, the source files in the bisonflex directory lost the fix below
> which had been applied on an earlier version of bootgen for the issue below.
> 
> Bootgen embeds an old version of flex, but uses the system include syntax
> (#include <>) to reference it, causing conflicts on systems with the
> development headers for a modern flex version installed, leading to build
> issues like:
> 
> ../bisonflex/bif.yy.cpp: In member function 'virtual int BIF::FlexScanner::yylex()':
> ../bisonflex/bif.yy.cpp:1608:18: error: no match for 'operator=' (operand types are 'std::istream' {aka 'std::basic_istream'} and 'std::istream*' {aka 'std::basic_istream*'})
> 
> Fix it by using normal local #include statements by:
> 
> sed -i 's/<FlexLexer.h>/"FlexLexer.h"/g' *
> 
> This patch re-adds the patch to fix this to buildroot.
> 
> Fixes: https://autobuild.buildroot.org/results/056384322246877253cd8d0781717ce495cbe769/
> Upstream: patch submitted to AMD internal jira process
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>

Note this is for next, where the version bump is.

Reviewed-By: Luca Ceresoli <luca.ceresoli@bootlin.com>

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-06-04  7:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-03 13:48 [Buildroot] [PATCH v2 1/1] package/bootgen: Re-apply fix build on machines with modern flex Neal Frager via buildroot
2025-06-04  7:36 ` Luca Ceresoli via buildroot [this message]
2025-06-09 22:10 ` Julien Olivain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250604093617.3ceede2f@booty \
    --to=buildroot@buildroot.org \
    --cc=brandon.maier@collins.com \
    --cc=ibai.erkiaga-elorza@amd.com \
    --cc=ju.o@free.fr \
    --cc=luca.ceresoli@bootlin.com \
    --cc=michal.simek@amd.com \
    --cc=neal.frager@amd.com \
    --cc=romain.naour@smile.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox