Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: ibai.erkiaga-elorza@amd.com, buildroot@buildroot.org,
	brandon.maier@collins.com, ju.o@free.fr,
	thomas.petazzoni@bootlin.com, romain.naour@smile.fr,
	michal.simek@amd.com, romain.naour@gmail.com
Subject: Re: [Buildroot] [PATCH v2 2/2] board/zynqmp: add custom board documentation
Date: Wed, 18 Jun 2025 14:11:09 +0200	[thread overview]
Message-ID: <20250618141109.3dff0c99@booty> (raw)
In-Reply-To: <20250617141534.2074877-2-neal.frager@amd.com>

On Tue, 17 Jun 2025 15:15:34 +0100
Neal Frager <neal.frager@amd.com> wrote:

> The readme.txt file for zynqmp boards does not have documentation for working
> with custom boards.  This patch adds documentation for custom board support.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
> V1->V2:
> - correct copy paste error as the output directory of step 3 should be:
>     output/build/uboot-custom/board/xilinx/zynqmp/custom_hw_platform/
>   and not:
>     output/build/uboot-custom/board/xilinx/zynq/custom_hw_platform/
> ---
>  board/zynqmp/readme.txt | 41 +++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
> 
> diff --git a/board/zynqmp/readme.txt b/board/zynqmp/readme.txt
> index 3f1b3a80c2..a98ff78f6f 100644
> --- a/board/zynqmp/readme.txt
> +++ b/board/zynqmp/readme.txt
> @@ -65,6 +65,47 @@ Where 'sdX' is the device node of the SD.
>  
>  Eject the SD card, insert it in the board, and power it up.
>  
> +Support for other boards:
> +=========================
> +
> +If you want to build a system for other boards based on the same SoC, and the
> +board is already supported by the upstream kernel and U-Boot, you simply need
> +to change the following Buildroot options:
> +
> + - Kernel Device Tree file name (BR2_LINUX_KERNEL_INTREE_DTS_NAME)
> + - U-Boot (BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=<dts file name>")
> +
> +Custom psu_init_gpl.c/h support:
> +
> +To generate a working boot.bin image, psu_init_gpl.c/h are required in
> +the U-Boot source tree. Without those files, boot.bin will be built
> +successfully but it will not be functional at all. Those files are
> +output from the Xilinx tools, but for convenience, U-Boot includes the
> +default psu_init_gpl.c/h of popular boards. Those files may need to be
> +updated for any programmable logic or DDR customizations which impact
> +psu_init (clock/pin setup & mapping/AXI bridge setup/etc). See
> +board/xilinx/zynqmp/ directory of U-Boot for natively supported psu_init
> +files. If the psu_init files for your board are not found in U-Boot,
> +you need to add them by yourself.
> +
> +1) Start with a defconfig supported by Buildroot (e.g. ZCU106)
> +    make zynqmp_zcu106_defconfig
> +
> +2) make uboot-menuconfig
> +    Visit the following menu and enable CONFIG_XILINX_PS_INIT_FILE
> +
> +    ARM architecture  --->
> +       [*] Zynq/ZynqMP PS init file(s) location

CONFIG_XILINX_PS_INIT_FILE is a string, not a bool. But this might be
irrelevant, see below.

> +3) Copy psu_init_gpl.c/h generated by the Xilinx Vivado tools into
> +   output/build/uboot-custom/board/xilinx/zynqmp/custom_hw_platform/

Ain't this automated in Buildroot by
BR2_TARGET_UBOOT_ZYNQMP_PSU_INIT_FILE? There should be no manual step
needed. Am I missing something?

> +4) make
> +
> +Note: The files in step 3 will need to be re-copied after cleaning the
> +output directory and at this time, there is no way to save them as
> +part of the buildroot configuration, except as a U-Boot patch.

If such manual step were needed, that would be a huge hole in Buildroot
that needs to be fixed.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-06-18 12:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-17 14:15 [Buildroot] [PATCH v2 1/2] board/zynq: update custom board documentation Neal Frager via buildroot
2025-06-17 14:15 ` [Buildroot] [PATCH v2 2/2] board/zynqmp: add " Neal Frager via buildroot
2025-06-18 12:11   ` Luca Ceresoli via buildroot [this message]
2025-06-18 12:42     ` Frager, Neal via buildroot
2025-06-17 19:08 ` [Buildroot] [PATCH v2 1/2] board/zynq: update " Julien Olivain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250618141109.3dff0c99@booty \
    --to=buildroot@buildroot.org \
    --cc=brandon.maier@collins.com \
    --cc=ibai.erkiaga-elorza@amd.com \
    --cc=ju.o@free.fr \
    --cc=luca.ceresoli@bootlin.com \
    --cc=michal.simek@amd.com \
    --cc=neal.frager@amd.com \
    --cc=romain.naour@gmail.com \
    --cc=romain.naour@smile.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox