Re: [Buildroot] [PATCH] package/bctoolbox: disable mbedtls support

[Thomas Perale via buildroot <buildroot@buildroot.org>]

Hi Thomas,

In reply of:
> Since mbedtls was bumped to version 3.6.3.1 in commit
> 3481a9643fc7223e400ed877f08ade34d44e6b78, the build of bctoolbox fails
> as its mbedtls support is not compatible with mbedtls 3.x.
> 
> This issue is known upstream:
> 
>   https://github.com/BelledonneCommunications/bctoolbox/issues/19
> 
> and is not fixed, even in newer version of bctoolbox. So for the time
> being, simply disable mbedtls support in bctoolbox.
> 
> Fixes:
> 
>   https://autobuild.buildroot.org/results/7af784cb60b0ec5e5bd0e0915ce6827f69f4bb97/
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

They did add support for mbedtls 3.6 in commit [1]. I would prefer to not
deprecate it on the LTS branch so I tried to bump to the latest version but I
get the following error linked to mbedtls:

crypto/mbedtls.cc: In constructor ‘bctoolbox::{anonymous}::mbedtlsStaticContexts::mbedtlsStaticContexts()’:
crypto/mbedtls.cc:83:17: error: ‘mbedtls_threading_set_alt’ was not declared in this scope; did you mean ‘mbedtls_threading_mutex_t’?
   83 |                 mbedtls_threading_set_alt(threading_mutex_init_cpp, threading_mutex_free_cpp, threading_mutex_lock_cpp,
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                 mbedtls_threading_mutex_t
crypto/mbedtls.cc: In destructor ‘bctoolbox::{anonymous}::mbedtlsStaticContexts::~mbedtlsStaticContexts()’:
crypto/mbedtls.cc:95:17: error: ‘mbedtls_threading_free_alt’ was not declared in this scope; did you mean ‘mbedtls_threading_mutex_t’?
   95 |                 mbedtls_threading_free_alt();
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 mbedtls_threading_mutex_t

If anyone could look into this, I would appreciate it. I tried to change the
mbedtls_config.h to enable the ALT threading function but without success.

This package and mongrel2 are the last packages that doesn't have compat with
mbedtls 3.6.
For mongrel2 though the package is not maintained anymore and there isn't any
port upstream.

[1] https://github.com/BelledonneCommunications/bctoolbox/commit/e0ee04a21eb15d6f4a22b2dd1a4599cd3492e5d7

Regards,
Thomas

> ---
> Note: the bctoolbox has no maintainer in the DEVELOPERS file, and
> hasn't been bumped since November 2020, despite upstream having
> released multiple versions. Candidate for removal?
> ---
>  package/bctoolbox/bctoolbox.mk | 14 ++++++--------
>  1 file changed, 6 insertions(+), 8 deletions(-)
> 
> diff --git a/package/bctoolbox/bctoolbox.mk b/package/bctoolbox/bctoolbox.mk
> index ac9361026f..db545311fd 100644
> --- a/package/bctoolbox/bctoolbox.mk
> +++ b/package/bctoolbox/bctoolbox.mk
> @@ -12,25 +12,23 @@ BCTOOLBOX_INSTALL_STAGING = YES
>  
>  # Set CMAKE_SKIP_RPATH to prevent bctoolbox from adding the rpath to
>  # shared library.
> +
> +# We have to disable mbedtls support even though we have a mbedtls
> +# package because bctoolbox is not compatible with mbedtls 3.x as of
> +# version 4.4.8.
>  BCTOOLBOX_CONF_OPTS = \
>  	-DENABLE_POLARSSL=OFF \
>  	-DENABLE_STRICT=OFF \
>  	-DENABLE_TESTS_COMPONENT=OFF \
>  	-DENABLE_TESTS=OFF \
> -	-DCMAKE_SKIP_RPATH=ON
> +	-DCMAKE_SKIP_RPATH=ON \
> +	-DENABLE_MBEDTLS=OFF
>  
>  ifeq ($(BR2_PACKAGE_LIBICONV),y)
>  BCTOOLBOX_DEPENDENCIES += libiconv
>  BCTOOLBOX_CONF_OPTS += -DCMAKE_CXX_FLAGS="$(TARGET_CXXFLAGS) -liconv"
>  endif
>  
> -ifeq ($(BR2_PACKAGE_MBEDTLS),y)
> -BCTOOLBOX_DEPENDENCIES += mbedtls
> -BCTOOLBOX_CONF_OPTS += -DENABLE_MBEDTLS=ON
> -else
> -BCTOOLBOX_CONF_OPTS += -DENABLE_MBEDTLS=OFF
> -endif
> -
>  ifeq ($(BR2_STATIC_LIBS),y)
>  BCTOOLBOX_CONF_OPTS += -DENABLE_SHARED=OFF -DENABLE_STATIC=ON
>  else ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> -- 
> 2.49.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot