public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C
@ 2025-07-11 12:05 Heiko Thiery
  2025-07-11 12:05 ` [Buildroot] [PATCH] package/linux-firmware: add support for PowerVR rogue Heiko Thiery
  2025-07-12 11:50 ` [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C Julien Olivain via buildroot
  0 siblings, 2 replies; 4+ messages in thread
From: Heiko Thiery @ 2025-07-11 12:05 UTC (permalink / raw)
  To: buildroot; +Cc: Bernd Kuhls, Michael Walle, Bryan Brattlof, Heiko Thiery

Add an option to install the firmware files for Chips&Media Wave 521C
video processor used in the TI K3 architecture.

This "cnm/wave521c_k3_codec_fw.bin" file has been present in linux-firmware
since version 20221109.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 package/linux-firmware/Config.in         | 6 ++++++
 package/linux-firmware/linux-firmware.mk | 5 +++++
 2 files changed, 11 insertions(+)

diff --git a/package/linux-firmware/Config.in b/package/linux-firmware/Config.in
index 54910df6fd..778dfef8a0 100644
--- a/package/linux-firmware/Config.in
+++ b/package/linux-firmware/Config.in
@@ -33,6 +33,12 @@ config BR2_PACKAGE_LINUX_FIRMWARE_AMDGPU
 	help
 	  Firmware files for AMD GPU video cards.
 
+config BR2_PACKAGE_LINUX_FIRMWARE_CNM_WAVE521C_K3_CODEC
+	bool "Chips&Media Wave 521C codec IP for K3"
+	help
+	  Firmware files for the Chips&Media Wave521C decoder
+	  needed by the Linux TI j721s2-wave521c driver.
+
 config BR2_PACKAGE_LINUX_FIRMWARE_I915
 	bool "Intel i915 video card firmware"
 	help
diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index b9fd471e85..904c14ba10 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -25,6 +25,11 @@ LINUX_FIRMWARE_DIRS += amdgpu
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.amdgpu
 endif
 
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_CNM_WAVE521C_K3_CODEC),y)
+LINUX_FIRMWARE_FILES += cnm/wave521c_k3_codec_fw.bin
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.cnm
+endif
+
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_I915),y)
 LINUX_FIRMWARE_DIRS += i915
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.i915
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] package/linux-firmware: add support for PowerVR rogue
  2025-07-11 12:05 [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C Heiko Thiery
@ 2025-07-11 12:05 ` Heiko Thiery
  2025-07-12 11:53   ` Julien Olivain via buildroot
  2025-07-12 11:50 ` [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C Julien Olivain via buildroot
  1 sibling, 1 reply; 4+ messages in thread
From: Heiko Thiery @ 2025-07-11 12:05 UTC (permalink / raw)
  To: buildroot; +Cc: Bernd Kuhls, Michael Walle, Bryan Brattlof, Heiko Thiery

This "powervr" directory has been present in linux-firmware since
version 20231211.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
 package/linux-firmware/Config.in         | 5 +++++
 package/linux-firmware/linux-firmware.mk | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/package/linux-firmware/Config.in b/package/linux-firmware/Config.in
index 34f3fb7691..54910df6fd 100644
--- a/package/linux-firmware/Config.in
+++ b/package/linux-firmware/Config.in
@@ -729,6 +729,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_ARM_MALI_CSF
 	  Firmware files for Arm Mali 10th generation GPU
 	  needed by the linux panthor kernel driver.
 
+config BR2_PACKAGE_LINUX_FIRMWARE_POWERVR_ROGUE
+	bool "PowerVR Technologies Rogue GPU firmware"
+	help
+	  Firmware files for PowerVR Technologies Rogue video cards.
+
 endmenu
 
 menu "Serial adapters firmware"
diff --git a/package/linux-firmware/linux-firmware.mk b/package/linux-firmware/linux-firmware.mk
index 38212e12ac..b9fd471e85 100644
--- a/package/linux-firmware/linux-firmware.mk
+++ b/package/linux-firmware/linux-firmware.mk
@@ -931,6 +931,11 @@ LINUX_FIRMWARE_FILES += arm/mali/arch*/mali_csffw.bin
 LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.mali_csffw
 endif
 
+ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_POWERVR_ROGUE),y)
+LINUX_FIRMWARE_DIRS += powervr
+LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.powervr
+endif
+
 ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RP2),y)
 LINUX_FIRMWARE_FILES += rp2.fw
 endif
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C
  2025-07-11 12:05 [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C Heiko Thiery
  2025-07-11 12:05 ` [Buildroot] [PATCH] package/linux-firmware: add support for PowerVR rogue Heiko Thiery
@ 2025-07-12 11:50 ` Julien Olivain via buildroot
  1 sibling, 0 replies; 4+ messages in thread
From: Julien Olivain via buildroot @ 2025-07-12 11:50 UTC (permalink / raw)
  To: Heiko Thiery; +Cc: buildroot, Bernd Kuhls, Michael Walle, Bryan Brattlof

Hi Heiko,

Thanks for the patch.

On 11/07/2025 14:05, Heiko Thiery wrote:
> Add an option to install the firmware files for Chips&Media Wave 521C
> video processor used in the TI K3 architecture.
> 
> This "cnm/wave521c_k3_codec_fw.bin" file has been present in 
> linux-firmware
> since version 20221109.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
>  package/linux-firmware/Config.in         | 6 ++++++
>  package/linux-firmware/linux-firmware.mk | 5 +++++
>  2 files changed, 11 insertions(+)
> 
> diff --git a/package/linux-firmware/Config.in 
> b/package/linux-firmware/Config.in
> index 54910df6fd..778dfef8a0 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -33,6 +33,12 @@ config BR2_PACKAGE_LINUX_FIRMWARE_AMDGPU
>  	help
>  	  Firmware files for AMD GPU video cards.
> 
> +config BR2_PACKAGE_LINUX_FIRMWARE_CNM_WAVE521C_K3_CODEC
> +	bool "Chips&Media Wave 521C codec IP for K3"
> +	help
> +	  Firmware files for the Chips&Media Wave521C decoder
> +	  needed by the Linux TI j721s2-wave521c driver.
> +
>  config BR2_PACKAGE_LINUX_FIRMWARE_I915
>  	bool "Intel i915 video card firmware"
>  	help
> diff --git a/package/linux-firmware/linux-firmware.mk 
> b/package/linux-firmware/linux-firmware.mk
> index b9fd471e85..904c14ba10 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -25,6 +25,11 @@ LINUX_FIRMWARE_DIRS += amdgpu
>  LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.amdgpu
>  endif
> 
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_CNM_WAVE521C_K3_CODEC),y)
> +LINUX_FIRMWARE_FILES += cnm/wave521c_k3_codec_fw.bin
> +LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.cnm

Running "make linux-firmware-legal-info" with this firmware selected
fails with error:

     cp: cannot stat 
'/buildroot/output/build/linux-firmware-20250627/LICENSE.cnm': No such 
file or directory

This is because the license file is named LICENCE.cnm
(with 'C' instead of 'S'). See:
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/LICENCE.cnm?h=20250627

Also, there is a warning that there is no hash for that file. Could
you make to also add the hash for this new file, please? In:
https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/linux-firmware/linux-firmware.hash

> +endif
> +
>  ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_I915),y)
>  LINUX_FIRMWARE_DIRS += i915
>  LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.i915
> --
> 2.39.5

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/linux-firmware: add support for PowerVR rogue
  2025-07-11 12:05 ` [Buildroot] [PATCH] package/linux-firmware: add support for PowerVR rogue Heiko Thiery
@ 2025-07-12 11:53   ` Julien Olivain via buildroot
  0 siblings, 0 replies; 4+ messages in thread
From: Julien Olivain via buildroot @ 2025-07-12 11:53 UTC (permalink / raw)
  To: Heiko Thiery; +Cc: buildroot, Bernd Kuhls, Michael Walle, Bryan Brattlof

Hi Heiko,

Thanks for the patch.

On 11/07/2025 14:05, Heiko Thiery wrote:
> This "powervr" directory has been present in linux-firmware since
> version 20231211.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
>  package/linux-firmware/Config.in         | 5 +++++
>  package/linux-firmware/linux-firmware.mk | 5 +++++
>  2 files changed, 10 insertions(+)
> 
> diff --git a/package/linux-firmware/Config.in 
> b/package/linux-firmware/Config.in
> index 34f3fb7691..54910df6fd 100644
> --- a/package/linux-firmware/Config.in
> +++ b/package/linux-firmware/Config.in
> @@ -729,6 +729,11 @@ config BR2_PACKAGE_LINUX_FIRMWARE_ARM_MALI_CSF
>  	  Firmware files for Arm Mali 10th generation GPU
>  	  needed by the linux panthor kernel driver.
> 
> +config BR2_PACKAGE_LINUX_FIRMWARE_POWERVR_ROGUE
> +	bool "PowerVR Technologies Rogue GPU firmware"
> +	help
> +	  Firmware files for PowerVR Technologies Rogue video cards.
> +
>  endmenu
> 
>  menu "Serial adapters firmware"
> diff --git a/package/linux-firmware/linux-firmware.mk 
> b/package/linux-firmware/linux-firmware.mk
> index 38212e12ac..b9fd471e85 100644
> --- a/package/linux-firmware/linux-firmware.mk
> +++ b/package/linux-firmware/linux-firmware.mk
> @@ -931,6 +931,11 @@ LINUX_FIRMWARE_FILES += 
> arm/mali/arch*/mali_csffw.bin
>  LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENCE.mali_csffw
>  endif
> 
> +ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_POWERVR_ROGUE),y)
> +LINUX_FIRMWARE_DIRS += powervr
> +LINUX_FIRMWARE_ALL_LICENSE_FILES += LICENSE.powervr

Running "make linux-firmware-legal-info" with this firmware selected
generates a warning/error:

     ERROR: No hash found for LICENSE.powervr

Could you add the hash for this new file, please? In:
https://gitlab.com/buildroot.org/buildroot/-/blob/master/package/linux-firmware/linux-firmware.hash


> +endif
> +
>  ifeq ($(BR2_PACKAGE_LINUX_FIRMWARE_RP2),y)
>  LINUX_FIRMWARE_FILES += rp2.fw
>  endif
> --
> 2.39.5

Could you send an updated patch series, please?

Best regards,

Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-07-12 11:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-11 12:05 [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C Heiko Thiery
2025-07-11 12:05 ` [Buildroot] [PATCH] package/linux-firmware: add support for PowerVR rogue Heiko Thiery
2025-07-12 11:53   ` Julien Olivain via buildroot
2025-07-12 11:50 ` [Buildroot] [PATCH] package/linux-firmware: add option for Chips&Media Wave 521C Julien Olivain via buildroot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox