Re: [Buildroot] [v1,1/1] package/zellij: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Alexander Shirokov <shirokovalexs@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [v1,1/1] package/zellij: new package
Date: Mon, 28 Jul 2025 22:44:14 +0200	[thread overview]
Message-ID: <20250728224414.6d0833d2@windsurf> (raw)
In-Reply-To: <20250728131926.848832-1-shirokovalexs@gmail.com>

Hello Alexander,

On Mon, 28 Jul 2025 15:19:26 +0200
Alexander Shirokov <shirokovalexs@gmail.com> wrote:

> An advanced terminal multiplexer with batteries included. Supports
> layouts, floating and stacked panes, plugins, and customization.
> Provides rich functionality out of the box.
> 
> Zellij is aimed at developers, operations-oriented users, and anyone who
> loves the terminal.
> 
> https://github.com/zellij-org/zellij
> 
> Signed-off-by: Alexander Shirokov <shirokovalexs@gmail.com>

Thanks for your contribution.

> ---
>  package/Config.in          |  1 +
>  package/zellij/Config.in   | 15 +++++++++++++++
>  package/zellij/zellij.hash |  3 +++
>  package/zellij/zellij.mk   | 12 ++++++++++++
>  4 files changed, 31 insertions(+)

All new packages need an entry in the DEVELOPERS file, could you add
one?

> diff --git a/package/zellij/Config.in b/package/zellij/Config.in
> new file mode 100644
> index 0000000000..24383511ce
> --- /dev/null
> +++ b/package/zellij/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_ZELLIJ
> +	bool "zellij"
> +	depends on BR2_x86_64 || BR2_x86_i686 || BR2_aarch64

Is there really something architecture-specific in zellij?

> +	depends on BR2_PACKAGE_HOST_RUSTC
> +	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
> +	help
> +

This blank line should be dropped.

> diff --git a/package/zellij/zellij.mk b/package/zellij/zellij.mk
> new file mode 100644
> index 0000000000..b015991aab
> --- /dev/null
> +++ b/package/zellij/zellij.mk
> @@ -0,0 +1,12 @@
> +################################################################################
> +#
> +# zellij
> +#
> +################################################################################
> +
> +ZELLIJ_VERSION = v0.42.2
> +ZELLIJ_SITE = $(call github,zellij-org,zellij,$(ZELLIJ_VERSION))

This should be:

ZELLIJ_VERSION = 0.42.2
ZELLIJ_SITE = $(call github,zellij-org,zellij,v$(ZELLIJ_VERSION))

i.e, the version field should not contain the "v" prefix, so that the
version number can be matched against CVE reports, against
release-monitoring.org, etc.

Could you adjust those details and send a v2?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot