Re: [Buildroot] [PATCH v2] package/libxmlrpc: fix boolean definitions

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: yegorslists--- via buildroot <buildroot@buildroot.org>
Cc: "Alvaro G . M" <alvaro.gamez@hazent.com>
Subject: Re: [Buildroot] [PATCH v2] package/libxmlrpc: fix boolean definitions
Date: Mon, 28 Jul 2025 22:56:22 +0200	[thread overview]
Message-ID: <20250728225622.13378e9f@windsurf> (raw)
In-Reply-To: <20250725120743.3705187-1-yegorslists@googlemail.com>

Hello,

On Fri, 25 Jul 2025 14:07:43 +0200
yegorslists--- via buildroot <buildroot@buildroot.org> wrote:

> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Don't define boolean macros for C23 standard as they are implemented
> as keywords.
> 
> Fixes the following error:
> 
> make[2]: Entering directory
> '/home/user/Documents/versioned/oss/xmlrpc-c/lib/util'
> gcc -c -DNDEBUG -pthread -Wall -W -Wno-uninitialized -Wundef
> -Wno-unknown-pragmas -Wmissing-declarations -Wstrict-prototypes
> -Wmissing-prototypes -Wimplicit -fno-common -g -O3
> -Isrcdir/lib/util/include
> -I/home/user/Documents/versioned/oss/xmlrpc-c   casprintf.c
> In file included from casprintf.c:9:
> srcdir/lib/util/include/bool.h:13:5: error: cannot use keyword ‘false’
> as enumeration constant
>    13 |     false = 0,
>       |     ^~~~~
> srcdir/lib/util/include/bool.h:13:5: note: ‘false’ is a keyword with
> ‘-std=c23’ onwards
> srcdir/lib/util/include/bool.h:15:3: error: expected ‘;’, identifier
> or ‘(’ before ‘bool’
>    15 | } bool;
>       |   ^~~~
> srcdir/lib/util/include/bool.h:15:3: warning: useless type name in
> empty declaration
> 
> Upstream: https://sourceforge.net/p/xmlrpc-c/code/3318/
> 
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Thanks, looks good.

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Shouldn't we try to update (separately)? Apparently we're still using:

# 1.60.01 (code/advanced@r3176)
LIBXMLRPC_VERSION = r3176

But there's a new 1.60.05 according to
https://xmlrpc-c.sourceforge.io/change_super_stable.html:

Release 1.60.05

Released 25.03.28

    Fix crash when memory allocation fails in XML parsing, when built to use libxml2 XML parser. Broken in Xmlrpc-c 1.57 (December 2019).
    Build: fix failure to install interface header files when using separate build directory. 

Maybe we should use it?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot