From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Romain Naour <romain.naour@smile.fr>
Cc: "Thomas Bonnefille" <thomas.bonnefille@bootlin.com>,
buildroot@buildroot.org,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Wade Berrier" <wberrier@gmail.com>,
"Florian Weimer" <fweimer@redhat.com>
Subject: Re: [Buildroot] [PATCH] package/ngrep: fix implicit function declaration
Date: Sun, 10 Aug 2025 12:49:04 +0200 [thread overview]
Message-ID: <20250810124904.2d77ac82@windsurf> (raw)
In-Reply-To: <bb6b38a0-ef8b-4e52-8934-7813994da85e@smile.fr>
Hello Romain,
Thanks for the review, but something is not clear. See below.
On Sat, 9 Aug 2025 23:52:55 +0200
Romain Naour <romain.naour@smile.fr> wrote:
> Hello Thomas, All,
>
> Le 02/08/2025 à 13:37, Thomas Bonnefille via buildroot a écrit :
> > Fixes: https://autobuild.buildroot.org/results/20b/20b924c5c96b3f43e381d87e59fb160ba8d3dcd0//
>
> Please, can you provide your analysis on this issue?
>
> From the patch, I understand that it's an error generated by gcc-14 (an newer).
> But ngrep package fail to build only when BR2_PACKAGE_LIBNET is selected.
So you ask for more details (which would encourage the submitter to
send a new version of the patch)...
> I updated the commit log with a defconfig and the minimal gcc version to
> reproduce the issue.
... but you say you have already updated the commit log with more
details. So? Did you already apply the patch and sending a new
iteration is not needed, or?
Thanks!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-08-10 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-02 11:37 [Buildroot] [PATCH] package/ngrep: fix implicit function declaration Thomas Bonnefille via buildroot
2025-08-02 20:03 ` Thomas Perale via buildroot
2025-08-09 21:52 ` Romain Naour via buildroot
2025-08-10 10:49 ` Thomas Petazzoni via buildroot [this message]
2025-08-10 13:27 ` Romain Naour via buildroot
2025-08-14 20:31 ` Thomas Perale via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250810124904.2d77ac82@windsurf \
--to=buildroot@buildroot.org \
--cc=fweimer@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=romain.naour@smile.fr \
--cc=thomas.bonnefille@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wberrier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox