Re: [Buildroot] [PATCH v3 1/1] boot/xilinx-embeddedsw: only allow apps for device family

[Luca Ceresoli via buildroot <buildroot@buildroot.org>]

Hi Yann,

On Wed, 13 Aug 2025 11:20:59 +0200
yann.morin@orange.com wrote:

> Neal, All,
> 
> On 2025-08-13 09:43 +0100, Neal Frager via buildroot spake thusly:
> > This patch adds an architecture cpu dependency to each application to make
> > sure that users can only build applications which are applicable to their
> > target device family.
> > 
> > The versal_plm and versal_psmfw applications are specific to versal devices
> > which are based on BR2_cortex_a72.
> > 
> > The zynqmp_pmufw application is specific to zynqmp devices which are based on
> > BR2_cortex_a53.
> > 
> > Signed-off-by: Neal Frager <neal.frager@amd.com>
> > ---
> > V1->V2:
> > - Replaced new family variant config option with an architecture cpu
> >   dependency, so no new configs are needed.
> > - Updated patch title and commit message accordingly.
> > V2->V3:
> > - Changed package dependency to only appear if the cpu is BR2_cortex_a53
> >   or BR2_cortex_a72. This way, the xilinx-embeddedsw package will not
> >   appear with zero application options if another BR2_aarch64 cpu is
> >   selected.
> > ---
> >  boot/xilinx-embeddedsw/Config.in | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/boot/xilinx-embeddedsw/Config.in b/boot/xilinx-embeddedsw/Config.in
> > index 0dd6433608..96e9ca2fb0 100644
> > --- a/boot/xilinx-embeddedsw/Config.in
> > +++ b/boot/xilinx-embeddedsw/Config.in
> > @@ -5,7 +5,7 @@ comment "xilinx-embeddedsw needs a bare metal toolchain for tuple microblazeel-b
> >  
> >  menuconfig BR2_TARGET_XILINX_EMBEDDEDSW
> >  	bool "xilinx-embeddedsw"
> > -	depends on BR2_aarch64
> > +	depends on BR2_cortex_a53 || BR2_cortex_a72  
> 
> Note that (BR2_cortex_a53 || BR2_cortex_a72) is not a subset of
> BR2_aarch64; they can each be select when the target is BR2_arm,
> BR2_armeb or BR2_aarch64_be.

Ah, thanks for pointing out! I was indeed assuming that (a53 || a72) is
a subset of aarch64, or maybe (aarch64 || aarch64_be).

> So if xilinx-embeddedsw really is AArch64-LE, then you need to keep
> the dependency on BR2_aarch64. If it's really just AArch64, then you can
> relax it with a dependency on BR2_ARCH_IS_64 (plus the individual CPUs,
> of course).

AFAIK all the impacted Xilinx SoCs are aarch64, this that would become:

  depends on BR2_aarch64 && (BR2_cortex_a53 || BR2_cortex_a72)

But I'll let Neal confirm or correct me.

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot