From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9747DCA0EE0 for ; Wed, 13 Aug 2025 14:42:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 671254093F; Wed, 13 Aug 2025 14:42:03 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Dv0dUpGy6gCa; Wed, 13 Aug 2025 14:42:02 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 686134090E Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 686134090E; Wed, 13 Aug 2025 14:42:02 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id 9F6C1938 for ; Wed, 13 Aug 2025 14:42:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 8572F40909 for ; Wed, 13 Aug 2025 14:42:01 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id EWkmdCmCbT5W for ; Wed, 13 Aug 2025 14:42:00 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:4b98:dc4:8::227; helo=relay7-d.mail.gandi.net; envelope-from=luca.ceresoli@bootlin.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 5234E408EF DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 5234E408EF Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by smtp4.osuosl.org (Postfix) with ESMTPS id 5234E408EF for ; Wed, 13 Aug 2025 14:42:00 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 31EDF4396F; Wed, 13 Aug 2025 14:41:56 +0000 (UTC) Date: Wed, 13 Aug 2025 16:41:54 +0200 To: "Frager, Neal" Cc: "yann.morin@orange.com" , "buildroot@buildroot.org" , "Erkiaga Elorza, Ibai" , "brandon.maier@collins.com" , "ju.o@free.fr" , "thomas.petazzoni@bootlin.com" , "romain.naour@smile.fr" , "Simek, Michal" , "romain.naour@gmail.com" Message-ID: <20250813164154.797c9077@booty> In-Reply-To: References: <20250813084354.2739722-1-neal.frager@amd.com> <20250813112755.63b17355@booty> <20250813153132.5942d8f7@booty> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddufeekgeekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpefnuhgtrgcuvegvrhgvshholhhiuceolhhutggrrdgtvghrvghsohhlihessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepvdehleevieduvefhuddvvdefvdfgveehveffueejffehueffveejhfejkeeuffegnecuffhomhgrihhnpehoiihlrggsshdrohhrghdpsghoohhtlhhinhdrtghomhenucfkphepvdgrtddvmeeijedtmedvtddvtdemvggrtddumegsvgegudemleehvgejmeefgeefmeeludefvgenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedvrgdtvdemieejtdemvddtvddtmegvrgdtudemsggvgedumeelhegvjeemfeegfeemledufegvpdhhvghlohepsghoohhthidpmhgrihhlfhhrohhmpehluhgtrgdrtggvrhgvshholhhisegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedutddprhgtphhtthhopehnvggrlhdrfhhrrghgvghrsegrmhgurdgtohhmpdhrtghpthhtohephigrnhhnrdhmohhrihhnsehorhgrnhhgvgdrtghomhdprhgtphhtthhopegsuhhilhgurhhoohhts egsuhhilhgurhhoohhtrdhorhhgpdhrtghpthhtohepihgsrghirdgvrhhkihgrghgrqdgvlhhorhiirgesrghmugdrtghomhdprhgtphhtthhopegsrhgrnhguohhnrdhmrghivghrsegtohhllhhinhhsrdgtohhmpdhrtghpthhtohepjhhurdhosehfrhgvvgdrfhhrpdhrtghpthhtohepthhhohhmrghsrdhpvghtrgiiiihonhhisegsohhothhlihhnrdgtohhmpdhrtghpthhtoheprhhomhgrihhnrdhnrghouhhrsehsmhhilhgvrdhfrh X-GND-Sasl: luca.ceresoli@bootlin.com X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1755096117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EW/P1VX9deVonKhLEWm30NjPiL0Dc1x4TaF3rrlWYhk=; b=CBYPK7emvduSMrwJq3oGh6+2L9rxZIxbIgEL5Lv960ZZJX+jnybJpUI8mbhsdZfOpI8f3M L7BCTxlDRGUe4rehlevc4A1jTRkdwx/NbUqrKYeGmeXGlRHtltTj/hDZf05dnvkTMVNRVC GEPZz5D+kWyEze8190aDtvQkj1sH999WPNiNZ+r6kCvGOc6z9SBE4vfAYWqy9myQUvdJuU rzMAFhjmlPsYveipbPg4py3PfrxP4Jd5lCFQweWNPfcQaBY4+MilJv0rI35upmOhCsGjLY S1m86wsbZrv4lPSCA2JSWOIBSZgqapmGKVJaB//XeVNZQoHvQOMffLLIZPZM5g== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=CBYPK7em Subject: Re: [Buildroot] [PATCH v3 1/1] boot/xilinx-embeddedsw: only allow apps for device family X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luca Ceresoli via buildroot Reply-To: Luca Ceresoli Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" On Wed, 13 Aug 2025 14:22:39 +0000 "Frager, Neal" wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Luca, > > > > > Hi Yann, > > > > [--SNIP--] > > > > When the dependency is not tricvial, I think it is good to introduce an > > > > intermediate symbol: > > > > config BR2_TARGET_XILINX_EMBEDDEDSW_ARCH_SUPPORTS > > [--SNIP--] > > > I see your point, but don't you think adding another symbol is still > > > a bit overkill? The dependencies are still only 3 lines and are rather > > > straight forward. > > > > > This would not be unheard of, there already are a few packages with very > > > few arch dependencies, but that still have a dedicated symbol, see for > > > example (some are more interesting, as they do have comments for each > > > dependency they carry): > > > - bayer2rgb-neon > > > - bitcoin > > > - bpftrace > > > - dpdk > > > - host-flutter-sdk-bin > > > - (host-)gdb > > > - gtkiostream > > > - ... and so on... > > > > > Note that we usually do that for libraries, so that it is easier to > > > inherit their dependencies in selecting packages, but of the above, > > > only two are libraries. > > > > > But maintainers will have to decide what they want. ;-) > > > > In the end, I changed my mind on the issue since there are two places where > > the arch dependency is used. The BR2_TARGET_XILINX_EMBEDDEDSW as well as the > > comment about the dependency needs. > > > > To avoid having the two be out of sync, it makes sense to create a > > symbol BR2_TARGET_XILINX_EMBEDDEDSW_ARCH_SUPPORTS that keeps all the arch > > dependencies in one place. This way, when I add BR2_cortex_a78 in the near > > future, I will only have one place to add it instead of two. > > > I agree this is a good idea. > > > However the same logic can apply to other Xilinx firmware and related > > packages, such as xilinx-prebuilt. Thus I'd rather create a single > > symbol that can be reused for both packages, and it should probably be > > in boot/Config.in. It should be also named without "EMBEDDEDSW", e.g. > > BR2_TARGET_XILINX_FIRMWARE_ARCH_SUPPORTS. > > > Side note: I personally don't recommend sending new iterations so > > quickly, without letting the discussion settle, it produces a lot of > > noise. I'd wait at least a few days after the latest e-mail in the > > discussion before sending a new version. > > Yes, you are right that we can create a global symbol in boot/Config.in called: > BR2_TARGET_XILINX_FIRMWARE_ARCH_SUPPORTS > > This symbol could be used for both xilinx-embeddedsw and xilinx-prebuilt. > > Not only would this enable us to only show the xilinx-prebuilt package as an > option when one of the correct cpus is selected, but we could also use the > BR2_cortex_a53 and BR2_cortex_a72 to limit the available choices in the > family variant selector. This would prevent selecting BR2_cortex_a72 and > having a zynqmp or kria xilinx-prebuilt family selection or vice versa. > > It would not change the need for having the family and board information > because the xilinx-prebuilt treats zynqmp and kria boards differently due to > the directory names where the pmufw.elf files are located even though these > are both based on BR2_cortex_a53. > > But at least creating a BR2_TARGET_XILINX_ARCH_SUPPORTS would put the arch > dependencies of Xilinx components in one place. We could even update the > uboot package BR2_TARGET_UBOOT_ZYNQMP symbol to be dependent on > BR2_TARGET_XILINX_FIRMWARE_ARCH_SUPPORTS instead of BR2_aarch64 as well. Sure. > The only exception would be the zynq platform. The BR2_TARGET_UBOOT_ZYNQ > symbol would stay dependent on BR2_arm because it is the only family that is > not an aarch64. I suppose I should add a BR2_cortex_a9 dependency to > BR2_TARGET_UBOOT_ZYNQ as well, so that it limits the option appearing even > more. > > https://patchwork.ozlabs.org/project/buildroot/patch/20250619153922.891360-1-neal.frager@amd.com/ That's true as well. If you do all of there, please keep them as separate commits in the series to be easier to review: - add BR2_TARGET_XILINX_FIRMWARE_ARCH_SUPPORTS - use BR2_TARGET_XILINX_FIRMWARE_ARCH_SUPPORTS in xilinx-embeddedsw - use BR2_TARGET_XILINX_FIRMWARE_ARCH_SUPPORTS in xilinx-prebuilt - use BR2_TARGET_XILINX_FIRMWARE_ARCH_SUPPORTS in uboot And the zynq7 changes are already a separate series, so I guess thay can stay separate. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot