Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Perale via buildroot <buildroot@buildroot.org>
Cc: Thomas Perale <thomas.perale@mind.be>,
	Kurt Van Dijck <dev.kurt@vandijck-laurijssen.be>
Subject: Re: [Buildroot] [PATCH] package/bcusdk: fix build w/ gcc-14
Date: Sat, 16 Aug 2025 22:47:30 +0200	[thread overview]
Message-ID: <20250816224730.466990e0@windsurf> (raw)
In-Reply-To: <20250812173616.1977078-1-thomas.perale@mind.be>

On Tue, 12 Aug 2025 19:36:16 +0200
Thomas Perale via buildroot <buildroot@buildroot.org> wrote:

> When using gcc-14 the compilation fails with the following error
> message:
> 
> ```
> close.c: In function 'EIBClose':
> close.c:38:3: error: implicit declaration of function 'close'; did you mean 'pclose'? [-Wimplicit-function-declaration]
>    38 |   close (con->fd);
>       |   ^~~~~
>       |   pclose
> openlocal.c: In function 'EIBSocketLocal':
> openlocal.c:57:7: error: implicit declaration of function 'close'; did you mean 'pclose'? [-Wimplicit-function-declaration]
>    57 |       close (con->fd);
>       |       ^~~~~
>       |       pclose
> make[6]: *** [Makefile:611: close.lo] Error 1
> ```
> 
> This patch include <unistd.h> to include the declaration of close.
> 
> Fixes: https://autobuild.buildroot.org/results/483/483fc4584815507c3798eb972e22e51f70f52c23/build-end.log
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>
> ---
>  ...include-unistd-for-close-declaration.patch | 70 +++++++++++++++++++
>  1 file changed, 70 insertions(+)
>  create mode 100644 package/bcusdk/0005-include-unistd-for-close-declaration.patch

Applied to master, thanks. However, I suggest that we drop this
package. It has been added in 2014 by someone working for a company
which no longer exists. The latest release is from 2011. Kurt, the
package maintainer, only every made two commits to it, back in 2017.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2025-08-16 20:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-12 17:36 [Buildroot] [PATCH] package/bcusdk: fix build w/ gcc-14 Thomas Perale via buildroot
2025-08-16 20:47 ` Thomas Petazzoni via buildroot [this message]
2025-08-21 19:20 ` Thomas Perale via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250816224730.466990e0@windsurf \
    --to=buildroot@buildroot.org \
    --cc=dev.kurt@vandijck-laurijssen.be \
    --cc=thomas.perale@mind.be \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox