Re: [Buildroot] [PATCH 1/2] package/prboom: fix build w/ gcc-14

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Tue, 12 Aug 2025 19:18:24 +0200
Thomas Perale via buildroot <buildroot@buildroot.org> wrote:

> When building prboom with gcc-14 the following error appeared on the
> autobuilder:
> 
> ```
> i_main.c: In function 'main':
> i_main.c:359:10: error: assignment to 'const char * const*' from incompatible pointer type 'char **' [-Wincompatible-pointer-types]
>   359 |   myargv = argv;
>       |          ^
> ```
> 
> While this package did not receive any update for a while on the
> sourceforge mirror, I backported the fix from a fork. For more
> information see [1].
> 
> [1] https://github.com/coelckers/prboom-plus/commit/92d44b6383a3e053feac2c820b8114873fcd798e
> 
> Fixes: https://autobuild.buildroot.org/results/888/88846e3cb267b04da58bc17d92fd5dd385b65b5d
> Signed-off-by: Thomas Perale <thomas.perale@mind.be>
> ---
>  ...v-instead-of-const-char-const-myargv.patch | 140 ++++++++++++++++++
>  1 file changed, 140 insertions(+)
>  create mode 100644 package/prboom/0003-gcc-warnings-const-myargv-instead-of-const-char-const-myargv.patch

Both patches applied to master, thanks!

It's another package with no release since 2008, even the fork you took
the patch from is archived. I would suggest we drop it.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot