Re: [Buildroot] [PATCH] package/bash: fix build with gcc 15

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN via buildroot" <buildroot@buildroot.org>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
	Adam Duskett <adam.duskett@amarulasolutions.com>,
	Florian Larysch <fl@n621.de>, Julien Olivain <ju.o@free.fr>
Subject: Re: [Buildroot] [PATCH] package/bash: fix build with gcc 15
Date: Sat, 16 Aug 2025 23:06:59 +0200	[thread overview]
Message-ID: <20250816230659.2134186f@windsurf> (raw)
In-Reply-To: <20250811153257.3746260-1-yann.morin.1998@free.fr>

Hello Yann,

Thanks for the patch!

On Mon, 11 Aug 2025 17:32:57 +0200
"Yann E. MORIN via buildroot" <buildroot@buildroot.org> wrote:

> Commit 6d09b25d08fe (package/bash: fix build with host GCC 15) did
> apply a workaround for when the host gcc is gcc-15 (or later), but
> missed the fact that the target compiler also exhibits build issues.
> 
> For the same reasons as explained in 6d09b25d08fe, don't try and fix
> those issues, but just paper over the problem by using an older C
> standard.
> 
> Fixes: b7882d024ae484c52473955fbbcbf3b5f0717c2f

This "Fixes" didn't make much sense. You're not really fixing a
previous commit here. Rather you're fixing an autobuilder issue, so
I've added a reference to the autobuilder issue being fixed instead.

> +ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_15),y)
> +BASH_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -std=gnu17"
> +endif

Added a comment above this indicating that it can be dropped when
bumping to bash 5.3.

Applied to master with those fixes. Thanks again!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot