Re: [Buildroot] [PATCH 1/4] package/adsp-ldr: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Philip,

On Tue, 19 Aug 2025 11:53:00 +0000
Philip Molloy <philip@philipmolloy.com> wrote:

> Absolutely, renamed it to Config.in.host and updated accordingly. Pushed it, along
> with all other changes to the branch linked to in the cover letter.

You don't need a Config.in.host file. This tool is merely a build
dependency for U-Boot to do its job, so it's sufficient to have U-Boot
add host-adsp-ldr to UBOOT_DEPENDENCIES. No need for a Config.in.host.

> > Are you sure that this license file is correct? Indeed, all source
> > files seem to have a BSD-3-Clause license, for example:
> > https://github.com/analogdevicesinc/adsp-ldr/blob/main/src/ldr/lfd.c.  
> 
> Thanks for noticing this! I'll try to address it in a new release.

But in the mean time? You'll set ADSP_LDR_LICENSE to BSD-3-Clause and
use one of the source files as a license file?

> > Why do you install it with a $(TARGET_CROSS) prefix?  
> 
> It is currently required by mainline U-Boot.[1] More context below.
> 
> [1]: https://elixir.bootlin.com/u-boot/v2025.07/source/Makefile#L405

OK, understood. Then probably a comment in the .mk file makes sense.

> > Also, you seem to be the author of this repo. Why is the ldr code
> > burried in src/ldr, with not much outside of this folder? It would make
> > a lot more sense to have the code directly at the project root, and
> > avoid having to pass ADSP_LDR_SUBDIR = src/ldr.  
> 
> This code is very very old. I was not even able to track down the
> full history internally at ADI.
> 
> The DSP line of processors were (and largely still are) used to run
> baremetal or FreeRTOS applications, which are developed using a IDE
> called CCES, which includes a custom toolchain (hence the prefix
> above). Some DSP processors do not even have ARM cores.
> 
> As they began to support Linux with larger ARM cores, the code
> necessary to generate boot streams was extracted from a CCES related
> mono repo and copied into the Github repository. That happened a few
> years ago and was never updated.
> 
> So far I've renamed the repo, switched from master to main, merged a
> "release" branch into main, and created a Github release. But there
> is still a lot that can be improved.
> 
> I have spent some time cleaning things up[2], but I need to refactor
> it a bit and rebase onto main since merging the release branch. As
> I'm sure you can imagine, this isn't a high priority. :-P

I can understand all of that, but I don't quite understand why all this
history implies that the code should be buried in a sub-subdir of a
brand new Git repo that otherwise doesn't contain anything else?

Basically, just recreate your Git repo with the contents of src/ldr/,
but directly at the root of your repo, and work from there.

> We are also focusing more on mainline U-Boot and Linux support, but
> it is naturally a slow process.

Nice!

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot