From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Florian Larysch <fl@n621.de>
Cc: buildroot@buildroot.org, Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/tinycbor: bump to version 0.6.1
Date: Fri, 22 Aug 2025 22:41:37 +0200 [thread overview]
Message-ID: <20250822224137.06fce9ec@windsurf> (raw)
In-Reply-To: <20250819213303.31241-1-fl@n621.de>
On Tue, 19 Aug 2025 23:32:59 +0200
Florian Larysch <fl@n621.de> wrote:
> This is nominally a bugfix release which now also includes the patch we
> previously backported, so we can remove it.
>
> However, it also introduced some breakage:
>
> - Builds with older toolchains (like br-arm-full-static, GCC 9) fail
> because the introduction of C23 [[fallthrough]] to the code was not
> properly gated on compiler support.
>
> - Compiling for x86 without SSE2 support (e.g. with
> bootlin-x86-i686-musl) fails because the check for native half-with
> float arithmetic support on the target was not strict enough.
>
> Import unreleased upstream patches that fix these issues.
>
> Release notes: https://github.com/intel/tinycbor/releases/tag/v0.6.1
>
> Signed-off-by: Florian Larysch <fl@n621.de>
> ---
> ...CC-11-fallthrough-is-supported-but-n.patch | 55 +++++++++++++++++
> .../0001-Makefile-add-DISABLE_WERROR.patch | 44 --------------
> .../0002-fix-build-on-i386-without-SSE2.patch | 59 +++++++++++++++++++
> package/tinycbor/tinycbor.hash | 2 +-
> package/tinycbor/tinycbor.mk | 2 +-
> 5 files changed, 116 insertions(+), 46 deletions(-)
> create mode 100644 package/tinycbor/0001-Fix-build-with-GCC-11-fallthrough-is-supported-but-n.patch
> delete mode 100644 package/tinycbor/0001-Makefile-add-DISABLE_WERROR.patch
> create mode 100644 package/tinycbor/0002-fix-build-on-i386-without-SSE2.patch
Thanks for this patch. Even though it's a bug fix only release, it
seems to introduce some potential breakage, and we haven't had any
failures of tinycbor in our autobuilders for the past 3 years, so I
applied to next. Just a minor nit: you hard forgotten to update our
.checkpackageignore file which was ignoring an issue with patch 0001
that you're deleting.
Thanks a lot for this contribution!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-08-22 20:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 21:32 [Buildroot] [PATCH 1/1] package/tinycbor: bump to version 0.6.1 Florian Larysch
2025-08-22 20:41 ` Thomas Petazzoni via buildroot [this message]
2025-08-22 21:09 ` Florian Larysch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250822224137.06fce9ec@windsurf \
--to=buildroot@buildroot.org \
--cc=fl@n621.de \
--cc=fontaine.fabrice@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox