From: Luca Ceresoli via buildroot <buildroot@buildroot.org>
To: Neal Frager <neal.frager@amd.com>
Cc: martin.chabot@gmail.com, buildroot@buildroot.org,
brandon.maier@collins.com, ju.o@free.fr, juju@cotds.org,
thomas.petazzoni@bootlin.com, michal.simek@amd.com
Subject: Re: [Buildroot] [PATCH v3 2/2] boot/uboot: add cpu dependency to BR2_TARGET_UBOOT_ZYNQ
Date: Fri, 29 Aug 2025 10:09:15 +0200 [thread overview]
Message-ID: <20250829100915.768e8207@booty> (raw)
In-Reply-To: <20250813173037.3052024-2-neal.frager@amd.com>
Hello Neal,
On Wed, 13 Aug 2025 18:30:37 +0100
Neal Frager <neal.frager@amd.com> wrote:
> This patch adds a BR2_cortex_a9 cpu dependency to BR2_TARGET_UBOOT_ZYNQ.
The commit message should describe why, not what. What the patch does
is clearly visible in the diff. Why it does it need to to be clarified
in the commit message, e.g.:
Zynq SoCs are all based on Cortex-A9, thus showing this option for
other cores is useless.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-08-29 8:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 17:30 [Buildroot] [PATCH v3 1/2] boot/uboot: add support for custom zynq ps7_init_gpl.c Neal Frager via buildroot
2025-08-13 17:30 ` [Buildroot] [PATCH v3 2/2] boot/uboot: add cpu dependency to BR2_TARGET_UBOOT_ZYNQ Neal Frager via buildroot
2025-08-29 8:09 ` Luca Ceresoli via buildroot [this message]
2025-08-31 13:28 ` Frager, Neal via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829100915.768e8207@booty \
--to=buildroot@buildroot.org \
--cc=brandon.maier@collins.com \
--cc=ju.o@free.fr \
--cc=juju@cotds.org \
--cc=luca.ceresoli@bootlin.com \
--cc=martin.chabot@gmail.com \
--cc=michal.simek@amd.com \
--cc=neal.frager@amd.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox