Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@buildroot.org
Subject: [Buildroot] [PATCH] package/jose: needs shared libraries
Date: Mon,  1 Sep 2025 16:32:52 +0200	[thread overview]
Message-ID: <20250901143252.672903-1-peter@korsgaard.com> (raw)

Fixes https://autobuild.buildroot.net/results/bf23e75461877a4ca3a189626f30cf8cde24de36/

Jose unconditionally builds a shared library since v11 with:

 commit b72f8cad002edc87286dd1f2331c359158c512e8
 Author: Rosen Penev <rosenp@gmail.com>
 Date:   Tue May 30 12:18:30 2023 +0300

   jose: build library only as shared (#119)

   Needed because of constructor usage in library.

So add a dependency on BR2_SHARED_LIBS.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/jose/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/jose/Config.in b/package/jose/Config.in
index 4a9ed8da65..32e17276b6 100644
--- a/package/jose/Config.in
+++ b/package/jose/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_JOSE
 	bool "jose"
+	depends on BR2_SHARED_LIBS # builds .so
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_ZLIB
 	select BR2_PACKAGE_JANSSON
@@ -10,5 +11,5 @@ config BR2_PACKAGE_JOSE
 
 	  https://github.com/latchset/jose
 
-comment "jose needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+comment "jose needs a toolchain w/ shared libraries, threads"
+	depends on !BR2_SHARED_LIBS || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.39.5

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

             reply	other threads:[~2025-09-01 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-01 14:32 Peter Korsgaard [this message]
2025-09-03 16:18 ` [Buildroot] [PATCH] package/jose: needs shared libraries Peter Korsgaard
2025-09-11 19:22 ` Thomas Perale via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250901143252.672903-1-peter@korsgaard.com \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox