Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: El Mehdi YOUNES via buildroot <buildroot@buildroot.org>
Cc: El Mehdi YOUNES <elmehdi.younes@smile.fr>,
	David Pierret <david.pierret@smile.fr>
Subject: Re: [Buildroot] [PATCH 1/1] package/bat: fix build with GCC 15
Date: Wed, 3 Sep 2025 21:21:21 +0200	[thread overview]
Message-ID: <20250903212121.5fa1d5f3@windsurf> (raw)
In-Reply-To: <20250902134250.622347-1-elmehdi.younes@smile.fr>

On Tue,  2 Sep 2025 15:42:50 +0200
El Mehdi YOUNES via buildroot <buildroot@buildroot.org> wrote:

> Bat pulls in the onig crate (version 6.4.0) through syntect with the
> default "regex-onig" feature. This crate depends on the Oniguruma C
> library (via onig_sys), which fails to build with GCC 15 due to C23
> keyword conflicts. Newer versions of onig fix this issue, but bat
> cannot directly update the onig version because it is pinned by syntect.
> 
> To resolve the build failure, apply a patch that replaces the
> "regex-onig" feature with "regex-fancy" in bat's minimal-application
> feature set. This switches bat to use the pure-Rust fancy-regex engine
> instead of Oniguruma, avoiding the problematic onig_sys dependency.
> 
> Fixes:
> 
>   https://autobuild.buildroot.net/?reason=bat-%
> 
> Signed-off-by: El Mehdi YOUNES <elmehdi.younes@smile.fr>
> ---
>  ...ig-by-regex-fancy-in-minimal-applica.patch | 40 +++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 package/bat/0001-Replace-regex-onig-by-regex-fancy-in-minimal-applica.patch

Tested-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

If you fix the autobuild.buildroot.net URL and clarify the "Upstream:
not submitted" tag in the patch, this is good to go for me as it allows
to fix the build issue.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2025-09-03 19:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-02 13:42 [Buildroot] [PATCH 1/1] package/bat: fix build with GCC 15 El Mehdi YOUNES via buildroot
2025-09-02 13:49 ` Thomas Petazzoni via buildroot
2025-09-02 14:56   ` El Mehdi YOUNES via buildroot
2025-09-02 15:11     ` Thomas Petazzoni via buildroot
2025-09-02 15:28       ` El Mehdi YOUNES via buildroot
2025-09-02 15:42         ` Thomas Petazzoni via buildroot
2025-09-03 19:21 ` Thomas Petazzoni via buildroot [this message]
2025-09-04 15:12   ` El Mehdi YOUNES via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250903212121.5fa1d5f3@windsurf \
    --to=buildroot@buildroot.org \
    --cc=david.pierret@smile.fr \
    --cc=elmehdi.younes@smile.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox