From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Waldemar Brodkorb <wbx@openadk.org>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/x11r7/xapp_xdm: needs libxcrypt
Date: Thu, 25 Sep 2025 22:16:56 +0200 [thread overview]
Message-ID: <20250925201656.44080-1-thomas.perale@mind.be> (raw)
In-Reply-To: <aMuoZp7b7IWmRRXs@waldemar-brodkorb.de>
In reply of:
> While doing a per-package build the package is failing to
> compile with this error (gcc 13.x glibc toochain):
> make[3]: Entering directory
> '/home/wbx/buildroot-2025.02.3/output/build/xapp_xdm-1.1.14/xdm' CC
> session.o session.c:146:11: fatal error: crypt.h: No such file or
> directory 146 | # include <crypt.h> | ^~~~~~~~~
> compilation terminated.
>
> Fix this error by providing the needed glibc dependencies.
>
> Fixes:
> https://autobuild.buildroot.org/results/b75/b75ad8f1159613656dce482992c800545d60ae69/
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
Applied to 2025.02.x, 2025.05.x & 2025.08.x. Thanks
> ---
> package/x11r7/xapp_xdm/Config.in | 1 +
> package/x11r7/xapp_xdm/xapp_xdm.mk | 4 ++++
> 2 files changed, 5 insertions(+)
>
> diff --git a/package/x11r7/xapp_xdm/Config.in b/package/x11r7/xapp_xdm/Config.in
> index 1ac15ce368..adeb3ce0c0 100644
> --- a/package/x11r7/xapp_xdm/Config.in
> +++ b/package/x11r7/xapp_xdm/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_XAPP_XDM
> depends on BR2_USE_MMU # fork()
> # Runtime dependency: can't start an X server unless there is one
> depends on BR2_PACKAGE_XSERVER_XORG_SERVER
> + select BR2_PACKAGE_LIBXCRYPT if BR2_TOOLCHAIN_USES_GLIBC
> select BR2_PACKAGE_XAPP_SESSREG
> select BR2_PACKAGE_XAPP_XRDB
> select BR2_PACKAGE_XLIB_LIBX11
> diff --git a/package/x11r7/xapp_xdm/xapp_xdm.mk b/package/x11r7/xapp_xdm/xapp_xdm.mk
> index 035f2e9484..2a343b55e2 100644
> --- a/package/x11r7/xapp_xdm/xapp_xdm.mk
> +++ b/package/x11r7/xapp_xdm/xapp_xdm.mk
> @@ -30,6 +30,10 @@ else
> XAPP_XDM_CONF_OPTS += --without-xinerama
> endif
>
> +ifeq ($(BR2_PACKAGE_LIBXCRYPT),y)
> +XAPP_XDM_DEPENDENCIES += libxcrypt
> +endif
> +
> define XAPP_XDM_INSTALL_INIT_SYSV
> $(INSTALL) -m 0755 -D package/x11r7/xapp_xdm/S99xdm \
> $(TARGET_DIR)/etc/init.d/S99xdm
> --
> 2.47.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2025-09-25 20:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 6:36 [Buildroot] [PATCH] package/x11r7/xapp_xdm: needs libxcrypt Waldemar Brodkorb
2025-09-18 6:59 ` Waldemar Brodkorb
2025-09-18 20:25 ` Julien Olivain via buildroot
2025-09-25 20:16 ` Thomas Perale via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250925201656.44080-1-thomas.perale@mind.be \
--to=buildroot@buildroot.org \
--cc=thomas.perale@mind.be \
--cc=wbx@openadk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox