From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: buildroot@buildroot.org, Bernd Kuhls <bernd@kuhls.net>,
nicolas.carrier@nav-timing.safrangroup.com
Subject: Re: [Buildroot] [PATCH RESEND 1/2] package/libldns: add an option to build and install drill
Date: Fri, 17 Oct 2025 08:46:17 +0200 [thread overview]
Message-ID: <20251017084617.7113dd26@windsurf> (raw)
In-Reply-To: <20251016-libldns_drill-v1-1-21bfa8c53896@bootlin.com>
Hello Alexis,
Thanks for the patch!
On Thu, 16 Oct 2025 17:27:02 +0200
Alexis Lothoré <alexis.lothore@bootlin.com> wrote:
> The libldns library also comes with a CLI tool named drill, allowing to
> perform DNS requests. Drill build is currently disabled by default.
>
> Add a KConfig option to allow building and installing drill tool. Set
> the default value to n to preserve the current behavior. Similarly to
> linktest (see the comment in the .mk), drill fails to build correctly as
> a static binary, so make the new option depend on non-static build.
Missing SoB.
> diff --git a/package/libldns/Config.in b/package/libldns/Config.in
> index 696fec97b59857fbd99bdcaababa09d49774f3ae..7a169c495281be01b2ee724fd2f9e27b83f5e2ec 100644
> --- a/package/libldns/Config.in
> +++ b/package/libldns/Config.in
> @@ -8,3 +8,17 @@ config BR2_PACKAGE_LIBLDNS
> experimental software for current Internet Drafts.
>
> http://www.nlnetlabs.nl/projects/ldns
> +
> +if BR2_PACKAGE_LIBLDNS
> +
> +config BR2_PACKAGE_LIBLDNS_DRILL
> + bool "drill binary"
> + default n
default n is the default, so it's not needed.
> + depends on !BR2_STATIC_LIBS
> + help
> + Install the drill binary
> +
> +comment "drill needs dynamic library"
comment "drill needs a toolchain w/ dynamic library"
Otherwise, looks good!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-10-17 6:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 15:27 [Buildroot] [PATCH RESEND 0/2] package/libldns: allow to build drill Alexis Lothoré via buildroot
2025-10-16 15:27 ` [Buildroot] [PATCH RESEND 1/2] package/libldns: add an option to build and install drill Alexis Lothoré via buildroot
2025-10-17 6:46 ` Thomas Petazzoni via buildroot [this message]
2025-10-17 7:10 ` Alexis Lothoré via buildroot
2025-10-16 15:27 ` [Buildroot] [PATCH RESEND 2/2] support/testing: add basic runtime test for libldns/drill Alexis Lothoré via buildroot
2025-10-17 6:46 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251017084617.7113dd26@windsurf \
--to=buildroot@buildroot.org \
--cc=alexis.lothore@bootlin.com \
--cc=bernd@kuhls.net \
--cc=nicolas.carrier@nav-timing.safrangroup.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox