Re: [Buildroot] [PATCH 1/2] package/rasdaemon: Add rasdaemon package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>
Cc: buildroot@buildroot.org, Fiona Klute <fiona.klute@gmx.de>
Subject: Re: [Buildroot] [PATCH 1/2] package/rasdaemon: Add rasdaemon package
Date: Wed, 26 Nov 2025 11:59:54 +0100	[thread overview]
Message-ID: <20251126115954.1922ba41@windsurf> (raw)
In-Reply-To: <20251126-rasdaemon-v1-1-38c590f3e591@bootlin.com>

Hello Bastien,

Thanks for the patch! Some comments below.

On Wed, 26 Nov 2025 11:20:09 +0100
Bastien Curutchet <bastien.curutchet@bootlin.com> wrote:

> diff --git a/package/rasdaemon/Config.in b/package/rasdaemon/Config.in
> new file mode 100644
> index 0000000000000000000000000000000000000000..f6ceb3585ce5612ba598b182e6538a49d1adb8f8
> --- /dev/null
> +++ b/package/rasdaemon/Config.in
> @@ -0,0 +1,23 @@
> +config BR2_PACKAGE_RASDAEMON
> +	bool "rasdaemon"
> +	depends on !BR2_STATIC_LIBS # libtraceevent
> +	select BR2_PACKAGE_LIBTRACEEVENT
> +	select BR2_PACKAGE_SQLITE
> +	select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
> +	help
> +	  rasdaemon is a tool that collects all hardware error events
> +	  reported by the Linux Kernel from several sources (EDAC, MCE
> +	  PCI, ...) into one common framework.
> +	  See https://github.com/mchehab/rasdaemon for details.
> +
> +if BR2_PACKAGE_RASDAEMON
> +
> +config BR2_PACKAGE_RASDAEMON_AER
> +	bool "Enable AER support"
> +	default y
> +	select BR2_PACKAGE_PCIUTILS
> +	help
> +	  Enable handling of AER (Advanced Error Reporting) events on
> +	  PCIe
> +
> +endif

You need here:

comment "rasdaemon needs a toolchain w/ dynamic library"
	depends on BR2_STATIC_LIBS

Also, I'm in fact not sure the "default y" is good for
BR2_PACKAGE_RASDAEMON_AER. We generally try to keep optional features
disabled by default in Buildroot, and especially if they bring
additional dependencies.

> diff --git a/package/rasdaemon/rasdaemon.hash b/package/rasdaemon/rasdaemon.hash
> new file mode 100644
> index 0000000000000000000000000000000000000000..768475ce597a63b1738388c2bdebcc3117f006a8
> --- /dev/null
> +++ b/package/rasdaemon/rasdaemon.hash
> @@ -0,0 +1 @@

Please add:

# Locally calculated

here

> +sha256  7e12459f9477036491ac2b1e4c07cc3e8efea6dcd30525a263ab1f83910b773a  rasdaemon-0.8.4.tar.gz

And also, add the hash of the license file.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot