Re: [Buildroot] [PATCH v5 1/1] package/spdm-utils: new package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Wilfred Mallawa via buildroot <buildroot@buildroot.org>
Cc: Wilfred Mallawa <wilfred.mallawa@wdc.com>,
	Alistair Francis <alistair@alistair23.me>,
	Wilfred Mallawa <wilfred.opensource@gmail.com>,
	Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [Buildroot] [PATCH v5 1/1] package/spdm-utils: new package
Date: Tue, 23 Dec 2025 23:14:07 +0100	[thread overview]
Message-ID: <20251223231407.68c506ea@windsurf> (raw)
In-Reply-To: <20241118025944.1068363-2-wilfred.mallawa@wdc.com>

Hello,

Sorry for the very slow feedback. I have some very minor comments below
(which I had fixed locally). But unfortunately the build fails for me.

Take this defconfig:

BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_AARCH64_GLIBC_STABLE=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_PACKAGE_SPDM_UTILS=y

And build it under our Docker container:

./utils/docker-run make

The build will fail with:

  = note: /home/thomas/buildroot/sdpm/output/host/opt/ext-toolchain/bin/../lib/gcc/aarch64-buildroot-linux-gnu/14.3.0/../../../../aarch64-buildroot-
linux-gnu/bin/ld: /home/thomas/buildroot/sdpm/output/host/aarch64-buildroot-linux-gnu/sysroot/usr/lib//libcryptlib_openssl.a(x509.c.o): undefined re
ference to symbol '__stack_chk_guard@@GLIBC_2.17'
          /home/thomas/buildroot/sdpm/output/host/opt/ext-toolchain/bin/../lib/gcc/aarch64-buildroot-linux-gnu/14.3.0/../../../../aarch64-buildroot-
linux-gnu/bin/ld: /home/thomas/buildroot/sdpm/output/host/aarch64-buildroot-linux-gnu/sysroot/lib/ld-linux-aarch64.so.1: error adding symbols: DSO m
issing from command line
          collect2: error: ld returned 1 exit status

This seems to be a disagreement on -fstack-protector usage, like
spdm-utils forcing it or something like that (I didn't investigate).

Also, when I read
https://github.com/westerndigitalcorporation/spdm-utils, it seems to
imply that installing the cbor-diag Ruby gem is needed, but I don't see
where you're handling this in your package.

See the (very very) minor comments below.

On Mon, 18 Nov 2024 12:59:45 +1000
Wilfred Mallawa via buildroot <buildroot@buildroot.org> wrote:

> 	- Drop the ruby/gem dependency entirely as`spdm-utils` v0.7.1 makes it
> 	  optional.

Ah? So the documentation is no longer accurate? Then is host-ruby still
needed as a dependency?

> +SPDM_UTILS_ALIAS_CERTS = \
> +		openssl.cnf \
> +		slot0/immutable.der \
> +		slot0/device.cert.der \
> +		slot0/device.der \
> +		slot0/device.key \
> +		slot0/bundle_responder.certchain.der

One tab for indentation.

> +
> +# Used to generate SPDM Alias certificate model certificates,
> +# required by `setup_certs.sh`
> +SPDM_UTILS_GENERIC_CERTS = \
> +		slot0/param.pem \
> +		slot0/end_requester.req \
> +		slot0/end_requester.key \
> +		slot0/end_responder.key \
> +		slot0/end_responder.req

Ditto.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot