Re: [Buildroot] [PATCH 2/4] package/jmp: new host package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello François,

On Sat, 20 Dec 2025 18:34:10 +0100
Francois Perrad via buildroot <buildroot@buildroot.org> wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

It is always nice to not have an empty commit log when adding new
packages, especially when what they are useful for is not super clear.

> diff --git a/package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch b/package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch
> new file mode 100644
> index 000000000..4569a469d
> --- /dev/null
> +++ b/package/jpm/0001-fix-linker-command-with-BR-toolchain-wrapper.patch
> @@ -0,0 +1,27 @@
> +From 33982bbf739a3a4eb70cf18a0575d5106324873a Mon Sep 17 00:00:00 2001
> +From: Francois Perrad <francois.perrad@gadz.org>
> +Date: Mon, 20 Oct 2025 14:57:25 +0200
> +Subject: [PATCH] fix linker command with BR toolchain-wrapper
> +
> +Upstream: N/A specific for Buildroot build
> +Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> +---
> + jpm/cc.janet | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/jpm/cc.janet b/jpm/cc.janet
> +index c5abdac..4ebb25c 100644
> +--- a/jpm/cc.janet
> ++++ b/jpm/cc.janet
> +@@ -110,7 +110,7 @@
> +         (if (dyn :is-msvc)
> +           (clexe-shell linker ;ldflags (string "/OUT:" target) ;objects
> +                  (string (dyn:headerpath) "/janet.lib") ;dep-importlibs ;lflags)
> +-          (shell linker ;cflags ;ldflags `-o` target ;objects ;lflags))))
> ++          (shell linker ;lflags `-o` target ;objects))))

What is the actual problem being fixed here? Having something not
upstreamable is clearly not nice for a brand new package.


> +define HOST_JPM_INSTALL_CMDS
> +	(cd $(@D); \
> +		DESTDIR=$(HOST_DIR) \
> +		PREFIX=/usr \

You should use:

		PREFIX=$(HOST_DIR)

> +		JANET_BINPATH=/usr/bin \
> +		JANET_MODPATH=/usr/lib/janet \
> +		JANET_MANPATH=/usr/share/man/man1 \
> +		$(HOST_DIR)/bin/janet bootstrap.janet);
> +	$(SED) 's|/usr/|$(HOST_DIR)/usr/|' $(HOST_DIR)/usr/bin/jpm

And hopefully this will allow to avoid this $(SED) ?

Note that $(HOST_DIR)/usr should no longer be used. Use $(HOST_DIR)
directly.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot