Re: [Buildroot] [PATCH 1/2] libyang-cpp: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Vincent,

I have applied your patch, after doing a small number of tweaks, see
below.

On Fri,  5 Dec 2025 11:06:25 +0100
Vincent Jardin via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/package/libyang-cpp/Config.in b/package/libyang-cpp/Config.in
> new file mode 100644
> index 0000000000..5bb79ffb2e
> --- /dev/null
> +++ b/package/libyang-cpp/Config.in
> @@ -0,0 +1,15 @@
> +config BR2_PACKAGE_LIBYANG_CPP
> +	bool "libyang-cpp"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_10
> +	select BR2_PACKAGE_LIBYANG

You forgot to replicate the "depends on" of BR2_PACKAGE_LIBYANG, so I
fixed this to:

        bool "libyang-cpp"
        depends on BR2_INSTALL_LIBSTDCPP
        depends on BR2_TOOLCHAIN_GCC_AT_LEAST_10
        depends on BR2_TOOLCHAIN_HAS_SYNC_4 # libyang
        depends on BR2_TOOLCHAIN_HAS_THREADS # libyang
        depends on !BR2_STATIC_LIBS # libyang
        select BR2_PACKAGE_LIBYANG

> +	help
> +	  C++ bindings for the libyang library (v4).
> +
> +	  libyang-cpp implements modern C++ RAII wrappers around the libyang

This line was too long, spotted by "make check-package".

> +	  C API, used by sysrepo, Kea + NETCONF, etc.
> +
> +	  https://github.com/CESNET/libyang-cpp
> +
> +comment "libyang-cpp needs a toolchain w/ C++, gcc >= 10"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_GCC_AT_LEAST_10

Had to update this according to the new dependencies.

> diff --git a/package/libyang-cpp/libyang-cpp.mk b/package/libyang-cpp/libyang-cpp.mk
> new file mode 100644
> index 0000000000..1fb109b03d
> --- /dev/null
> +++ b/package/libyang-cpp/libyang-cpp.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# libyang-cpp
> +#
> +################################################################################
> +
> +LIBYANG_CPP_VERSION = 4
> +LIBYANG_CPP_SITE = $(call github,CESNET,libyang-cpp,v$(LIBYANG_CPP_VERSION))
> +LIBYANG_CPP_LICENSE = BSD-3-Clause
> +LIBYANG_CPP_LICENSE_FILES = LICENSE
> +
> +LIBYANG_CPP_INSTALL_STAGING = YES
> +
> +LIBYANG_CPP_SUPPORTS_IN_SOURCE_BUILD = NO
> +
> +LIBYANG_CPP_DEPENDENCIES = libyang

A bit too many empty lines here (really just a matter of taste).

> +LIBYANG_CPP_CONF_OPTS = \
> +	-DBUILD_TESTING=OFF \

-DBUILD_TESTING=OFF is not needed, it's already passed by default by
cmake-package.

Applied with those changes, thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot