Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Frank Chung <uuidxx@163.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/rund: add new package
Date: Mon, 29 Dec 2025 14:04:22 +0100	[thread overview]
Message-ID: <20251229140422.72afe362@windsurf> (raw)
In-Reply-To: <824933a6-3d08-46cd-8ab4-add609401a60@163.com>

Hello Frank,

Thanks for your patch!

On Mon, 29 Dec 2025 18:25:20 +0800
Frank Chung <uuidxx@163.com> wrote:

>  From 0166d724f0d1309ff6615c087d90d822e8f95fb0 Mon Sep 17 00:00:00 2001
> From: Frank Chung <uuidxx@163.com>
> Date: Mon, 29 Dec 2025 18:23:14 +0800
> Subject: [PATCH 1/1] package/rund: add new package

It seems like your git setup is not quite correct, as this should
appear here. Can you use "git send-email" to send your patch?

> diff --git a/package/rund/Config.in b/package/rund/Config.in
> new file mode 100644
> index 0000000000..f21bd7a11a
> --- /dev/null
> +++ b/package/rund/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_RUND
> +	bool "rund"

It has really no dependencies on specific toolchain features? Could you
test your package with ./utils/test-pkg to verify this?

> +	help
> +		A lightweight daemonizer and process supervisor.
> +
> +		https://github.com/cyberxnomad/rund

Indentation for the help text is one tab + 2 spaces.

You can also run "make check-package" to verify trivial coding style
issues.

This project seems very new. Is this your project? Who uses this? I'm
just questioning the popularity and whether it makes sense to have this
in Buildroot at all?

> diff --git a/package/rund/rund.hash b/package/rund/rund.hash
> new file mode 100644
> index 0000000000..214774661e
> --- /dev/null
> +++ b/package/rund/rund.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256 
> 701127ac5b90e02ba4a670ab7534db9f2a6678e8f0f9ff13efbfbbe1414fb066 
> rund-0.1.0.tar.gz
> +sha256 
> 81100abfee87ff6bf6ba4b49ede1f81ee04cda31000b143cb75ab98e2845d8e0  LICENSE

These lines are wrapped, probably by your e-mail client. If you use
"git send-email", it will fix this.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2025-12-29 13:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-29 10:25 [Buildroot] [PATCH 1/1] package/rund: add new package Frank Chung
2025-12-29 13:04 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251229140422.72afe362@windsurf \
    --to=buildroot@buildroot.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=uuidxx@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox