Re: [Buildroot] [PATCH 2/6] package/libcamera-apps: fix LIBCAMERA_APPS_VERSION

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Fri, 26 Sep 2025 12:06:05 +0200
Dario Binacchi <dario.binacchi@amarulasolutions.com> wrote:

> -LIBCAMERA_APPS_VERSION = v1.7.0-10-ge9645231008146fa0e75c2b3e0ff8c48ad70511a
> -LIBCAMERA_APPS_SITE = $(call github,raspberrypi,rpicam-apps,$(LIBCAMERA_APPS_VERSION))
> +LIBCAMERA_APPS_VERSION = 1.7.0-10-ge9645231008146fa0e75c2b3e0ff8c48ad70511a
> +LIBCAMERA_APPS_SITE = $(call github,raspberrypi,rpicam-apps,v$(LIBCAMERA_APPS_VERSION))

While for embiggen-disk your patch was definitely useful, here I don't
see the point, because
1.7.0-10-ge9645231008146fa0e75c2b3e0ff8c48ad70511a still doesn't match
anything relevant on release-monitoring.org.

I'm not sure how to address this.

Option 1 is:

LIBCAMERA_APPS_VERSION = 1.7.0
LIBCAMERA_APPS_SITE = $(call github,raspberrypi,rpicam-apps,v$(LIBCAMERA_APPS_VERSION)-10-ge9645231008146fa0e75c2b3e0ff8c48ad70511a)

That's easy, but it means that during the build, the version display
will be just 1.7.0, and the build directory will be named
libcamera-apps-1.7.0, so we're kind of lying to  the user here.

The other option is to have a different variable for release-monitoring
lookups, that defaults to <pkg>_VERSION but can be overridden.

Like:

LIBCAMERA_APPS_RM_VERSION = 1.7.0
LIBCAMERA_APPS_VERSION = $(LIBCAMERA_APPS_RM_VERSION)-10-ge9645231008146fa0e75c2b3e0ff8c48ad70511a

Note that aside from that, we also have the case of packages fetched
through Git, for which we cannot currently separate the version from
the "download version", and therefore we do have these vX.Y.Z.

So I think some broader thinking/effort is needed here to solve this.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot