Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Thomas Devoogdt <thomas@devoogdt.com>
Cc: buildroot@buildroot.org, buildroot@tudorholton.com,
	thomas.devoogdt@barco.com
Subject: Re: [Buildroot] [PATCH v3] package/openjdk: allow compiling without X11 support
Date: Thu, 1 Jan 2026 15:08:28 +0100	[thread overview]
Message-ID: <20260101150828.20c47d75@windsurf> (raw)
In-Reply-To: <20251115154030.1746780-1-thomas@devoogdt.com>

Hello Thomas,

Thanks for your patch!

On Sat, 15 Nov 2025 16:40:30 +0100
Thomas Devoogdt <thomas@devoogdt.com> wrote:

> From: Thomas Devoogdt <thomas.devoogdt@barco.com>
> 
> Added patches (17.0.12+7 and 21.0.4+7) to allow compilation
> without X11 support.
> 
> 0003-autoconf-libraries-drop-the-need-for-X11-in-headless.patch
> is only needed for 21.0.4+7, 17.0.12+7 has already this commit:
> https://github.com/openjdk/jdk17u/commit/f97ec359ec688346956c29002edb28703d3ba032
> 
> Next to that, add a new option BR2_PACKAGE_OPENJDK_X11,
> to allow compilation with both head and headless support.
> 
> This commit also fixes the wrong patch folders which
> should have been fixed in commit 475c79d
> "package/openjdk{-bin}: bump versions to 17.0.12+7 and 21.0.4+7"

This point should really have been part of a separate commit. Indeed,
this point is a fix for an older commit which is in our LTS branch, so
we will want to backport the fix, but not the "build without X11"
aspect. Generally speaking, don't mix up different "topics" in the same
commit.

So I've split your change into two commits, and applied.

Could you have a look at support/testing/tests/package/test_openjdk.py,
and see if BR2_PACKAGE_XORG7=y can be dropped from the test
configuration?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-01-01 14:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-13 19:45 [Buildroot] [PATCH] package/openjdk: allow compiling without X11 support Thomas Devoogdt
2025-11-15 13:57 ` [Buildroot] [PATCH v2] " Thomas Devoogdt
2025-11-15 15:40   ` [Buildroot] [PATCH v3] " Thomas Devoogdt
2026-01-01 14:08     ` Thomas Petazzoni via buildroot [this message]
2026-01-02 18:51       ` [Buildroot] [PATCH v1] support/testing/tests/package/test_openjdk: drop the X11 dependency Thomas Devoogdt
2026-01-02 20:53         ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260101150828.20c47d75@windsurf \
    --to=buildroot@buildroot.org \
    --cc=buildroot@tudorholton.com \
    --cc=thomas.devoogdt@barco.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=thomas@devoogdt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox