Re: [Buildroot] [PATCH 1/2] package/libplacebo: add libplacebo package

From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org,
	Eric Le Bihan <eric.le.bihan.dev@free.fr>,
	Mahyar Koshkouei <mahyar.koshkouei@gmail.com>,
	Javad Rahimipetroudi <javad.rahimipetroudi@essensium.com>,
	Javad Rahimipetroudi <javad.rahimipetroudi@mind.be>,
	Sen Hastings <sen@hastings.org>
Subject: Re: [Buildroot] [PATCH 1/2] package/libplacebo: add libplacebo package
Date: Thu, 1 Jan 2026 17:31:04 +0100	[thread overview]
Message-ID: <20260101173104.649dbbaa@windsurf> (raw)
In-Reply-To: <20251003143043.641856-1-bernd@kuhls.net>

Hello,

On Fri,  3 Oct 2025 16:30:42 +0200
Bernd Kuhls <bernd@kuhls.net> wrote:

> From: Javad Rahimipetroudi <javad.rahimipetroudi@essensium.com>
> 
> This patch adds libplacebo package that is used
> by mpv player.
> libplacebo is the core rendering algorithms and
> ideas of mpv rewritten as an independent library
> and contains a large assortment of video processing
> shaders, focusing on both quality and performance.
> 
> Signed-off-by: Javad Rahimipetroudi <javad.rahimipetroudi@mind.be>

[...]

Thanks for the patch, I've applied, after doing a few tweaks.

> diff --git a/package/libplacebo/Config.in b/package/libplacebo/Config.in
> new file mode 100644
> index 0000000000..739de5c05c
> --- /dev/null
> +++ b/package/libplacebo/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_LIBPLACEBO
> +	bool "libplacebo"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_10 # C++20
> +	depends on BR2_TOOLCHAIN_HAS_ATOMIC
> +	depends on !BR2_STATIC_LIBS # needs <dlfcn.h>
> +	help
> +	  libplacebo is, in a nutshell, the core rendering
> +	  algorithms and ideas of mpv rewritten as an
> +	  independent library. As of today, libplacebo
> +	  contains a large assortment of video processing
> +	  shaders, focusing on both quality and performance.

Lines were a bit too short, rewrapped.

> +
> +	  https://libplacebo.org
> +
> +comment "libplacebo needs a toolchain w/ dynamic library, threads, gcc >= 10"
> +	depends on BR2_USE_MMU
> +	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS || \
> +		!BR2_TOOLCHAIN_GCC_AT_LEAST_10

This comment didn't match the actual dependencies.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot