From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: buildroot@buildroot.org, ju.o@free.fr, romain.naour@smile.fr
Subject: Re: [Buildroot] [PATCH] package/cpulimit: Correct function signature to use named parmeters
Date: Thu, 1 Jan 2026 18:12:09 +0100 [thread overview]
Message-ID: <20260101181209.6ecf51a3@windsurf> (raw)
In-Reply-To: <20251017171608.2940076-1-f.fainelli@gmail.com>
Hello Florian,
Happy New Year and best wishes for 2026! :-)
On Fri, 17 Oct 2025 10:16:08 -0700
Florian Fainelli <f.fainelli@gmail.com> wrote:
> Update 0005-Correct-loop-function-signature.patch to include a named
> parameter otherwise the following compiler warning turned error is
> triggered:
>
> busy.c:6:1: error: parameter name omitted
> void *loop(void *)
> ^~~~
>
> Fixes: https://autobuild.buildroot.org/results/8592e4eb5959124acc885a1cbc2f9d24fb7bcbd1
> Fixes: https://autobuild.buildroot.org/results/cf12d080ddd7a2398a79be430d935071ca3250a3/
> Fixes: e63181bc0056 ("package/cpulimit: Backport fix for function signature")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> package/cpulimit/0005-Correct-loop-function-signature.patch | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied to master after extending the commit log to explain a bit which
configurations are affected. Oddly enough recent compilers are happy,
but older GCC versions <= 10.x are not happy with the unnamed parameter.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-01-01 17:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 17:16 [Buildroot] [PATCH] package/cpulimit: Correct function signature to use named parmeters Florian Fainelli
2026-01-01 17:12 ` Thomas Petazzoni via buildroot [this message]
2026-01-13 19:45 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260101181209.6ecf51a3@windsurf \
--to=buildroot@buildroot.org \
--cc=f.fainelli@gmail.com \
--cc=ju.o@free.fr \
--cc=romain.naour@smile.fr \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox