Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org,
	Dario Binacchi <dario.binacchi@amarulasolutions.com>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/atf: fix non-threaded build
Date: Fri, 2 Jan 2026 18:04:16 +0100	[thread overview]
Message-ID: <20260102180416.5987ad9f@windsurf> (raw)
In-Reply-To: <20260102154342.1180158-1-bernd@kuhls.net>

Hello Bernd,

On Fri,  2 Jan 2026 16:43:42 +0100
Bernd Kuhls <bernd@kuhls.net> wrote:

> Buildroot commit d6c3257e931ed256e3ebcd78938f6146bba8586f bumped the
> package from 0.21 to 0.23. Upstream release 0.22 includes commit
> https://github.com/freebsd/atf/commit/d7c7c53c0626ab59a62aa4efcf05323b3621baa9
> which uses CLOCK_MONOTONIC without including time.h.
> 
> Fixes:
> https://autobuild.buildroot.net/results/41b/41b25ee8e66e34323eca011e4b5fe479ece9ed76/
> 
> Two minimal defconfigs to reproduce the build error:
> 
> BR2_TOOLCHAIN_BUILDROOT_UCLIBC=y
> BR2_PTHREADS_NONE=y
> BR2_TOOLCHAIN_BUILDROOT_CXX=y
> BR2_PACKAGE_ATF=y
> 
> BR2_TOOLCHAIN_BUILDROOT_UCLIBC=y
> BR2_PTHREADS_NONE=y
> BR2_GCC_VERSION_13_X=y
> BR2_TOOLCHAIN_BUILDROOT_CXX=y
> BR2_PACKAGE_ATF=y
> 
> All defconfigs of the build errors recorded by the buildroot autobuilders
> contain BR2_PTHREADS_NONE=y.
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Thanks, applied!


> diff --git a/package/atf/0001-atf-check.cpp-include-time.h.patch b/package/atf/0001-atf-check.cpp-include-time.h.patch
> new file mode 100644
> index 0000000000..359172c0e6
> --- /dev/null
> +++ b/package/atf/0001-atf-check.cpp-include-time.h.patch
> @@ -0,0 +1,33 @@
> +From 67e7d350a15aff88c151b1fc838dac83d35be955 Mon Sep 17 00:00:00 2001
> +From: Bernd Kuhls <bernd@kuhls.net>
> +Date: Sat, 22 Nov 2025 23:47:41 +0100
> +Subject: [PATCH] atf-check.cpp: include time.h
> +
> +Fixes build error with gcc 14 as reported by the buildroot autobuilders:

Note that this is therefore incorrect, but since that's how the patch
has been merged upstream, I left it as-is.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-01-02 17:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-02 15:43 [Buildroot] [PATCH v2 1/1] package/atf: fix non-threaded build Bernd Kuhls
2026-01-02 17:04 ` Thomas Petazzoni via buildroot [this message]
2026-01-13 19:48 ` Arnout Vandecappelle via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260102180416.5987ad9f@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox