From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Heiko Thiery <heiko.thiery@gmail.com>
Cc: Matt Weber <matthew.weber@rockwellcollins.com>,
Michael Walle <michael@walle.cc>,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/uboot-tools: use U-Boot host tool printinitialenv to extract environment
Date: Mon, 5 Jan 2026 14:42:06 +0100 [thread overview]
Message-ID: <20260105144206.6305e4e4@windsurf> (raw)
In-Reply-To: <20260105132326.4867-1-heiko.thiery@gmail.com>
Hello Heiko,
On Mon, 5 Jan 2026 14:23:27 +0100
Heiko Thiery <heiko.thiery@gmail.com> wrote:
> + if [ -x $(UBOOT_SRCDIR)/tools/printinitialenv ]; then \
> + $(UBOOT_SRCDIR)/tools/printinitialenv > $(UBOOT_TOOLS_GENERATE_ENV_FILE); \
> + else \
> + CROSS_COMPILE="$(TARGET_CROSS)" $(UBOOT_SRCDIR)/scripts/get_default_envs.sh $(UBOOT_SRCDIR); \
Aren't you now missing the > $(UBOOT_TOOLS_GENERATE_ENV_FILE)
redirection in this "else" clause ?
I'm not sure why we're using $(UBOOT_SRCDIR) in all of this instead of
$(@D), but that's a comment unrelated to your change.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-01-05 13:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 13:23 [Buildroot] [PATCH v2] package/uboot-tools: use U-Boot host tool printinitialenv to extract environment Heiko Thiery
2026-01-05 13:42 ` Thomas Petazzoni via buildroot [this message]
2026-01-05 13:50 ` Heiko Thiery
2026-01-05 13:56 ` Thomas Petazzoni via buildroot
2026-01-05 15:31 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260105144206.6305e4e4@windsurf \
--to=buildroot@buildroot.org \
--cc=heiko.thiery@gmail.com \
--cc=matthew.weber@rockwellcollins.com \
--cc=michael@walle.cc \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox