Re: [Buildroot] [PATCH 2/2] package/pico-sdk: Clone submodules for picotool

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Mon,  4 Aug 2025 20:03:52 -0400
Jesse Taube <mr.bossman075@gmail.com> wrote:

> picotool needs mbedtls for --hash --sign and --offset.
> Clone submodules in pico-sdk to provide the nessasaary files for

                                              ^^^^^^^^^^ typo

> picotool to build and link mbedtls and other optional libraries.
> 
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>

But then does that mean that your PATCH 1/2, without PATCH 2/2, breaks
the build of picotool?

If that's the case, then you should do this change to use submodules
directly in PATCH 1/2, as part of the bump, so that the build works
between every patch we apply.


> -PICO_SDK_VERSION = 2.1.1
> -PICO_SDK_SITE = $(call github,raspberrypi,pico-sdk,$(PICO_SDK_VERSION))
> +PICO_SDK_VERSION = refs/tags/2.1.1

Just "2.1.1" should be fine here

> +PICO_SDK_SITE = https://git@github.com/raspberrypi/pico-sdk.git

Should be just https://github.com/raspberrypi/pico-sdk.git

Has anyone reported to upstream that their release tarball should
contain the submodules?

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot