Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: buildroot@buildroot.org, Marcus Hoffmann <buildroot@bubu1.eu>
Subject: Re: [Buildroot] [PATCH 2/2] package/picotool: Add host-picotool
Date: Tue, 6 Jan 2026 22:41:15 +0100	[thread overview]
Message-ID: <20260106224115.4f44da16@windsurf> (raw)
In-Reply-To: <20250805025930.315021-2-Mr.Bossman075@gmail.com>

Hello Jesse,

On Mon,  4 Aug 2025 22:59:30 -0400
Jesse Taube <mr.bossman075@gmail.com> wrote:

> Add a host-picotool package to picotool.
> This will allow users to build rpi pico applications on the host system.

But what is the use-case for that?

> Also add cmake as a dependency to target picotool.

Nope this change is not correct, the host-cmake dependency is already
handled by cmake-package, if needed.

>  PICOTOOL_VERSION = 2.1.1
>  PICOTOOL_SITE = $(call github,raspberrypi,picotool,$(PICOTOOL_VERSION))
> +HOST_PICOTOOL_CONF_OPTS = -DPICO_SDK_PATH=$(HOST_DIR)/usr/share/pico-sdk
> +HOST_PICOTOOL_DEPENDENCIES = host-libusb host-pico-sdk2 host-cmake

                                                         ^^ sdk2 ?

Also, drop host-cmake.

>  PICOTOOL_CONF_OPTS = -DPICO_SDK_PATH=$(STAGING_DIR)/usr/share/pico-sdk
> -PICOTOOL_DEPENDENCIES = libusb pico-sdk
> +PICOTOOL_DEPENDENCIES = libusb pico-sdk2 host-cmake

sdk2 ?

Also, drop host-cmake.

>  PICOTOOL_LICENSE = BSD-3-Clause
>  PICOTOOL_LICENSE_FILES = LICENSE.TXT

Some reordering would make sense here:

PICOTOOL_VERSION = 2.1.1
PICOTOOL_SITE = $(call github,raspberrypi,picotool,$(PICOTOOL_VERSION))
PICOTOOL_LICENSE = BSD-3-Clause
PICOTOOL_LICENSE_FILES = LICENSE.TXT

PICOTOOL_CONF_OPTS = -DPICO_SDK_PATH=$(STAGING_DIR)/usr/share/pico-sdk
PICOTOOL_DEPENDENCIES = libusb pico-sdk

HOST_PICOTOOL_CONF_OPTS = -DPICO_SDK_PATH=$(HOST_DIR)/usr/share/pico-sdk
HOST_PICOTOOL_DEPENDENCIES = host-libusb host-pico-sdk

So that we have:

1. Generic variables (independent from host/target)

2. Target variables

3. Host variables

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-01-06 21:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-05  2:59 [Buildroot] [PATCH 1/2] package/pico-sdk: Add host-pico-sdk Jesse Taube
2025-08-05  2:59 ` [Buildroot] [PATCH 2/2] package/picotool: Add host-picotool Jesse Taube
2026-01-06 21:41   ` Thomas Petazzoni via buildroot [this message]
2026-01-12 21:37     ` Jesse T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260106224115.4f44da16@windsurf \
    --to=buildroot@buildroot.org \
    --cc=buildroot@bubu1.eu \
    --cc=mr.bossman075@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox