From: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: Arnout Vandecappelle <arnout@rnout.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 3/4] support/testing: ddrescue: use f-string for test config
Date: Wed, 7 Jan 2026 18:49:40 +0100 [thread overview]
Message-ID: <20260107174940.225462-1-arnout@rnout.be> (raw)
In-Reply-To: <20251219210957.556930-3-ju.o@free.fr>
In reply of:
> Signed-off-by: Julien Olivain <ju.o@free.fr>
Applied to 2025.02.x and 2025.11.x. Thanks
> ---
> support/testing/tests/package/test_ddrescue.py | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/support/testing/tests/package/test_ddrescue.py b/support/testing/tests/package/test_ddrescue.py
> index eb3f63ae53..bd34694737 100644
> --- a/support/testing/tests/package/test_ddrescue.py
> +++ b/support/testing/tests/package/test_ddrescue.py
> @@ -10,8 +10,10 @@ class TestDdrescue(infra.basetest.BRTest):
> # mapper dm-dust, which are used to simulate a failing storage
> # block device.
> # - lvm2 user space package is needed to configure dm-dust with dmsetup
> + kernel_fragment = \
> + infra.filepath("tests/package/test_ddrescue/linux-ddrescue.fragment")
> config = \
> - """
> + f"""
> BR2_aarch64=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
> @@ -20,16 +22,14 @@ class TestDdrescue(infra.basetest.BRTest):
> BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="6.18.2"
> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64-virt/linux.config"
> - BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="{}"
> + BR2_LINUX_KERNEL_CONFIG_FRAGMENT_FILES="{kernel_fragment}"
> BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
> BR2_PACKAGE_DDRESCUE=y
> BR2_PACKAGE_LVM2=y
> BR2_TARGET_ROOTFS_CPIO=y
> BR2_TARGET_ROOTFS_CPIO_GZIP=y
> # BR2_TARGET_ROOTFS_TAR is not set
> - """.format(
> - infra.filepath("tests/package/test_ddrescue/linux-ddrescue.fragment")
> - )
> + """
>
> def test_run(self):
> img = os.path.join(self.builddir, "images", "rootfs.cpio.gz")
> --
> 2.52.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-01-07 17:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 21:09 [Buildroot] [PATCH 1/4] support/testing: ddrescue: use dmsetup from lvm2 Julien Olivain via buildroot
2025-12-19 21:09 ` [Buildroot] [PATCH 2/4] support/testing: ddrescue: bump test kernel to 6.18.2 Julien Olivain via buildroot
2025-12-19 21:09 ` [Buildroot] [PATCH 3/4] support/testing: ddrescue: use f-string for test config Julien Olivain via buildroot
2026-01-07 17:49 ` Arnout Vandecappelle via buildroot [this message]
2025-12-19 21:09 ` [Buildroot] [PATCH 4/4] package/ddrescue: bump version to 1.29.1 Julien Olivain via buildroot
2025-12-27 23:40 ` [Buildroot] [PATCH 1/4] support/testing: ddrescue: use dmsetup from lvm2 Thomas Petazzoni via buildroot
2026-01-07 17:49 ` Arnout Vandecappelle via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107174940.225462-1-arnout@rnout.be \
--to=buildroot@buildroot.org \
--cc=arnout@rnout.be \
--cc=ju.o@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox