Re: [Buildroot] [PATCH v1 1/1] package/dot1ag-utils: new package

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Vincent,

Thanks for this patch. For series of just 1 patch, you don't need to
send a cover letter. It's OK to have one of course, but it's not
necessary.

On Wed,  7 Jan 2026 18:53:39 +0100
Vincent Jardin via buildroot <buildroot@buildroot.org> wrote:

> diff --git a/package/dot1ag-utils/0001-fix-strncpy-truncation-warnings.patch b/package/dot1ag-utils/0001-fix-strncpy-truncation-warnings.patch
> new file mode 100644
> index 0000000000..b987a45aa3
> --- /dev/null
> +++ b/package/dot1ag-utils/0001-fix-strncpy-truncation-warnings.patch
> @@ -0,0 +1,59 @@
> +From: Vincent Jardin <vjardin@free.fr>
> +Date: Tue, 7 Jan 2026 11:00:00 +0100
> +Subject: [PATCH] dot1ag_eth: fix strncpy truncation warnings with modern GCC
> +
> +Modern GCC with -Werror fails when strncpy size equals the destination
> +buffer size, as it may not null-terminate the string:
> +
> +  error: '__builtin_strncpy' specified bound 16 equals destination size
> +         [-Werror=stringop-truncation]
> +
> +Fix by using sizeof(dest) - 1 to leave room for the null terminator.
> +The structures are already zeroed with memset() before strncpy, so the
> +last byte remains '\0'.
> +
> +Signed-off-by: Vincent Jardin <vjardin@free.fr>

Needs an Upstream: tag that provides details on the upstream status of
this patch.

> --- /dev/null
> +++ b/package/dot1ag-utils/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_DOT1AG_UTILS
> +	bool "dot1ag-utils (IEEE 802.1ag tools)"

Should be just:

	bool "dot1g-utils"

> +	select BR2_PACKAGE_LIBPCAP

If you select a package, you need to replicate its dependencies, in
this case:

	depends on BR2_USE_MMU

> diff --git a/package/dot1ag-utils/dot1ag-utils.mk b/package/dot1ag-utils/dot1ag-utils.mk
> new file mode 100644
> index 0000000000..1cde7299a0
> --- /dev/null
> +++ b/package/dot1ag-utils/dot1ag-utils.mk
> @@ -0,0 +1,17 @@
> +################################################################################
> +#
> +# dot1ag-utils
> +#
> +################################################################################
> +
> +DOT1AG_UTILS_VERSION = 4886d70ba83166bd1333eb04df8198a8ddfc5680
> +DOT1AG_UTILS_SITE = $(call github,Bumblebee-Networks,dot1ag-utils,$(DOT1AG_UTILS_VERSION))
> +
> +DOT1AG_UTILS_LICENSE       = BSD-2-Clause

                       ^^^^^^ just one space before/after the = sign

> +DOT1AG_UTILS_LICENSE_FILES = LICENSE
> +
> +DOT1AG_UTILS_DEPENDENCIES = libpcap
> +
> +DOT1AG_UTILS_AUTORECONF = YES

You can probably drop the empty new lines between all those variable
definitions.

> +
> +$(eval $(autotools-package))

The rest looks good to me.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot