* [Buildroot] [PATCH] package/iniparser: new package
@ 2026-03-03 9:50 cp0613
2026-03-03 18:08 ` Julien Olivain via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: cp0613 @ 2026-03-03 9:50 UTC (permalink / raw)
To: buildroot; +Cc: ju.o, Chen Pei
From: Chen Pei <cp0613@linux.alibaba.com>
The iniparser is a simple C library offering ini file parsing services.
ndctl[1] requires it.
[1] https://github.com/pmem/ndctl
Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
---
package/Config.in | 1 +
package/iniparser/Config.in | 7 +++++++
package/iniparser/iniparser.hash | 3 +++
package/iniparser/iniparser.mk | 14 ++++++++++++++
4 files changed, 25 insertions(+)
create mode 100644 package/iniparser/Config.in
create mode 100644 package/iniparser/iniparser.hash
create mode 100644 package/iniparser/iniparser.mk
diff --git a/package/Config.in b/package/Config.in
index 20c9a2e155..d1dce9c4d7 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -2336,6 +2336,7 @@ menu "Text and terminal handling"
source "package/fstrcmp/Config.in"
source "package/icu/Config.in"
source "package/inih/Config.in"
+ source "package/iniparser/Config.in"
source "package/libcli/Config.in"
source "package/libecoli/Config.in"
source "package/libedit/Config.in"
diff --git a/package/iniparser/Config.in b/package/iniparser/Config.in
new file mode 100644
index 0000000000..56764c04e6
--- /dev/null
+++ b/package/iniparser/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_INIPARSER
+ bool "iniparser"
+ help
+ iniparser is a simple C library offering ini file
+ parsing services.
+
+ https://gitlab.com/iniparser/iniparser
diff --git a/package/iniparser/iniparser.hash b/package/iniparser/iniparser.hash
new file mode 100644
index 0000000000..27a5fa81aa
--- /dev/null
+++ b/package/iniparser/iniparser.hash
@@ -0,0 +1,3 @@
+# locally computed
+sha256 67575ed032a544d5359610e5f697af786371bbc3eb01311218ef8adfd3e5e329 iniparser-v4.2.6.tar.gz
+sha256 da809b67f3cc571433b7b97d4253ae1f9d8817770aa859aad202df6bde1d5fde LICENSE
diff --git a/package/iniparser/iniparser.mk b/package/iniparser/iniparser.mk
new file mode 100644
index 0000000000..9034a1cb78
--- /dev/null
+++ b/package/iniparser/iniparser.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# iniparser
+#
+################################################################################
+
+INIPARSER_VERSION = v4.2.6
+INIPARSER_SITE = https://gitlab.com/iniparser/iniparser/-/archive/$(INIPARSER_VERSION)
+INIPARSER_SOURCE = iniparser-$(INIPARSER_VERSION).tar.gz
+INIPARSER_INSTALL_STAGING = YES
+INIPARSER_LICENSE = MIT
+INIPARSER_LICENSE_FILES = LICENSE
+
+$(eval $(cmake-package))
--
2.50.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/iniparser: new package
2026-03-03 9:50 [Buildroot] [PATCH] package/iniparser: new package cp0613
@ 2026-03-03 18:08 ` Julien Olivain via buildroot
2026-03-04 7:05 ` cp0613
0 siblings, 1 reply; 3+ messages in thread
From: Julien Olivain via buildroot @ 2026-03-03 18:08 UTC (permalink / raw)
To: cp0613; +Cc: buildroot
Hi Chen,
Thanks for the patch. I have two minor comments, see below.
On 03/03/2026 10:50, cp0613@linux.alibaba.com wrote:
> From: Chen Pei <cp0613@linux.alibaba.com>
>
> The iniparser is a simple C library offering ini file parsing services.
>
> ndctl[1] requires it.
>
> [1] https://github.com/pmem/ndctl
>
> Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
> ---
[...]
> diff --git a/package/iniparser/iniparser.mk
> b/package/iniparser/iniparser.mk
> new file mode 100644
> index 0000000000..9034a1cb78
> --- /dev/null
> +++ b/package/iniparser/iniparser.mk
> @@ -0,0 +1,14 @@
> +################################################################################
> +#
> +# iniparser
> +#
> +################################################################################
> +
> +INIPARSER_VERSION = v4.2.6
> +INIPARSER_SITE =
> https://gitlab.com/iniparser/iniparser/-/archive/$(INIPARSER_VERSION)
> +INIPARSER_SOURCE = iniparser-$(INIPARSER_VERSION).tar.gz
Could you move the "v" from the _VERSION to _SITE and update _SOURCE,
please? This will allow our version monitoring scripts to work better.
We should preferably have:
INIPARSER_VERSION = 4.2.6
INIPARSER_SITE =
https://gitlab.com/iniparser/iniparser/-/archive/v$(INIPARSER_VERSION)
INIPARSER_SOURCE = iniparser-v$(INIPARSER_VERSION).tar.gz
Note: your initial submission was also reporting an error, which
should be fixed indirectly with the change I propose. Please make
sure to run the command "utils/docker-run make check-package" before
sending patches. See:
https://nightly.buildroot.org/manual.html#_preparing_a_patch_series
> +INIPARSER_INSTALL_STAGING = YES
> +INIPARSER_LICENSE = MIT
> +INIPARSER_LICENSE_FILES = LICENSE
> +
> +$(eval $(cmake-package))
> --
> 2.50.1
Also, quoting the Buildroot documentation at:
https://nightly.buildroot.org/manual.html#DEVELOPERS
"""
We ask developers adding new packages, new boards, or generally new
functionality in Buildroot, to register themselves in the DEVELOPERS
file. As an example, we expect a developer contributing a new package to
include in his patch the appropriate modification to the DEVELOPERS
file.
"""
Note that will received emails from the autobuilders in
case of build failures, and from other developers using
the get-developers script.
Could you add a new entry in the DEVELOPERS file registering
yourself to this new package?
Could you send an updated v2 patch with those changes, please?
Best regards,
Julien.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH] package/iniparser: new package
2026-03-03 18:08 ` Julien Olivain via buildroot
@ 2026-03-04 7:05 ` cp0613
0 siblings, 0 replies; 3+ messages in thread
From: cp0613 @ 2026-03-04 7:05 UTC (permalink / raw)
To: ju.o; +Cc: buildroot
On Tue, 03 Mar 2026 19:08:41 +0100, ju.o@free.fr wrote:
> > From: Chen Pei <cp0613@linux.alibaba.com>
> >
> > The iniparser is a simple C library offering ini file parsing services.
> >
> > ndctl[1] requires it.
> >
> > [1] https://github.com/pmem/ndctl
> >
> > Signed-off-by: Chen Pei <cp0613@linux.alibaba.com>
> > ---
> [...]
> > diff --git a/package/iniparser/iniparser.mk
> > b/package/iniparser/iniparser.mk
> > new file mode 100644
> > index 0000000000..9034a1cb78
> > --- /dev/null
> > +++ b/package/iniparser/iniparser.mk
> > @@ -0,0 +1,14 @@
> > +################################################################################
> > +#
> > +# iniparser
> > +#
> > +################################################################################
> > +
> > +INIPARSER_VERSION = v4.2.6
> > +INIPARSER_SITE =
> > https://gitlab.com/iniparser/iniparser/-/archive/$(INIPARSER_VERSION)
> > +INIPARSER_SOURCE = iniparser-$(INIPARSER_VERSION).tar.gz
>
> Could you move the "v" from the _VERSION to _SITE and update _SOURCE,
> please? This will allow our version monitoring scripts to work better.
> We should preferably have:
>
> INIPARSER_VERSION = 4.2.6
> INIPARSER_SITE =
> https://gitlab.com/iniparser/iniparser/-/archive/v$(INIPARSER_VERSION)
> INIPARSER_SOURCE = iniparser-v$(INIPARSER_VERSION).tar.gz
>
> Note: your initial submission was also reporting an error, which
> should be fixed indirectly with the change I propose. Please make
> sure to run the command "utils/docker-run make check-package" before
> sending patches. See:
> https://nightly.buildroot.org/manual.html#_preparing_a_patch_series
>
> > +INIPARSER_INSTALL_STAGING = YES
> > +INIPARSER_LICENSE = MIT
> > +INIPARSER_LICENSE_FILES = LICENSE
> > +
> > +$(eval $(cmake-package))
> > --
> > 2.50.1
>
> Also, quoting the Buildroot documentation at:
> https://nightly.buildroot.org/manual.html#DEVELOPERS
> """
> We ask developers adding new packages, new boards, or generally new
> functionality in Buildroot, to register themselves in the DEVELOPERS
> file. As an example, we expect a developer contributing a new package to
> include in his patch the appropriate modification to the DEVELOPERS
> file.
> """
>
> Note that will received emails from the autobuilders in
> case of build failures, and from other developers using
> the get-developers script.
>
> Could you add a new entry in the DEVELOPERS file registering
> yourself to this new package?
>
> Could you send an updated v2 patch with those changes, please?
>
Hi, Julien,
Thank you for your review and reminder. I will send an v2 patch,
update iniparser.mk, and add a new entry in the DEVELOPERS.
Thanks,
Pei
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-04 7:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-03 9:50 [Buildroot] [PATCH] package/iniparser: new package cp0613
2026-03-03 18:08 ` Julien Olivain via buildroot
2026-03-04 7:05 ` cp0613
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox