public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Adrian Perez de Castro <aperez@igalia.com>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/webkitgtk: disable JIT for all MIPS CPUs
Date: Fri,  6 Mar 2026 20:53:15 +0100	[thread overview]
Message-ID: <20260306195315.7959-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260228194406.1906845-1-aperez@igalia.com>

In reply of:
> Change the mips32r6 into a blanket BR2_mips[el] check to disable the
> JSC JIT. Upstream removed JIT support for all MIPS processors in
> January 2024 [0], and the change trickled down to stable releases
> starting on version 2.44.0 [1].
> 
> While at it, change the upstream bug links to point to a more
> appropriate bug report.
> 
> [0] https://commits.webkit.org/272866@main
> [1] https://lists.webkit.org/archives/list/webkit-wpe@lists.webkit.org/thread/JM7GLPPKGAB6DIQ2YDHPEIWNOYSUHBC7/
> 
> Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

Applied to 2025.02.x & 2025.11.x. Thanks

> ---
>  package/webkitgtk/webkitgtk.mk | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index d9aa48f024..161807bc5a 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -173,18 +173,16 @@ else
>  WEBKITGTK_CONF_OPTS += -DENABLE_JOURNALD_LOG=OFF
>  endif
>  
> -# JIT is not supported for MIPS r6, but the WebKit build system does not
> -# have a check for these processors. The same goes for ARMv5 and ARMv6.
> +# JIT is not supported for MIPS, ARMv5, and ARMv6, but the WebKit build
> +# system does not have a check for some of these target processors.
> +#
>  # Disable JIT forcibly here and use the CLoop interpreter instead.
> +# Also, we have to disable the sampling profiler and WebAssembly, which
> +# do NOT work with ENABLE_C_LOOP.
>  #
> -# Also, we have to disable the sampling profiler and webassembly,
> -# which does NOT work with ENABLE_C_LOOP.
> +# Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=278559
>  #
> -# Upstream bugs: https://bugs.webkit.org/show_bug.cgi?id=191258
> -#                https://bugs.webkit.org/show_bug.cgi?id=172765
> -#                https://bugs.webkit.org/show_bug.cgi?id=265218
> -#
> -ifeq ($(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV6)$(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y)
> +ifeq ($(BR2_ARM_CPU_ARMV5)$(BR2_ARM_CPU_ARMV6)$(BR2_mips)$(BR2_mipsel),y)
>  WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF -DENABLE_C_LOOP=ON \
>  	-DENABLE_SAMPLING_PROFILER=OFF \
>  	-DENABLE_WEBASSEMBLY=OFF
> -- 
> 2.53.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-03-06 19:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-28 19:44 [Buildroot] [PATCH] package/webkitgtk: disable JIT for all MIPS CPUs Adrian Perez de Castro
2026-03-01 14:02 ` Peter Korsgaard
2026-03-06 19:53 ` Thomas Perale via buildroot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-08-23 12:32 Adrian Perez de Castro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306195315.7959-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=aperez@igalia.com \
    --cc=thomas.perale@mind.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox