public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/libvirt: fix dependency of lxc support
Date: Fri,  6 Mar 2026 20:53:17 +0100	[thread overview]
Message-ID: <20260306195317.8067-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260301193708.3268222-1-bernd@kuhls.net>

In reply of:
> Buildroot commit ed12e2fbed3d4298ebff9da54fe56b91fa75c41e in 2021 added
> BR2_PACKAGE_LIBVIRT_LXC which selects BR2_PACKAGE_LXC but did not add
> the dependency !BR2_TOOLCHAIN_USES_UCLIBC which was added to lxc in
> 2019 by buildroot commit 63aad8a53e33e3fae4793e05662f47637e9e9bfc
> causing Kconfig warnings:
> 
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_LXC
>   Depends on [n]: BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y]
>     && !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 [=y]
>     && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 [=y] && !BR2_TOOLCHAIN_USES_UCLIBC [=y]
>   Selected by [y]:
>   - BR2_PACKAGE_LIBVIRT_LXC [=y] && BR2_PACKAGE_LIBVIRT [=y]
>       && BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 [=y]
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.02.x & 2025.11.x. Thanks

> ---
>  package/libvirt/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> index 5664f69dd8..0f73128d09 100644
> --- a/package/libvirt/Config.in
> +++ b/package/libvirt/Config.in
> @@ -89,12 +89,14 @@ comment "qemu needs a toolchain with gcc >= 8"
>  config BR2_PACKAGE_LIBVIRT_LXC
>  	bool "lxc"
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # lxc
> +	depends on !BR2_TOOLCHAIN_USES_UCLIBC # lxc
>  	select BR2_PACKAGE_LXC
>  	help
>  	  Linux Container support
>  
> -comment "lxc needs a toolchain w/ gcc >= 4.7"
> -	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
> +comment "lxc needs a glibc or musl toolchain w/ gcc >= 4.7"
> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 \
> +		|| BR2_TOOLCHAIN_USES_UCLIBC
>  
>  endif
>  
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2026-03-06 19:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01 19:37 [Buildroot] [PATCH 1/1] package/libvirt: fix dependency of lxc support Bernd Kuhls
2026-03-01 21:22 ` Peter Korsgaard
2026-03-06 19:53 ` Thomas Perale via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260306195317.8067-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=thomas.perale@mind.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox