From: Andreas Ziegler <br025@umbiko.net>
To: buildroot@buildroot.org
Cc: Andreas Ziegler <br025@umbiko.net>
Subject: [Buildroot] [PATCH 3/3] package/mpd: add missing optional dependency
Date: Sat, 14 Mar 2026 07:18:35 +0100 [thread overview]
Message-ID: <20260314061837.9425-4-br025@umbiko.net> (raw)
In-Reply-To: <20260314061837.9425-1-br025@umbiko.net>
Config.in selects libiconv in certain situations (uClibc with locales
not enabled). This may lead to a build error with utils/test-pkg -p mpd.
Add missing optional dependency and restore sorting order.
Signed-off-by: Andreas Ziegler <br025@umbiko.net>
---
package/mpd/mpd.mk | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index c8107be128..ce7c44a9a8 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -26,14 +26,6 @@ MPD_CONF_OPTS = \
-Dpipewire=disabled \
-Dsnapcast=false
-# Zeroconf support depends on libdns_sd from avahi.
-ifeq ($(BR2_PACKAGE_MPD_AVAHI_SUPPORT),y)
-MPD_DEPENDENCIES += avahi
-MPD_CONF_OPTS += -Dzeroconf=avahi
-else
-MPD_CONF_OPTS += -Dzeroconf=disabled
-endif
-
ifeq ($(BR2_PACKAGE_EXPAT),y)
MPD_DEPENDENCIES += expat
MPD_CONF_OPTS += -Dexpat=enabled
@@ -49,6 +41,14 @@ else
MPD_CONF_OPTS += -Dicu=disabled
endif
+# uClibc w/o locales
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+MPD_DEPENDENCIES += libiconv
+MPD_CONF_OPTS += -Diconv=enabled
+else
+MPD_CONF_OPTS += -Diconv=disabled
+endif
+
ifeq ($(BR2_PACKAGE_JSON_FOR_MODERN_CPP),y)
MPD_DEPENDENCIES += json-for-modern-cpp
MPD_CONF_OPTS += -Dnlohmann_json=enabled
@@ -63,6 +63,14 @@ else
MPD_CONF_OPTS += -Dalsa=disabled
endif
+# Zeroconf support depends on libdns_sd from avahi.
+ifeq ($(BR2_PACKAGE_MPD_AVAHI_SUPPORT),y)
+MPD_DEPENDENCIES += avahi
+MPD_CONF_OPTS += -Dzeroconf=avahi
+else
+MPD_CONF_OPTS += -Dzeroconf=disabled
+endif
+
ifeq ($(BR2_PACKAGE_MPD_AO),y)
MPD_DEPENDENCIES += libao
MPD_CONF_OPTS += -Dao=enabled
--
2.53.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-03-14 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 6:18 [Buildroot] [PATCH 0/3] package/mpd: fix configuration Andreas Ziegler
2026-03-14 6:18 ` [Buildroot] [PATCH 1/3] package/mpd: enforce tcp for options using http Andreas Ziegler
2026-03-21 22:10 ` Julien Olivain via buildroot
2026-03-27 10:02 ` Thomas Perale via buildroot
2026-03-14 6:18 ` [Buildroot] [PATCH 2/3] package/mpd: disable build of manuals Andreas Ziegler
2026-03-27 10:02 ` Thomas Perale via buildroot
2026-03-14 6:18 ` Andreas Ziegler [this message]
2026-03-27 10:02 ` [Buildroot] [PATCH 3/3] package/mpd: add missing optional dependency Thomas Perale via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260314061837.9425-4-br025@umbiko.net \
--to=br025@umbiko.net \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox