Re: [Buildroot] [PATCH 1/2] package/ltp-testsuite: Always require host-pkgconf

[Petr Vorel <petr.vorel@gmail.com>]

Hi all,

> Require host-pkgconf only for libtirpc is not enough because libmnl
> requires as well.

> Upstream added it since 20200515 commit
> 553ca8ea3b ("net/route: Add netlink based route change tests")
> using it in m4/ltp-libmnl.m4.

> Later, in 20210524 in commit
> 6e17e2ba13 ("configure: Improve error message on missing pkg-config")
> configure.ac required it explicitly:

> m4_ifndef([PKG_CHECK_EXISTS],
> 	[m4_fatal([must install pkg-config or pkgconfig and pkg.m4 macro (usual dependency), see INSTALL])])

> This fixes error:
> checking pkg-config is at least version 0.9.0... ./configure: line 7419: br-mips64r6-el-hf-glibc/host/bin/pkg-config: No such file or directory

> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Hi all,

> It fixes failures on these old toolchains:
> * br-mips64r6-el-hf-glibc [33/35]: FAILED
> * br-powerpc64-power7-glibc [35/35]: FAILED

> Although both removed in 8bab0acff6 and 573a113edd it's a valid change.

Gently ping about this commit. It fixes build errors.

Kind regards,
Petr

>  package/ltp-testsuite/ltp-testsuite.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

> diff --git a/package/ltp-testsuite/ltp-testsuite.mk b/package/ltp-testsuite/ltp-testsuite.mk
> index e4e3ff8717..12db8f2d3b 100644
> --- a/package/ltp-testsuite/ltp-testsuite.mk
> +++ b/package/ltp-testsuite/ltp-testsuite.mk
> @@ -11,6 +11,8 @@ LTP_TESTSUITE_SITE = https://github.com/linux-test-project/ltp/releases/download
>  LTP_TESTSUITE_LICENSE = GPL-2.0, GPL-2.0+
>  LTP_TESTSUITE_LICENSE_FILES = COPYING

> +LTP_TESTSUITE_DEPENDENCIES += host-pkgconf
> +
>  LTP_TESTSUITE_CONF_OPTS += --disable-metadata

>  ifeq ($(BR2_PACKAGE_LTP_TESTSUITE_OPEN_POSIX),y)
> @@ -51,7 +53,7 @@ LTP_TESTSUITE_CFLAGS = $(TARGET_CFLAGS)
>  LTP_TESTSUITE_LIBS =

>  ifeq ($(BR2_PACKAGE_LIBTIRPC),y)
> -LTP_TESTSUITE_DEPENDENCIES += libtirpc host-pkgconf
> +LTP_TESTSUITE_DEPENDENCIES += libtirpc
>  LTP_TESTSUITE_CFLAGS += "`$(PKG_CONFIG_HOST_BINARY) --cflags libtirpc`"
>  LTP_TESTSUITE_LIBS += "`$(PKG_CONFIG_HOST_BINARY) --libs libtirpc`"
>  endif
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot