[Buildroot] [PATCH 0/3] package/mpd: fix configuration

[Buildroot] [PATCH 0/3] package/mpd: fix configuration

[Andreas Ziegler]

/1/ Fixes an autobuilder error
/2/ Saves some electrons by disabling manuals being built
/3/ Adds a missing dependency (came up in another test, no autobuilder error

Andreas Ziegler (3):
  package/mpd: enforce tcp for options using http
  package/mpd: disable build of manuals
  package/mpd: add missing optional dependency

 package/mpd/Config.in |  3 +++
 package/mpd/mpd.mk    | 26 ++++++++++++++++++--------
 2 files changed, 21 insertions(+), 8 deletions(-)

-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 1/3] package/mpd: enforce tcp for options using http

[Andreas Ziegler]

Prevent disabling of TCP if some option is selected that uses HTTP.

Fixes:
https://autobuild.buildroot.org/results/59b0be79b1ca1469477e7634205f3eaaebef7d5f

Signed-off-by: Andreas Ziegler <br025@umbiko.net>
---
 package/mpd/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index d8ce930cc5..1b6815e904 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -204,6 +204,7 @@ config BR2_PACKAGE_MPD_CDIO_PARANOIA
 
 config BR2_PACKAGE_MPD_CURL
 	bool "curl"
+	select BR2_PACKAGE_MPD_TCP
 	select BR2_PACKAGE_LIBCURL
 	help
 	  Enable curl streaming (http) support.
@@ -258,6 +259,7 @@ config BR2_PACKAGE_MPD_AO
 
 config BR2_PACKAGE_MPD_HTTPD_OUTPUT
 	bool "httpd output"
+	select BR2_PACKAGE_MPD_TCP
 	help
 	  Enable httpd output support.
 
@@ -341,6 +343,7 @@ comment "io_uring support needs a toolchain w/ headers >= 5.1"
 
 config BR2_PACKAGE_MPD_LIBMPDCLIENT
 	bool "libmpdclient"
+	select BR2_PACKAGE_MPD_TCP
 	select BR2_PACKAGE_LIBMPDCLIENT
 	help
 	  Enable libmpdclient support.
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] package/mpd: enforce tcp for options using http

[Julien Olivain via buildroot]

On 14/03/2026 07:18, Andreas Ziegler wrote:
> Prevent disabling of TCP if some option is selected that uses HTTP.
> 
> Fixes:
> https://autobuild.buildroot.org/results/59b0be79b1ca1469477e7634205f3eaaebef7d5f
> 
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>

Series applied to master, thanks.
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/3] package/mpd: enforce tcp for options using http

[Thomas Perale via buildroot]

In reply of:
> Prevent disabling of TCP if some option is selected that uses HTTP.
> 
> Fixes:
> https://autobuild.buildroot.org/results/59b0be79b1ca1469477e7634205f3eaaebef7d5f
> 
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>

Applied to 2026.02.x & 2025.02.x. Thanks

> ---
>  package/mpd/Config.in | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
> index d8ce930cc5..1b6815e904 100644
> --- a/package/mpd/Config.in
> +++ b/package/mpd/Config.in
> @@ -204,6 +204,7 @@ config BR2_PACKAGE_MPD_CDIO_PARANOIA
>  
>  config BR2_PACKAGE_MPD_CURL
>  	bool "curl"
> +	select BR2_PACKAGE_MPD_TCP
>  	select BR2_PACKAGE_LIBCURL
>  	help
>  	  Enable curl streaming (http) support.
> @@ -258,6 +259,7 @@ config BR2_PACKAGE_MPD_AO
>  
>  config BR2_PACKAGE_MPD_HTTPD_OUTPUT
>  	bool "httpd output"
> +	select BR2_PACKAGE_MPD_TCP
>  	help
>  	  Enable httpd output support.
>  
> @@ -341,6 +343,7 @@ comment "io_uring support needs a toolchain w/ headers >= 5.1"
>  
>  config BR2_PACKAGE_MPD_LIBMPDCLIENT
>  	bool "libmpdclient"
> +	select BR2_PACKAGE_MPD_TCP
>  	select BR2_PACKAGE_LIBMPDCLIENT
>  	help
>  	  Enable libmpdclient support.
> -- 
> 2.53.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 2/3] package/mpd: disable build of manuals

[Andreas Ziegler]

The documentation feature was introduced with version 0.22, but is not
used. Instead two other options (also introduced with 0.22) control
building HTML manual and man pages. If the tools needed are not found,
the documentation build finishes silently.

Save Meson some effort by setting both options to 'false'.

Signed-off-by: Andreas Ziegler <br025@umbiko.net>
---
 package/mpd/mpd.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index 3df6276a11..c8107be128 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -19,6 +19,8 @@ MPD_SELINUX_MODULES = mpd
 MPD_CONF_OPTS = \
 	-Daudiofile=disabled \
 	-Ddocumentation=disabled \
+	-Dhtml_manual=false \
+	-Dmanpages=false \
 	-Dmpcdec=disabled \
 	-Dopenmpt=disabled \
 	-Dpipewire=disabled \
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 2/3] package/mpd: disable build of manuals

[Thomas Perale via buildroot]

In reply of:
> The documentation feature was introduced with version 0.22, but is not
> used. Instead two other options (also introduced with 0.22) control
> building HTML manual and man pages. If the tools needed are not found,
> the documentation build finishes silently.
> 
> Save Meson some effort by setting both options to 'false'.
> 
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>

Applied to 2026.02.x & 2025.02.x. Thanks

> ---
>  package/mpd/mpd.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
> index 3df6276a11..c8107be128 100644
> --- a/package/mpd/mpd.mk
> +++ b/package/mpd/mpd.mk
> @@ -19,6 +19,8 @@ MPD_SELINUX_MODULES = mpd
>  MPD_CONF_OPTS = \
>  	-Daudiofile=disabled \
>  	-Ddocumentation=disabled \
> +	-Dhtml_manual=false \
> +	-Dmanpages=false \
>  	-Dmpcdec=disabled \
>  	-Dopenmpt=disabled \
>  	-Dpipewire=disabled \
> -- 
> 2.53.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

[Buildroot] [PATCH 3/3] package/mpd: add missing optional dependency

[Andreas Ziegler]

Config.in selects libiconv in certain situations (uClibc with locales
not enabled). This may lead to a build error with utils/test-pkg -p mpd.

Add missing optional dependency and restore sorting order.

Signed-off-by: Andreas Ziegler <br025@umbiko.net>
---
 package/mpd/mpd.mk | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
index c8107be128..ce7c44a9a8 100644
--- a/package/mpd/mpd.mk
+++ b/package/mpd/mpd.mk
@@ -26,14 +26,6 @@ MPD_CONF_OPTS = \
 	-Dpipewire=disabled \
 	-Dsnapcast=false
 
-# Zeroconf support depends on libdns_sd from avahi.
-ifeq ($(BR2_PACKAGE_MPD_AVAHI_SUPPORT),y)
-MPD_DEPENDENCIES += avahi
-MPD_CONF_OPTS += -Dzeroconf=avahi
-else
-MPD_CONF_OPTS += -Dzeroconf=disabled
-endif
-
 ifeq ($(BR2_PACKAGE_EXPAT),y)
 MPD_DEPENDENCIES += expat
 MPD_CONF_OPTS += -Dexpat=enabled
@@ -49,6 +41,14 @@ else
 MPD_CONF_OPTS += -Dicu=disabled
 endif
 
+# uClibc w/o locales
+ifeq ($(BR2_PACKAGE_LIBICONV),y)
+MPD_DEPENDENCIES += libiconv
+MPD_CONF_OPTS += -Diconv=enabled
+else
+MPD_CONF_OPTS += -Diconv=disabled
+endif
+
 ifeq ($(BR2_PACKAGE_JSON_FOR_MODERN_CPP),y)
 MPD_DEPENDENCIES += json-for-modern-cpp
 MPD_CONF_OPTS += -Dnlohmann_json=enabled
@@ -63,6 +63,14 @@ else
 MPD_CONF_OPTS += -Dalsa=disabled
 endif
 
+# Zeroconf support depends on libdns_sd from avahi.
+ifeq ($(BR2_PACKAGE_MPD_AVAHI_SUPPORT),y)
+MPD_DEPENDENCIES += avahi
+MPD_CONF_OPTS += -Dzeroconf=avahi
+else
+MPD_CONF_OPTS += -Dzeroconf=disabled
+endif
+
 ifeq ($(BR2_PACKAGE_MPD_AO),y)
 MPD_DEPENDENCIES += libao
 MPD_CONF_OPTS += -Dao=enabled
-- 
2.53.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 3/3] package/mpd: add missing optional dependency

[Thomas Perale via buildroot]

In reply of:
> Config.in selects libiconv in certain situations (uClibc with locales
> not enabled). This may lead to a build error with utils/test-pkg -p mpd.
> 
> Add missing optional dependency and restore sorting order.
> 
> Signed-off-by: Andreas Ziegler <br025@umbiko.net>

Applied to 2026.02.x & 2025.02.x. Thanks

> ---
>  package/mpd/mpd.mk | 24 ++++++++++++++++--------
>  1 file changed, 16 insertions(+), 8 deletions(-)
> 
> diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
> index c8107be128..ce7c44a9a8 100644
> --- a/package/mpd/mpd.mk
> +++ b/package/mpd/mpd.mk
> @@ -26,14 +26,6 @@ MPD_CONF_OPTS = \
>  	-Dpipewire=disabled \
>  	-Dsnapcast=false
>  
> -# Zeroconf support depends on libdns_sd from avahi.
> -ifeq ($(BR2_PACKAGE_MPD_AVAHI_SUPPORT),y)
> -MPD_DEPENDENCIES += avahi
> -MPD_CONF_OPTS += -Dzeroconf=avahi
> -else
> -MPD_CONF_OPTS += -Dzeroconf=disabled
> -endif
> -
>  ifeq ($(BR2_PACKAGE_EXPAT),y)
>  MPD_DEPENDENCIES += expat
>  MPD_CONF_OPTS += -Dexpat=enabled
> @@ -49,6 +41,14 @@ else
>  MPD_CONF_OPTS += -Dicu=disabled
>  endif
>  
> +# uClibc w/o locales
> +ifeq ($(BR2_PACKAGE_LIBICONV),y)
> +MPD_DEPENDENCIES += libiconv
> +MPD_CONF_OPTS += -Diconv=enabled
> +else
> +MPD_CONF_OPTS += -Diconv=disabled
> +endif
> +
>  ifeq ($(BR2_PACKAGE_JSON_FOR_MODERN_CPP),y)
>  MPD_DEPENDENCIES += json-for-modern-cpp
>  MPD_CONF_OPTS += -Dnlohmann_json=enabled
> @@ -63,6 +63,14 @@ else
>  MPD_CONF_OPTS += -Dalsa=disabled
>  endif
>  
> +# Zeroconf support depends on libdns_sd from avahi.
> +ifeq ($(BR2_PACKAGE_MPD_AVAHI_SUPPORT),y)
> +MPD_DEPENDENCIES += avahi
> +MPD_CONF_OPTS += -Dzeroconf=avahi
> +else
> +MPD_CONF_OPTS += -Dzeroconf=disabled
> +endif
> +
>  ifeq ($(BR2_PACKAGE_MPD_AO),y)
>  MPD_DEPENDENCIES += libao
>  MPD_CONF_OPTS += -Dao=enabled
> -- 
> 2.53.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot