public inbox for buildroot@busybox.net
 help / color / mirror / Atom feed
From: Flaviu Nistor <flaviu.nistor@gmail.com>
To: Arnout Vandecappelle <arnout@rnout.be>
Cc: buildroot@buildroot.org, Flaviu Nistor <flaviu.nistor@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] utils/scanpypi: workaround for pypi project names
Date: Thu,  9 Apr 2026 18:21:55 +0300	[thread overview]
Message-ID: <20260409152155.5801-1-flaviu.nistor@gmail.com> (raw)
In-Reply-To: <0a191350-d411-4247-934c-a17ddbaa3562@rnout.be>

On 07/04/2026 11:59, Arnout Vandecappelle wrote:
>On 27/03/2026 07:43, Flaviu Nistor wrote:
>> Add a dictionary for buildroot packages that have a different
>> name compared to the pypi project name (e.g. smmap2 -> smmap).
>> Since it is not intended to change the buildroot package name,
>> this is a workaround in order to use the scanpypi utility for
>> this packages and still get correct generated files. Current
>> packages added in the dictionary by this commit are smmap2 and
>> gitdb2.
>
>  Would it be an option, instead of having this mapping table, to parse the name 
>out of the .mk file if it exists? So if you do scanpypi smmap2, it will check if 
>package/python-smmap2/python-smmap2.mk exists, and if yes read the _SOURCE to 
>find the upstream name.
>
  Indeed that would be a better solution and less subjected to human error. I will
prepare a new version based on your suggestion and come back with a v2.

  Thank you,
  Flaviu

>  Regards,
>  Arnout
>
>> 
>> Signed-off-by: Flaviu Nistor <flaviu.nistor@gmail.com>
>> ---
>>   utils/scanpypi | 18 +++++++++++++++---
>>   1 file changed, 15 insertions(+), 3 deletions(-)
>> 
>> diff --git a/utils/scanpypi b/utils/scanpypi
>> index 61879e39d4..09899bfe0e 100755
>> --- a/utils/scanpypi
>> +++ b/utils/scanpypi
>> @@ -189,6 +189,14 @@ class BuildrootPackage():
>>       create_config_in
>>   
>>       """
>> +
>> +    # Dictionary of python package names to their actual PyPI project names
>> +    # Used when a package's buildroot name differs from its PyPI name
>> +    PYPI_NAME_MAPPINGS = {
>> +        'smmap2': 'smmap',
>> +        'gitdb2': 'gitdb',
>> +    }
>> +
>>       setup_args = {}
>>   
>>       def __init__(self, real_name, pkg_folder):
>> @@ -216,8 +224,12 @@ class BuildrootPackage():
>>           """
>>           Fetch a package's metadata from the python package index
>>           """
>> +
>> +        # Check if there's a PyPI name in the dictionary for this package
>> +        pypi_name = self.PYPI_NAME_MAPPINGS.get(self.real_name, self.real_name)
>> +
>>           self.metadata_url = 'https://pypi.org/pypi/{pkg}/json'.format(
>> -            pkg=self.real_name)
>> +            pkg=pypi_name)
>>           try:
>>               pkg_json = urllib.request.urlopen(self.metadata_url).read().decode()
>>           except urllib.error.HTTPError as error:
>> @@ -225,13 +237,13 @@ class BuildrootPackage():
>>               print('ERROR: Could not find package {pkg}.\n'
>>                     'Check syntax inside the python package index:\n'
>>                     'https://pypi.python.org/pypi/ '
>> -                  .format(pkg=self.real_name))
>> +                  .format(pkg=pypi_name))
>>               raise
>>           except urllib.error.URLError:
>>               print('ERROR: Could not find package {pkg}.\n'
>>                     'Check syntax inside the python package index:\n'
>>                     'https://pypi.python.org/pypi/ '
>> -                  .format(pkg=self.real_name))
>> +                  .format(pkg=pypi_name))
>>               raise
>>           self.metadata = json.loads(pkg_json)
>>           self.version = self.metadata['info']['version']
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-04-09 15:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27  6:43 [Buildroot] [PATCH 0/1] utils/scanpypi: workaround for pypi project names Flaviu Nistor
2026-03-27  6:43 ` [Buildroot] [PATCH 1/1] " Flaviu Nistor
2026-04-07 18:59   ` Arnout Vandecappelle via buildroot
2026-04-09 15:21     ` Flaviu Nistor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260409152155.5801-1-flaviu.nistor@gmail.com \
    --to=flaviu.nistor@gmail.com \
    --cc=arnout@rnout.be \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox