From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Michael Nosthoff <buildroot@heine.tech>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/log4cxx: fix ENABLE_ESMTP flag
Date: Mon, 4 May 2026 16:47:10 +0200 [thread overview]
Message-ID: <20260504144710.8882-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260211143236.4018275-2-buildroot@heine.tech>
In reply of:
> commit cf686670b99ae0388b27867db64516c09b2de91f introduced a patch that
> was later included in a release which made the usage of libesmtp
> configurable. Later the switch was moved to the main CMakeLists.mk [0].
>
> while the patch introduced the build flag LOG4CXX_ENABLE_ESMTP the
> change to the .mk file used LOG4CXX_ENABLE_LIBESMTP.
>
> So correct this.
>
> Fixes:
> CMake Warning:
> Manually-specified variables were not used by the project:
> LOG4CXX_ENABLE_LIBESMTP
>
> [0] https://github.com/apache/logging-log4cxx/blob/rel/v1.3.1/CMakeLists.txt#L93
>
> Signed-off-by: Michael Nosthoff <buildroot@heine.tech>
>
Applied to 2025.02.x. Thanks
> ---
>
> V2:
> - use correct param name in commit message
> - add reference to current CMakeLists.mk
> ---
> package/log4cxx/log4cxx.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/log4cxx/log4cxx.mk b/package/log4cxx/log4cxx.mk
> index f4fb3854f3..57f9b1e844 100644
> --- a/package/log4cxx/log4cxx.mk
> +++ b/package/log4cxx/log4cxx.mk
> @@ -23,10 +23,10 @@ LOG4CXX_DEPENDENCIES += boost
> endif
>
> ifeq ($(BR2_PACKAGE_LIBESMTP),y)
> -LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=ON
> +LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=ON
> LOG4CXX_DEPENDENCIES += libesmtp
> else
> -LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_LIBESMTP=OFF
> +LOG4CXX_CONF_OPTS += -DLOG4CXX_ENABLE_ESMTP=OFF
> endif
>
> ifeq ($(BR2_PACKAGE_UNIXODBC),y)
> --
> 2.43.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-05-04 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 14:32 [Buildroot] [PATCH v2] package/log4cxx: fix ENABLE_ESMTP flag Michael Nosthoff via buildroot
2026-02-13 11:13 ` Julien Olivain via buildroot
2026-05-04 14:47 ` Thomas Perale via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260504144710.8882-1-thomas.perale@mind.be \
--to=buildroot@buildroot.org \
--cc=buildroot@heine.tech \
--cc=thomas.perale@mind.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox