Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/3] package/neon: fix build with zlib
Date: Mon,  4 May 2026 16:47:41 +0200	[thread overview]
Message-ID: <20260504144741.10108-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260421183845.2456995-2-bernd@kuhls.net>

In reply of:
> Building this defconfig
> 
> BR2_x86_64=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_PACKAGE_NEON=y
> BR2_PACKAGE_NEON_ZLIB=y
> 
> does not build libneon with zlib support, quoting configure log:
> 
>   configure: zlib not enabled
> 
> although the configure parameter
> 
>   --with-zlib=/home/bernd/buildroot/output/host/x86_64-buildroot-linux-gnu/sysroot
> 
> was used.
> 
> The reason is the addition of "=$(STAGING_DIR)" to --with-zlib which was
> added to buildroot in 2008 with commit
> cc6562ff839502a65a3b202ffe7fa3c67bae0856.
> 
> The upstream code, which expects only "yes", all other values lead to
> the else-condition, is unchanged since 2004:
> https://github.com/notroj/neon/blame/0.37.1/macros/neon.m4#L478
> so a backport of this patch to LTS branches should be considered.
> 
> With this patch the configure log shows:
> 
>   checking for zlib.h... yes
>   checking for inflate in -lz... yes
>   configure: zlib support enabled, using -lz
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.02.x & 2026.02.x. Thanks

> ---
>  package/neon/neon.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/neon/neon.mk b/package/neon/neon.mk
> index e7872df3c9..39abbaef48 100644
> --- a/package/neon/neon.mk
> +++ b/package/neon/neon.mk
> @@ -16,7 +16,7 @@ NEON_DEPENDENCIES = host-pkgconf $(TARGET_NLS_DEPENDENCIES)
>  NEON_CONF_ENV = ne_cv_libsfor_bindtextdomain=$(TARGET_NLS_LIBS)
>  
>  ifeq ($(BR2_PACKAGE_NEON_ZLIB),y)
> -NEON_CONF_OPTS += --with-zlib=$(STAGING_DIR)
> +NEON_CONF_OPTS += --with-zlib
>  NEON_DEPENDENCIES += zlib
>  else
>  NEON_CONF_OPTS += --without-zlib
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-05-04 14:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 18:38 [Buildroot] [PATCH 1/3] package/davfs2: bump version to 1.7.3 Bernd Kuhls
2026-04-21 18:38 ` [Buildroot] [PATCH 2/3] package/neon: fix build with zlib Bernd Kuhls
2026-05-04 14:47   ` Thomas Perale via buildroot [this message]
2026-04-21 18:38 ` [Buildroot] [PATCH 3/3] package/neon: bump version to 0.37.1 Bernd Kuhls
2026-04-24 21:42 ` [Buildroot] [PATCH 1/3] package/davfs2: bump version to 1.7.3 Julien Olivain via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504144741.10108-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=thomas.perale@mind.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox