Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Francois Perrad <francois.perrad@gadz.org>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@busybox.net
Subject: Re: [Buildroot] [PATCH v3 1/2] package/ficl: downgrade to version 3.03
Date: Mon,  4 May 2026 16:47:44 +0200	[thread overview]
Message-ID: <20260504144744.10295-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260422163125.5757-2-francois.perrad@gadz.org>

In reply of:
> see https://sourceforge.net/p/ficl/news/2025/07/ficl4-is-retiring/
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

Applied to 2025.02.x & 2026.02.x. Thanks

> ---
>  .checkpackageignore                           |  1 -
>  package/ficl/0001-fix-Makefile.patch          | 47 -------------------
>  package/ficl/0001-missing-include.patch       | 26 ++++++++++
>  .../0002-Makefile.linux-pass-LDFLAGS.patch    | 19 ++++----
>  package/ficl/ficl.hash                        |  4 +-
>  package/ficl/ficl.mk                          | 20 ++++----
>  6 files changed, 49 insertions(+), 68 deletions(-)
>  delete mode 100644 package/ficl/0001-fix-Makefile.patch
>  create mode 100644 package/ficl/0001-missing-include.patch
> 
> diff --git a/.checkpackageignore b/.checkpackageignore
> index 695e0d50c..6b391d926 100644
> --- a/.checkpackageignore
> +++ b/.checkpackageignore
> @@ -343,7 +343,6 @@ package/ffmpeg/0001-swscale-x86-yuv2rgb-Fix-build-without-SSSE3.patch lib_patch.
>  package/ffmpeg/0002-avcodec-vaapi_h264-skip-decode-if-pic-has-no-slices.patch lib_patch.Upstream
>  package/ffmpeg/0003-libavutil-Fix-mips-build.patch lib_patch.Upstream
>  package/ffmpeg/0004-configure-add-extralibs-to-extralibs_xxx.patch lib_patch.Upstream
> -package/ficl/0001-fix-Makefile.patch lib_patch.Upstream
>  package/flatbuffers/0001-include-flatbuffers-base.h-fix-build-on-musl.patch lib_patch.Upstream
>  package/flex/0001-build-AC_USE_SYSTEM_EXTENSIONS-in-configure.ac.patch lib_patch.Upstream
>  package/flex/0002-build-make-it-possible-to-disable-the-build-of-the-f.patch lib_patch.Upstream
> diff --git a/package/ficl/0001-fix-Makefile.patch b/package/ficl/0001-fix-Makefile.patch
> deleted file mode 100644
> index d5a25c43f..000000000
> --- a/package/ficl/0001-fix-Makefile.patch
> +++ /dev/null
> @@ -1,47 +0,0 @@
> -fix dependency in Makefiles
> -
> -there is no longer a sysdep.h file.
> -
> -Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> -
> -diff --git a/Makefile b/Makefile
> -index 976d00a..7f73c44 100644
> ---- a/Makefile
> -+++ b/Makefile
> -@@ -29,7 +29,7 @@ libficl.so.$(MAJOR).$(MINOR): $(OBJECTS)
> - 	-o libficl.so.$(MAJOR).$(MINOR) $(OBJECTS)
> - 	ln -sf libficl.so.$(MAJOR).$(MINOR) libficl.so
> - 
> --main: main.o ficl.h sysdep.h libficl.so.$(MAJOR).$(MINOR)
> -+main: main.o ficl.h libficl.so.$(MAJOR).$(MINOR)
> - 	$(CC) $(CFLAGS) $(LDFLAGS) main.o -o main -L. -lficl -lm
> - 	ln -sf libficl.so.$(MAJOR).$(MINOR) libficl.so.$(MAJOR)
> - 
> -diff --git a/Makefile.ansi b/Makefile.ansi
> -index e510fcd..170e6eb 100644
> ---- a/Makefile.ansi
> -+++ b/Makefile.ansi
> -@@ -29,7 +29,7 @@ libficl.so.$(MAJOR).$(MINOR): $(OBJECTS)
> - 	-o libficl.so.$(MAJOR).$(MINOR) $(OBJECTS)
> - 	ln -sf libficl.so.$(MAJOR).$(MINOR) libficl.so
> - 
> --main: main.o ficl.h sysdep.h libficl.so.$(MAJOR).$(MINOR)
> -+main: main.o ficl.h libficl.so.$(MAJOR).$(MINOR)
> - 	$(CC) main.o -o main -L. -lficl -lm
> - 	ln -sf libficl.so.$(MAJOR).$(MINOR) libficl.so.$(MAJOR)
> - 
> -diff --git a/Makefile.linux b/Makefile.linux
> -index d447e7e..7f2cdfe 100644
> ---- a/Makefile.linux
> -+++ b/Makefile.linux
> -@@ -29,7 +29,7 @@ libficl.so.$(MAJOR).$(MINOR): $(OBJECTS)
> - 	-o libficl.so.$(MAJOR).$(MINOR) $(OBJECTS)
> - 	ln -sf libficl.so.$(MAJOR).$(MINOR) libficl.so
> - 
> --main: main.o ficl.h sysdep.h libficl.so.$(MAJOR).$(MINOR)
> -+main: main.o ficl.h libficl.so.$(MAJOR).$(MINOR)
> - 	$(CC) main.o -o main -L. -lficl -lm
> - 	ln -sf libficl.so.$(MAJOR).$(MINOR) libficl.so.$(MAJOR)
> - 
> --- 
> -
> diff --git a/package/ficl/0001-missing-include.patch b/package/ficl/0001-missing-include.patch
> new file mode 100644
> index 000000000..a52089623
> --- /dev/null
> +++ b/package/ficl/0001-missing-include.patch
> @@ -0,0 +1,26 @@
> +From 87c78eea2c4ac69c09947c8e49f8e8668640071c Mon Sep 17 00:00:00 2001
> +From: Francois Perrad <francois.perrad@gadz.org>
> +Date: Sun, 7 Dec 2025 10:15:27 +0100
> +Subject: [PATCH] missing include
> +
> +Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> +Upstream: upstream is dead
> +---
> + fileaccess.c | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/fileaccess.c b/fileaccess.c
> +index 738889d..c03d5d6 100644
> +--- a/fileaccess.c
> ++++ b/fileaccess.c
> +@@ -4,6 +4,7 @@
> + #include <string.h>
> + #include <ctype.h>
> + #include <sys/stat.h>
> ++#include <unistd.h>
> + #include "ficl.h"
> + 
> + #if FICL_WANT_FILE
> +-- 
> +2.43.0
> +
> diff --git a/package/ficl/0002-Makefile.linux-pass-LDFLAGS.patch b/package/ficl/0002-Makefile.linux-pass-LDFLAGS.patch
> index dd9e16412..aa5c00edb 100644
> --- a/package/ficl/0002-Makefile.linux-pass-LDFLAGS.patch
> +++ b/package/ficl/0002-Makefile.linux-pass-LDFLAGS.patch
> @@ -15,6 +15,8 @@ Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>  Upstream: upstream is dead
>  [Dario: make the patch to be applied with fuzz factor 0]
>  Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> +[francois: downgrade to 3.03]
> +Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
>  ---
>   Makefile.linux | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> @@ -23,14 +25,15 @@ diff --git a/Makefile.linux b/Makefile.linux
>  index 5f1a41f..df887e6 100644
>  --- a/Makefile.linux
>  +++ b/Makefile.linux
> -@@ -14,6 +14,6 @@ MINOR = 1.0
> - 
> - ficl: main.o $(HEADERS) libficl.a
> --	$(CC) main.o -o ficl -L. -lficl -lm
> -+	$(CC) $(LDFLAGS) main.o -o ficl -L. -lficl -lm
> - 
> - lib: libficl.so.$(MAJOR).$(MINOR)
> - 
> +@@ -13,7 +13,7 @@ MAJOR = 3
> + MINOR = 0.1
> + 
> + ficl: testmain.o ficl.h sysdep.h libficl.a
> +-	$(CC) testmain.o -o ficl -L. -lficl -lm
> ++	$(CC) $(LDFLAGS) testmain.o -o ficl -L. -lficl -lm
> + 
> + lib: libficl.so.$(MAJOR).$(MINOR)
> + 
>  -- 
>  2.35.1
>  
> diff --git a/package/ficl/ficl.hash b/package/ficl/ficl.hash
> index df53c843c..1a4a54e70 100644
> --- a/package/ficl/ficl.hash
> +++ b/package/ficl/ficl.hash
> @@ -1,3 +1,3 @@
>  # Locally computed:
> -sha256  4daf74f3d3d6f8b86ea7cb47bc24931d50b4809b50ba34ca32e0ca1e972bd3a3  ficl-4.1.0.tar.gz
> -sha256  1d1dd1f1cde52e8b607c5ccb6a2e5de878fd1719b8c5a4d31b9cdb343c203d0d  ReadMe.txt
> +sha256  064abbea44b2cbbeb53b8df8e5588ed41c4d32dd19bdb897e5d21507691407b2  ficl303.tar.gz
> +sha256  18527f5cdc213d29fb65791e153690974e5426b7e989f3b8eee61c2e5f9e5fcd  ReadMe.txt
> diff --git a/package/ficl/ficl.mk b/package/ficl/ficl.mk
> index c0698a343..ef2e1408c 100644
> --- a/package/ficl/ficl.mk
> +++ b/package/ficl/ficl.mk
> @@ -4,9 +4,11 @@
>  #
>  ################################################################################
>  
> -FICL_VERSION_MAJOR = 4.1
> -FICL_VERSION = $(FICL_VERSION_MAJOR).0
> -FICL_SITE = https://sourceforge.net/projects/ficl/files/OldFiles/Ficl4%20%28retired%29
> +FICL_VERSION = 3.03
> +FICL_TAG = ficl$(subst .,,$(FICL_VERSION))
> +FICL_VERSION_SO = 3.0.1
> +FICL_SOURCE = $(FICL_TAG).tar.gz
> +FICL_SITE = https://sourceforge.net/projects/ficl/files/ficl-all/$(FICL_TAG)
>  FICL_LICENSE = BSD-2-Clause
>  FICL_LICENSE_FILES = ReadMe.txt
>  FICL_INSTALL_STAGING = YES
> @@ -26,14 +28,14 @@ endef
>  endif
>  
>  ifeq ($(BR2_SHARED_LIBS)$(BR2_SHARED_STATIC_LIBS),y)
> -FICL_BUILD_TARGETS += main libficl.so.$(FICL_VERSION)
> +FICL_BUILD_TARGETS += testmain libficl.so.$(FICL_VERSION_SO)
>  define FICL_INSTALL_SHARED_BIN
> -	$(INSTALL) -D -m 0755 $(@D)/main $(TARGET_DIR)/usr/bin/ficl
> +	$(INSTALL) -D -m 0755 $(@D)/testmain $(TARGET_DIR)/usr/bin/ficl
>  endef
>  define FICL_INSTALL_SHARED_LIB
> -	$(INSTALL) -D -m 0755 $(@D)/libficl.so.$(FICL_VERSION) $(1)/usr/lib/libficl.so.$(FICL_VERSION)
> -	ln -sf libficl.so.$(FICL_VERSION) $(1)/usr/lib/libficl.so.4
> -	ln -sf libficl.so.$(FICL_VERSION) $(1)/usr/lib/libficl.so
> +	$(INSTALL) -D -m 0755 $(@D)/libficl.so.$(FICL_VERSION_SO) $(1)/usr/lib/libficl.so.$(FICL_VERSION_SO)
> +	ln -sf libficl.so.$(FICL_VERSION_SO) $(1)/usr/lib/libficl.so.3
> +	ln -sf libficl.so.$(FICL_VERSION_SO) $(1)/usr/lib/libficl.so
>  endef
>  endif
>  
> @@ -46,8 +48,6 @@ define FICL_INSTALL_STAGING_CMDS
>  	$(FICL_INSTALL_STATIC_LIB)
>  	$(call FICL_INSTALL_SHARED_LIB,$(STAGING_DIR))
>  	$(INSTALL) -D -m 0644 $(@D)/ficl.h $(STAGING_DIR)/usr/include/ficl.h
> -	$(INSTALL) -D -m 0644 $(@D)/ficllocal.h $(STAGING_DIR)/usr/include/ficllocal.h
> -	$(INSTALL) -D -m 0644 $(@D)/ficlplatform/unix.h $(STAGING_DIR)/usr/include/ficlplatform/unix.h
>  endef
>  
>  define FICL_INSTALL_TARGET_CMDS
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2026-05-04 14:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 16:31 [Buildroot] [PATCH v3 0/2] ficl Francois Perrad via buildroot
2026-04-22 16:31 ` [Buildroot] [PATCH v3 1/2] package/ficl: downgrade to version 3.03 Francois Perrad via buildroot
2026-04-23 19:54   ` Julien Olivain via buildroot
2026-05-04 14:47   ` Thomas Perale via buildroot [this message]
2026-04-22 16:31 ` [Buildroot] [PATCH v3 2/2] package/ficl: bump to version 3.065 Francois Perrad via buildroot
2026-05-04 14:47   ` Thomas Perale via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260504144744.10295-1-thomas.perale@mind.be \
    --to=buildroot@buildroot.org \
    --cc=buildroot@busybox.net \
    --cc=francois.perrad@gadz.org \
    --cc=thomas.perale@mind.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox