Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kanak Shilledar <kanak.shilledar@axis.com>
To: <buildroot@buildroot.org>
Cc: Kanak Shilledar <kanak.shilledar@axis.com>,
	Petr Vorel <petr.vorel@gmail.com>
Subject: [Buildroot] [RESEND v3 1/1] support: kconfig: Fix compiler warnings
Date: Tue, 12 May 2026 12:56:01 +0200	[thread overview]
Message-ID: <20260512105602.83368-2-kanak.shilledar@axis.com> (raw)
In-Reply-To: <20260512105602.83368-1-kanak.shilledar@axis.com>

Add a new patch to fix the compiler warning given on Ubuntu 24.04.4 in
`util.c` warning of `-Wformat-overflow=`.

```
./util.c: In function ‘file_write_dep’:
./util.c:86:26: warning: ‘%s’ directive writing 10 or more bytes into a region of size between 1 and 4097 [-Wformat-overflow=]
   86 |         sprintf(buf2, "%s%s", dir, name);
      |                          ^~
./util.c:86:9: note: ‘sprintf’ output 11 or more bytes (assuming 4107) into a destination of size 4097
   86 |         sprintf(buf2, "%s%s", dir, name);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Update `buf2` to `PATH_MAX+20` similar to `buf`, thus giving enough
headroom for the filename suffix.

--
Changes in v3:
* Updated the commit message
* Generated the patch using `git format-patch`, and added to the
  `series`.

--
Changes in v2:
* Changed from direct file fix to patch based fix.

Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>
---
 ...upport-kconfig-Fix-compiler-warnings.patch | 45 +++++++++++++++++++
 support/kconfig/patches/series                |  1 +
 2 files changed, 46 insertions(+)
 create mode 100644 support/kconfig/patches/24-support-kconfig-Fix-compiler-warnings.patch

diff --git a/support/kconfig/patches/24-support-kconfig-Fix-compiler-warnings.patch b/support/kconfig/patches/24-support-kconfig-Fix-compiler-warnings.patch
new file mode 100644
index 0000000000..4c76274123
--- /dev/null
+++ b/support/kconfig/patches/24-support-kconfig-Fix-compiler-warnings.patch
@@ -0,0 +1,45 @@
+From 392624743e7166a056474cd83b18743409d2556c Mon Sep 17 00:00:00 2001
+From: Kanak Shilledar <kanak.shilledar@axis.com>
+Date: Fri, 24 Apr 2026 13:32:36 +0200
+Subject: [PATCH] support: kconfig: Fix compiler warnings
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+On Ubuntu 24.04.4, the compiler gives the warning of
+`-Wformat-overflow=`.
+
+```
+./util.c: In function ‘file_write_dep’:
+./util.c:86:26: warning: ‘%s’ directive writing 10 or more bytes into a region of size between 1 and 4097 [-Wformat-overflow=]
+   86 |         sprintf(buf2, "%s%s", dir, name);
+      |                          ^~
+./util.c:86:9: note: ‘sprintf’ output 11 or more bytes (assuming 4107) into a destination of size 4097
+   86 |         sprintf(buf2, "%s%s", dir, name);
+      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+```
+
+Update `buf2` to `PATH_MAX+20` similar to `buf`, thus giving enough
+headroom for the filename suffix.
+
+Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>
+---
+ support/kconfig/util.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/support/kconfig/util.c b/support/kconfig/util.c
+index 8665f5bb89..c2e7979ac1 100644
+--- a/support/kconfig/util.c
++++ b/support/kconfig/util.c
+@@ -35,7 +35,7 @@ struct file *file_lookup(const char *name)
+ int file_write_dep(const char *name)
+ {
+ 	char *str;
+-	char buf[PATH_MAX+20], buf2[PATH_MAX+1], dir[PATH_MAX+1];
++	char buf[PATH_MAX+20], buf2[PATH_MAX+20], dir[PATH_MAX+1];
+ 	struct symbol *sym, *env_sym;
+ 	struct expr *e;
+ 	struct file *file;
+-- 
+2.43.0
+
diff --git a/support/kconfig/patches/series b/support/kconfig/patches/series
index cc176035be..ca2193e734 100644
--- a/support/kconfig/patches/series
+++ b/support/kconfig/patches/series
@@ -12,3 +12,4 @@
 21-Avoid-false-positive-matches-from-comment-lines.patch
 22-kconfig-lxdialog-fix-check-with-GCC14.patch
 23-kconfig-mn-conf-handle-backspace-H-key.patch
+24-support-kconfig-Fix-compiler-warnings.patch
-- 
2.43.0

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-05-12 10:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 10:56 [Buildroot] [RESEND v3 0/1] support: kconfig: Fix compiler warnings Kanak Shilledar
2026-05-12 10:56 ` Kanak Shilledar [this message]
2026-05-12 13:36   ` [Buildroot] [RESEND v3 1/1] " Edgar Bonet via buildroot
2026-05-12 21:16     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260512105602.83368-2-kanak.shilledar@axis.com \
    --to=kanak.shilledar@axis.com \
    --cc=buildroot@buildroot.org \
    --cc=petr.vorel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox