From: Thomas Perale via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: Thomas Perale <thomas.perale@mind.be>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/libnpupnp: needs gcc >= 7
Date: Fri, 17 Jul 2026 17:47:05 +0200 [thread overview]
Message-ID: <20260717154706.191313-1-thomas.perale@mind.be> (raw)
In-Reply-To: <20260704100700.2336075-1-bernd@kuhls.net>
In reply of:
> Buildroot commit 2774502344f35b587ea8f1a2f43ec2398c3ebdad bumped the
> package from 4.2.2 to 6.2.3. Upstream added the usage of
> std::scoped_lock in version 6.2.0:
> https://framagit.org/medoc92/npupnp/-/commit/a760b3278aee06408d9f50d0c54942f5ba9df989
>
> causing a build error detected by the Gitlab pipelines for the
> bootlin-aarch64-glibc-old defconfig:
>
> ../src/inc/upnpapi.h:132:22: error:
> ‘scoped_lock’ is not a member of ‘std’
>
> scoped_lock was introduced in gcc 7.1:
> https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.2017
>
> so we raise the minimum required gcc version accordingly.
>
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
Applied to 2026.05.x. Thanks
> ---
> Series passed Gitlab pipelines:
> https://gitlab.com/bkuhls/buildroot/-/commits/c8f5032e343bc13beaf098027b748575fecec56c
>
> package/libnpupnp/Config.in | 6 +++---
> package/libupnpp/Config.in | 6 +++---
> package/upmpdcli/Config.in | 6 +++---
> 3 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/package/libnpupnp/Config.in b/package/libnpupnp/Config.in
> index cea5bd5c06..846bfe5217 100644
> --- a/package/libnpupnp/Config.in
> +++ b/package/libnpupnp/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBNPUPNP
> bool "libnpupnp"
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_HAS_THREADS
> - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
> select BR2_PACKAGE_EXPAT
> select BR2_PACKAGE_LIBCURL
> select BR2_PACKAGE_LIBMICROHTTPD
> @@ -13,6 +13,6 @@ config BR2_PACKAGE_LIBNPUPNP
>
> https://www.lesbonscomptes.com/upmpdcli/libnpupnp.html
>
> -comment "libnpupnp needs a toolchain w/ C++, threads, gcc >= 4.9"
> +comment "libnpupnp needs a toolchain w/ C++, threads, gcc >= 7"
> depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \
> - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> diff --git a/package/libupnpp/Config.in b/package/libupnpp/Config.in
> index 41afa9300f..634527622d 100644
> --- a/package/libupnpp/Config.in
> +++ b/package/libupnpp/Config.in
> @@ -2,7 +2,7 @@ config BR2_PACKAGE_LIBUPNPP
> bool "libupnpp"
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_HAS_THREADS # libnpupnp
> - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # libnpupnp
> select BR2_PACKAGE_EXPAT
> select BR2_PACKAGE_LIBCURL
> select BR2_PACKAGE_LIBNPUPNP
> @@ -12,5 +12,5 @@ config BR2_PACKAGE_LIBUPNPP
>
> http://www.lesbonscomptes.com/upmpdcli/
>
> -comment "libupnpp needs a toolchain w/ C++, threads, gcc >= 4.9"
> - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> +comment "libupnpp needs a toolchain w/ C++, threads, gcc >= 7"
> + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> diff --git a/package/upmpdcli/Config.in b/package/upmpdcli/Config.in
> index 74eb768830..562d27db37 100644
> --- a/package/upmpdcli/Config.in
> +++ b/package/upmpdcli/Config.in
> @@ -3,7 +3,7 @@ config BR2_PACKAGE_UPMPDCLI
> depends on BR2_USE_MMU # fork()
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
> - depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C++11, libupnpp
> + depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # libnpupnp -> libupnpp
> select BR2_PACKAGE_JSONCPP
> select BR2_PACKAGE_LIBMICROHTTPD
> select BR2_PACKAGE_LIBMPDCLIENT
> @@ -15,8 +15,8 @@ config BR2_PACKAGE_UPMPDCLI
>
> http://www.lesbonscomptes.com/upmpdcli/
>
> -comment "upmpdcli needs a toolchain w/ C++, NPTL, gcc >= 4.9"
> +comment "upmpdcli needs a toolchain w/ C++, NPTL, gcc >= 7"
> depends on BR2_USE_MMU
> depends on !BR2_INSTALL_LIBSTDCPP || \
> !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
> - !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
> + !BR2_TOOLCHAIN_GCC_AT_LEAST_7
> --
> 2.47.3
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2026-07-17 15:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 10:06 [Buildroot] [PATCH 1/2] package/libnpupnp: needs gcc >= 7 Bernd Kuhls
2026-07-04 10:07 ` [Buildroot] [PATCH 2/2] package/libnpupnp: bump version to 6.3.0 Bernd Kuhls
2026-07-14 9:25 ` [Buildroot] [PATCH 1/2] package/libnpupnp: needs gcc >= 7 Julien Olivain via buildroot
2026-07-17 15:47 ` Thomas Perale via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717154706.191313-1-thomas.perale@mind.be \
--to=buildroot@buildroot.org \
--cc=bernd@kuhls.net \
--cc=thomas.perale@mind.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox